upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-09 08:44:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

feat(lexicon): add FLAG_INTERNAL

Browse source 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
This commit is contained in:
Maxence Lange 2025-10-01 12:54:36 -01:00
parent e3edf43e28
commit 1538692987
4 changed files with 23 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
core/Command/Config/App/SetConfig.php
View file

@ -60,6 +60,12 @@ class SetConfig extends Base {
InputOption::VALUE_NEGATABLE,
'Set value as sensitive',
)
->addOption(
'internal',
null,
InputOption::VALUE_NONE,
'Confirm the edit of an internal value',
)
->addOption(
'update-only',
null,
@ -159,6 +165,12 @@ class SetConfig extends Base {
$sensitive = $sensitive ?? false;
}
if (!$input->getOption('internal') && ($this->appConfig->getKeyDetails($appName, $configName)['internal'] ?? false)) {
$output->writeln('<error>Config key is set as INTERNAL and modifying it might induce strange behavior or break user experience.</error>');
$output->writeln('please use option <comment>--internal</comment> to confirm your action');
return self::FAILURE;
}
$value = (string)$input->getOption('value');
switch ($type) {
case IAppConfig::VALUE_MIXED:

3
lib/private/AppConfig.php
View file

@ -1115,7 +1115,7 @@ class AppConfig implements IAppConfig {
* @param string $app id of the app
* @param string $key config key
*
* @return array{app: string, key: string, lazy?: bool, valueType?: ValueType, valueTypeName?: string, sensitive?: bool, default?: string, definition?: string, note?: string}
* @return array{app: string, key: string, lazy?: bool, valueType?: ValueType, valueTypeName?: string, sensitive?: bool, internal?: bool, default?: string, definition?: string, note?: string}
* @since 32.0.0
*/
public function getKeyDetails(string $app, string $key): array {
@ -1143,6 +1143,7 @@ class AppConfig implements IAppConfig {
'valueType' => $lexiconEntry->getValueType(),
'valueTypeName' => $lexiconEntry->getValueType()->name,
'sensitive' => $lexiconEntry->isFlagged(self::FLAG_SENSITIVE),
'internal' => $lexiconEntry->isFlagged(self::FLAG_INTERNAL),
'default' => $lexiconEntry->getDefault($this->presetManager->getLexiconPreset()),
'definition' => $lexiconEntry->getDefinition(),
'note' => $lexiconEntry->getNote(),

4
lib/public/Config/IUserConfig.php
View file

@ -38,6 +38,10 @@ interface IUserConfig {
* @since 32.0.0
*/
public const FLAG_INDEXED = 2; // value should be indexed
/**
* @since 33.0.0
*/
public const FLAG_INTERNAL = 4; // value is considered internal and can be hidden from listing
/**
* Get list of all userIds with config stored in database.

6
lib/public/IAppConfig.php
View file

@ -48,6 +48,10 @@ interface IAppConfig {
/** @since 31.0.0 */
public const FLAG_SENSITIVE = 1; // value is sensitive
/**
* @since 33.0.0
*/
public const FLAG_INTERNAL = 4; // value is considered internal and can be hidden from listing
/**
* Get list of all apps that have at least one config value stored in database
@ -472,7 +476,7 @@ interface IAppConfig {
* @param string $app id of the app
* @param string $key config key
*
* @return array{app: string, key: string, lazy?: bool, valueType?: ValueType, valueTypeName?: string, sensitive?: bool, default?: string, definition?: string, note?: string}
* @return array{app: string, key: string, lazy?: bool, valueType?: ValueType, valueTypeName?: string, sensitive?: bool, internal?: bool, default?: string, definition?: string, note?: string}
* @since 32.0.0
*/
public function getKeyDetails(string $app, string $key): array;