From 130ab63ca1c163b23107389fee5bbe37456490ac Mon Sep 17 00:00:00 2001
From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Wed, 20 Oct 2021 18:25:30 +0200
Subject: [PATCH] Bump doctrine/dbal from 3.0.0 to 3.1.3

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---
 3rdparty                                       |  2 +-
 lib/private/DB/QueryBuilder/QueryBuilder.php   |  4 ++--
 lib/private/Repair/SqliteAutoincrement.php     |  2 +-
 lib/public/DB/QueryBuilder/IQueryBuilder.php   |  4 ++--
 tests/lib/DB/QueryBuilder/QueryBuilderTest.php | 10 +++-------
 5 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/3rdparty b/3rdparty
index b72af468984..217764f87ec 160000
--- a/3rdparty
+++ b/3rdparty
@@ -1 +1 @@
-Subproject commit b72af468984ee6b374ff614f2d87419fc12d0e90
+Subproject commit 217764f87ec6bbd359c76e57f0f48897d7c47646
diff --git a/lib/private/DB/QueryBuilder/QueryBuilder.php b/lib/private/DB/QueryBuilder/QueryBuilder.php
index 3b1c48306a6..e1f74f5327c 100644
--- a/lib/private/DB/QueryBuilder/QueryBuilder.php
+++ b/lib/private/DB/QueryBuilder/QueryBuilder.php
@@ -462,9 +462,9 @@ class QueryBuilder implements IQueryBuilder {
 
 	/**
 	 * Gets the position of the first result the query object was set to retrieve (the "offset").
-	 * Returns NULL if {@link setFirstResult} was not applied to this QueryBuilder.
+	 * Returns 0 if {@link setFirstResult} was not applied to this QueryBuilder.
 	 *
-	 * @return integer The position of the first result.
+	 * @return int The position of the first result.
 	 */
 	public function getFirstResult() {
 		return $this->queryBuilder->getFirstResult();
diff --git a/lib/private/Repair/SqliteAutoincrement.php b/lib/private/Repair/SqliteAutoincrement.php
index 9bd8fa36deb..4a8b2a45d3f 100644
--- a/lib/private/Repair/SqliteAutoincrement.php
+++ b/lib/private/Repair/SqliteAutoincrement.php
@@ -83,7 +83,7 @@ class SqliteAutoincrement implements IRepairStep {
 				foreach ($columnNames as $columnName) {
 					$columnSchema = $tableSchema->getColumn($columnName);
 					$columnDiff = new ColumnDiff($columnSchema->getName(), $columnSchema);
-					$tableDiff->changedColumns[] = $columnDiff;
+					$tableDiff->changedColumns[$columnSchema->getName()] = $columnDiff;
 					$schemaDiff->changedTables[] = $tableDiff;
 				}
 			} catch (SchemaException $e) {
diff --git a/lib/public/DB/QueryBuilder/IQueryBuilder.php b/lib/public/DB/QueryBuilder/IQueryBuilder.php
index e3daf4b3b46..5d1116075d8 100644
--- a/lib/public/DB/QueryBuilder/IQueryBuilder.php
+++ b/lib/public/DB/QueryBuilder/IQueryBuilder.php
@@ -289,9 +289,9 @@ interface IQueryBuilder {
 
 	/**
 	 * Gets the position of the first result the query object was set to retrieve (the "offset").
-	 * Returns NULL if {@link setFirstResult} was not applied to this QueryBuilder.
+	 * Returns 0 if {@link setFirstResult} was not applied to this QueryBuilder.
 	 *
-	 * @return integer The position of the first result.
+	 * @return int The position of the first result.
 	 * @since 8.2.0
 	 */
 	public function getFirstResult();
diff --git a/tests/lib/DB/QueryBuilder/QueryBuilderTest.php b/tests/lib/DB/QueryBuilder/QueryBuilderTest.php
index aef1acc40c1..19278504707 100644
--- a/tests/lib/DB/QueryBuilder/QueryBuilderTest.php
+++ b/tests/lib/DB/QueryBuilder/QueryBuilderTest.php
@@ -102,7 +102,7 @@ class QueryBuilderTest extends \Test\TestCase {
 
 	public function dataFirstResult() {
 		return [
-			[null, [99, 98, 97, 96, 95, 94, 93, 92, 91]],
+			[0, [99, 98, 97, 96, 95, 94, 93, 92, 91]],
 			[0, [99, 98, 97, 96, 95, 94, 93, 92, 91]],
 			[1, [98, 97, 96, 95, 94, 93, 92, 91]],
 			[5, [94, 93, 92, 91]],
@@ -112,7 +112,7 @@ class QueryBuilderTest extends \Test\TestCase {
 	/**
 	 * @dataProvider dataFirstResult
 	 *
-	 * @param int $firstResult
+	 * @param int|null $firstResult
 	 * @param array $expectedSet
 	 */
 	public function testFirstResult($firstResult, $expectedSet) {
@@ -121,14 +121,10 @@ class QueryBuilderTest extends \Test\TestCase {
 
 		if ($firstResult !== null) {
 			$this->queryBuilder->setFirstResult($firstResult);
-
-			// FIXME Remove this once Doctrine/DBAL is >2.5.1:
-			// FIXME See https://github.com/doctrine/dbal/pull/782
-			$this->queryBuilder->setMaxResults(100);
 		}
 
 		$this->assertSame(
-			$firstResult,
+			$firstResult ?? 0,
 			$this->queryBuilder->getFirstResult()
 		);