From 10e636f61cdeed0d3741f271a269dcb25c194e0e Mon Sep 17 00:00:00 2001
From: Robin Appelman <robin@icewind.nl>
Date: Sat, 23 May 2026 17:17:19 +0200
Subject: [PATCH] test: use dummy users in SharesReminderJobTest

saves ~5s

Signed-off-by: Robin Appelman <robin@icewind.nl>
---
 .../tests/SharesReminderJobTest.php             | 17 +++++------------
 1 file changed, 5 insertions(+), 12 deletions(-)

diff --git a/apps/files_sharing/tests/SharesReminderJobTest.php b/apps/files_sharing/tests/SharesReminderJobTest.php
index c26122883d5..6c3113a2aaa 100644
--- a/apps/files_sharing/tests/SharesReminderJobTest.php
+++ b/apps/files_sharing/tests/SharesReminderJobTest.php
@@ -26,6 +26,7 @@ use OCP\Share\IManager;
 use OCP\Share\IShare;
 use PHPUnit\Framework\MockObject\MockObject;
 use Psr\Log\LoggerInterface;
+use Test\Traits\UserTrait;
 
 /**
  * Class SharesReminderJobTest
@@ -35,6 +36,8 @@ use Psr\Log\LoggerInterface;
  */
 #[\PHPUnit\Framework\Attributes\Group(name: 'DB')]
 class SharesReminderJobTest extends \Test\TestCase {
+	use UserTrait;
+
 	private SharesReminderJob $job;
 	private IDBConnection $db;
 	private IManager $shareManager;
@@ -57,8 +60,8 @@ class SharesReminderJobTest extends \Test\TestCase {
 		$this->user1 = $this->getUniqueID('user1_');
 		$this->user2 = $this->getUniqueID('user2_');
 
-		$user1 = $this->userManager->createUser($this->user1, 'longrandompassword');
-		$user2 = $this->userManager->createUser($this->user2, 'longrandompassword');
+		$user1 = $this->createUser($this->user1, 'longrandompassword');
+		$user2 = $this->createUser($this->user2, 'longrandompassword');
 		$user1->setSystemEMailAddress('user1@test.com');
 		$user2->setSystemEMailAddress('user2@test.com');
 
@@ -81,16 +84,6 @@ class SharesReminderJobTest extends \Test\TestCase {
 	protected function tearDown(): void {
 		$this->db->executeUpdate('DELETE FROM `*PREFIX*share`');
 
-		$userManager = Server::get(IUserManager::class);
-		$user1 = $userManager->get($this->user1);
-		if ($user1) {
-			$user1->delete();
-		}
-		$user2 = $userManager->get($this->user2);
-		if ($user2) {
-			$user2->delete();
-		}
-
 		$this->logout();
 
 		parent::tearDown();