upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-08 16:26:59 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

Merge pull request #52937 from nextcloud/fix/s3-versions³

Browse source 
fix(files_versions): only close stream if still open, fixing S3
This commit is contained in:
Ferdinand Thiessen 2025-05-18 19:53:17 +02:00 committed by GitHub
commit 0e20d9e736
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
apps/files_versions/lib/Storage.php
View file

@ -430,11 +430,17 @@ class Storage {
} else {
$target = $storage2->fopen($internalPath2, 'w');
$result = $target !== false;
if ($target !== false) {
if ($result) {
[, $result] = Files::streamCopy($source, $target, true);
}
// explicit check as S3 library closes streams already
if (is_resource($target)) {
fclose($target);
}
}
}
// explicit check as S3 library closes streams already
if (is_resource($source)) {
fclose($source);
}