upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-10 09:13:19 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 54

Merge pull request #52443 from nextcloud/reminder-dont-validiate-node-dav

Browse source 
fix: don't check node access again for listing reminders in dav
This commit is contained in:
Andy Scherzinger 2025-04-28 14:51:25 +02:00 committed by GitHub
commit 0d19a1333f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/files_reminders/lib/Dav/PropFindPlugin.php
View file

@ -62,7 +62,7 @@ class PropFindPlugin extends ServerPlugin {
}
$fileId = $node->getId();
$reminder = $this->reminderService->getDueForUser($user, $fileId);
$reminder = $this->reminderService->getDueForUser($user, $fileId, false);
if ($reminder === null) {
return '';
}

6
apps/files_reminders/lib/Service/ReminderService.php
View file

@ -64,8 +64,10 @@ class ReminderService {
/**
* @throws NodeNotFoundException
*/
public function getDueForUser(IUser $user, int $fileId): ?RichReminder {
$this->checkNode($user, $fileId);
public function getDueForUser(IUser $user, int $fileId, bool $checkNode = true): ?RichReminder {
if ($checkNode) {
$this->checkNode($user, $fileId);
}
/** @var null|false|Reminder $cachedReminder */
$cachedReminder = $this->cache->get("{$user->getUID()}-$fileId");
if ($cachedReminder === false) {