From 1b4952bfb290cbd2cf0ff60b2b10e22151120b9c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Sat, 28 Mar 2020 16:16:41 +0100 Subject: [PATCH 1/4] Update Config.php --- lib/private/Config.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/private/Config.php b/lib/private/Config.php index 5366cd295d4..4b813dfcf21 100644 --- a/lib/private/Config.php +++ b/lib/private/Config.php @@ -246,12 +246,9 @@ class Config { // File does not exist, this can happen when doing a fresh install if(!is_resource ($filePointer)) { - // TODO fix this via DI once it is very clear that this doesn't cause side effects due to initialization order - // currently this breaks app routes but also could have other side effects especially during setup and exception handling - $url = \OC::$server->getURLGenerator()->linkToDocs('admin-dir_permissions'); throw new HintException( "Can't write into config directory!", - 'This can usually be fixed by giving the webserver write access to the config directory. See ' . $url); + 'This can usually be fixed by giving the webserver write access to the config directory.'); } // Try to acquire a file lock From 58a192f05de36ad05d8adc4c051c143045178314 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Sat, 28 Mar 2020 16:17:21 +0100 Subject: [PATCH 2/4] Update util.php --- lib/private/legacy/util.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/private/legacy/util.php b/lib/private/legacy/util.php index 044c3fee7bc..9fce2993a2a 100644 --- a/lib/private/legacy/util.php +++ b/lib/private/legacy/util.php @@ -773,8 +773,7 @@ class OC_Util { $errors[] = [ 'error' => $l->t('Cannot write into "apps" directory'), 'hint' => $l->t('This can usually be fixed by giving the webserver write access to the apps directory' - . ' or disabling the appstore in the config file. See %s', - [$urlGenerator->linkToDocs('admin-dir_permissions')]) + . ' or disabling the appstore in the config file.') ]; } } From 7eac19682c67a2690ea799e0f9e8a0647e92dc5a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Sat, 28 Mar 2020 16:17:50 +0100 Subject: [PATCH 3/4] Update base.php --- lib/base.php | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/base.php b/lib/base.php index d3b0c42f1bb..943eb7cffcf 100644 --- a/lib/base.php +++ b/lib/base.php @@ -254,7 +254,6 @@ class OC { if (self::$CLI) { echo $l->t('Cannot write into "config" directory!')."\n"; echo $l->t('This can usually be fixed by giving the webserver write access to the config directory')."\n"; - echo $l->t('See %s', [ $urlGenerator->linkToDocs('admin-dir_permissions') ])."\n"; echo "\n"; echo $l->t('Or, if you prefer to keep config.php file read only, set the option "config_is_read_only" to true in it.')."\n"; echo $l->t('See %s', [ $urlGenerator->linkToDocs('admin-config') ])."\n"; From 82b0cd2e7a8a22ad5d447f92b89ba777fd80ebdf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?John=20Molakvo=C3=A6?= Date: Sat, 28 Mar 2020 16:19:01 +0100 Subject: [PATCH 4/4] Update base.php --- lib/base.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/base.php b/lib/base.php index 943eb7cffcf..6dc08510a7b 100644 --- a/lib/base.php +++ b/lib/base.php @@ -261,8 +261,7 @@ class OC { } else { OC_Template::printErrorPage( $l->t('Cannot write into "config" directory!'), - $l->t('This can usually be fixed by giving the webserver write access to the config directory. See %s', - [ $urlGenerator->linkToDocs('admin-dir_permissions') ]) . '. ' + $l->t('This can usually be fixed by giving the webserver write access to the config directory.') . '. ' . $l->t('Or, if you prefer to keep config.php file read only, set the option "config_is_read_only" to true in it. See %s', [ $urlGenerator->linkToDocs('admin-config') ] ), 503