mirror of
https://github.com/nextcloud/server.git
synced 2026-04-20 22:00:39 -04:00
fix: drop set up partial mounts on setupForUser
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
This commit is contained in:
Salvatore Martire
Louis
parent
f42493bf1e
commit
07eef5eaf4
2 changed files with 175 additions and 0 deletions
|
|
@ -236,6 +236,8 @@ class SetupManager {
|
|||
|
||||
$this->eventLogger->start('fs:setup:user:full', 'Setup full filesystem for user');
|
||||
|
||||
$this->dropPartialMountsForUser($user);
|
||||
|
||||
$this->setupUserMountProviders[$user->getUID()] ??= [];
|
||||
$previouslySetupProviders = $this->setupUserMountProviders[$user->getUID()];
|
||||
|
||||
|
|
@ -658,6 +660,7 @@ class SetupManager {
|
|||
$this->eventLogger->end('fs:setup:user:providers');
|
||||
return;
|
||||
} else {
|
||||
$this->dropPartialMountsForUser($user, $providers);
|
||||
$this->setupUserMountProviders[$user->getUID()] = array_merge($setupProviders, $providers);
|
||||
$mounts = $this->mountProviderCollection->getUserMountsForProviderClasses($user, $providers);
|
||||
}
|
||||
|
|
@ -741,4 +744,39 @@ class SetupManager {
|
|||
$this->userMountCache->registerMounts($user, $mounts, $mountProviderClasses);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Drops partially set-up mounts for the given user
|
||||
* @param class-string<IMountProvider>[] $providers
|
||||
*/
|
||||
public function dropPartialMountsForUser(IUser $user, array $providers = []): void {
|
||||
// mounts are cached by mount-point
|
||||
$mounts = $this->mountManager->getAll();
|
||||
$partialMounts = array_filter($this->setupMountProviderPaths,
|
||||
static function (string $mountPoint) use (
|
||||
$providers,
|
||||
$user,
|
||||
$mounts
|
||||
) {
|
||||
$isUserMount = str_starts_with($mountPoint, '/' . $user->getUID() . '/files');
|
||||
|
||||
if (!$isUserMount) {
|
||||
return false;
|
||||
}
|
||||
|
||||
$mountProvider = ($mounts[$mountPoint] ?? null)?->getMountProvider();
|
||||
|
||||
return empty($providers)
|
||||
|| \in_array($mountProvider, $providers, true);
|
||||
},
|
||||
ARRAY_FILTER_USE_KEY);
|
||||
|
||||
if (!empty($partialMounts)) {
|
||||
// remove partially set up mounts
|
||||
foreach ($partialMounts as $mountPoint => $_mount) {
|
||||
$this->mountManager->removeMount($mountPoint);
|
||||
unset($this->setupMountProviderPaths[$mountPoint]);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
|
|||
|
|
@ -495,6 +495,143 @@ class SetupManagerTest extends TestCase {
|
|||
$this->setupManager->setupForPath($this->path, true);
|
||||
}
|
||||
|
||||
public function testSetupForUserResetsUserPaths(): void {
|
||||
$cachedMount = $this->getCachedMountInfo($this->mountPoint, 42);
|
||||
|
||||
$this->userMountCache->expects($this->once())
|
||||
->method('getMountForPath')
|
||||
->with($this->user, $this->path)
|
||||
->willReturn($cachedMount);
|
||||
$this->userMountCache->expects($this->never())
|
||||
->method('getMountsInPath');
|
||||
|
||||
$this->fileAccess->expects($this->once())
|
||||
->method('getByFileId')
|
||||
->with(42)
|
||||
->willReturn($this->createMock(CacheEntry::class));
|
||||
|
||||
$partialMount = $this->createMock(IMountPoint::class);
|
||||
|
||||
$this->mountProviderCollection->expects($this->once())
|
||||
->method('getUserMountsFromProviderByPath')
|
||||
->with(
|
||||
SetupManagerTestPartialMountProvider::class,
|
||||
$this->path,
|
||||
false,
|
||||
$this->callback(function (array $args) use ($cachedMount) {
|
||||
$this->assertCount(1, $args);
|
||||
$this->assertInstanceOf(IMountProviderArgs::class,
|
||||
$args[0]);
|
||||
$this->assertSame($cachedMount, $args[0]->mountInfo);
|
||||
return true;
|
||||
})
|
||||
)
|
||||
->willReturn([$partialMount]);
|
||||
|
||||
$homeMount = $this->createMock(IMountPoint::class);
|
||||
|
||||
$this->mountProviderCollection->expects($this->once())
|
||||
->method('getHomeMountForUser')
|
||||
->willReturn($homeMount);
|
||||
$this->mountProviderCollection->expects($this->never())
|
||||
->method('getUserMountsForProviderClasses');
|
||||
|
||||
$invokedCount = $this->exactly(2);
|
||||
$addMountExpectations = [
|
||||
1 => $homeMount,
|
||||
2 => $partialMount,
|
||||
];
|
||||
$this->mountManager->expects($invokedCount)
|
||||
->method('addMount')
|
||||
->willReturnCallback($this->getAddMountCheckCallback($invokedCount,
|
||||
$addMountExpectations));
|
||||
|
||||
|
||||
// setting up for $path but then for user should remove the setup path
|
||||
$this->setupManager->setupForPath($this->path, false);
|
||||
|
||||
// note that only the mount known by SetupManrger is removed not the
|
||||
// home mount, because MountManager is mocked
|
||||
$this->mountManager->expects($this->once())
|
||||
->method('removeMount')
|
||||
->with($this->mountPoint);
|
||||
|
||||
$this->setupManager->setupForUser($this->user);
|
||||
}
|
||||
|
||||
/**
|
||||
* Tests that after a path is setup by a
|
||||
*/
|
||||
public function testSetupForProviderResetsUserProviderPaths(): void {
|
||||
$cachedMount = $this->getCachedMountInfo($this->mountPoint, 42);
|
||||
|
||||
$this->userMountCache->expects($this->once())
|
||||
->method('getMountForPath')
|
||||
->with($this->user, $this->path)
|
||||
->willReturn($cachedMount);
|
||||
$this->userMountCache->expects($this->never())
|
||||
->method('getMountsInPath');
|
||||
|
||||
$this->fileAccess->expects($this->once())
|
||||
->method('getByFileId')
|
||||
->with(42)
|
||||
->willReturn($this->createMock(CacheEntry::class));
|
||||
|
||||
$partialMount = $this->createMock(IMountPoint::class);
|
||||
$partialMount->expects($this->once())->method('getMountProvider')
|
||||
->willReturn(SetupManagerTestFullMountProvider::class);
|
||||
|
||||
$this->mountProviderCollection->expects($this->once())
|
||||
->method('getUserMountsFromProviderByPath')
|
||||
->with(
|
||||
SetupManagerTestPartialMountProvider::class,
|
||||
$this->path,
|
||||
false,
|
||||
$this->callback(function (array $args) use ($cachedMount) {
|
||||
$this->assertCount(1, $args);
|
||||
$this->assertInstanceOf(IMountProviderArgs::class,
|
||||
$args[0]);
|
||||
$this->assertSame($cachedMount, $args[0]->mountInfo);
|
||||
return true;
|
||||
})
|
||||
)
|
||||
->willReturn([$partialMount]);
|
||||
|
||||
$homeMount = $this->createMock(IMountPoint::class);
|
||||
|
||||
$this->mountProviderCollection->expects($this->once())
|
||||
->method('getHomeMountForUser')
|
||||
->willReturn($homeMount);
|
||||
|
||||
$invokedCount = $this->exactly(2);
|
||||
$addMountExpectations = [
|
||||
1 => $homeMount,
|
||||
2 => $partialMount,
|
||||
];
|
||||
$this->mountManager->expects($invokedCount)
|
||||
->method('addMount')
|
||||
->willReturnCallback($this->getAddMountCheckCallback($invokedCount,
|
||||
$addMountExpectations));
|
||||
$this->mountManager->expects($this->once())->method('getAll')
|
||||
->willReturn([$this->mountPoint => $partialMount]);
|
||||
|
||||
// setting up for $path but then for user should remove the setup path
|
||||
$this->setupManager->setupForPath($this->path, false);
|
||||
|
||||
// note that only the mount known by SetupManrger is removed not the
|
||||
// home mount, because MountManager is mocked
|
||||
$this->mountManager->expects($this->once())
|
||||
->method('removeMount')
|
||||
->with($this->mountPoint);
|
||||
|
||||
$this->mountProviderCollection->expects($this->once())
|
||||
->method('getUserMountsForProviderClasses')
|
||||
->with($this->user, [SetupManagerTestFullMountProvider::class]);
|
||||
|
||||
$this->setupManager->setupForProvider($this->path,
|
||||
[SetupManagerTestFullMountProvider::class]);
|
||||
}
|
||||
|
||||
private function getAddMountCheckCallback(InvokedCount $invokedCount, $expectations): \Closure {
|
||||
return function (IMountPoint $actualMount) use ($invokedCount, $expectations) {
|
||||
$expectedMount = $expectations[$invokedCount->numberOfInvocations()] ?? null;
|
||||
|
|
|
|||
Loading…
Reference in a new issue