From 753c6fd07bebcd7ca709aafb6b9358603318e441 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Fri, 29 Sep 2017 18:14:39 +0200
Subject: [PATCH 1/7] Add alt text to app icons in header

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
---
 core/templates/layout.user.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
index 6b9db9389ba..98cd8d6c281 100644
--- a/core/templates/layout.user.php
+++ b/core/templates/layout.user.php
@@ -55,7 +55,7 @@
 							   tabindex="3"
 								<?php if ($entry['active']): ?> class="active"<?php endif; ?>>
 								<img src="<?php print_unescaped($entry['icon'] . '?v=' . $_['versionHash']); ?>"
-									 class="app-icon"/>
+									 class="app-icon" alt="<?php p($entry['name']); ?>" />
 								<div class="icon-loading-small-dark"
 									 style="display:none;"></div>
 							</a>

From 9fb37a2990b250d4416bb8cb7d00c477869a0fa5 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Fri, 29 Sep 2017 19:25:32 +0200
Subject: [PATCH 2/7] Add proper labels to various form elements and buttons

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
---
 apps/files/js/detailsview.js   |  2 +-
 apps/files/templates/list.php  |  4 +++-
 core/templates/layout.user.php | 10 ++++++----
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/apps/files/js/detailsview.js b/apps/files/js/detailsview.js
index e53922ebb69..a896e84fdc0 100644
--- a/apps/files/js/detailsview.js
+++ b/apps/files/js/detailsview.js
@@ -23,7 +23,7 @@
 		'	{{/if}}' +
 		'	<div class="tabsContainer">' +
 		'	</div>' +
-		'	<a class="close icon-close" href="#" alt="{{closeLabel}}"></a>';
+		'	<a class="close icon-close" href="#"><span class="hidden-visually">{{closeLabel}}</span></a>';
 
 	/**
 	 * @class OCA.Files.DetailsView
diff --git a/apps/files/templates/list.php b/apps/files/templates/list.php
index f3b6759644c..46bd9351e39 100644
--- a/apps/files/templates/list.php
+++ b/apps/files/templates/list.php
@@ -4,7 +4,9 @@
 				<div id="uploadprogressbar">
 					<em class="label outer" style="display:none"><span class="desktop"><?php p($l->t('Uploading @'));?></span><span class="mobile"><?php p($l->t('…'));?></span></em>
 				</div>
-				<input type="button" class="stop icon-close" style="display:none" value="" />
+				<button class="stop icon-close" style="display:none">
+					<span class="hidden-visually"><?php p($l->t('Cancel upload')) ?></span>
+				</button>
 			</div>
 		</div>
 		<div id="file_action_panel"></div>
diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
index 98cd8d6c281..16454b4f45e 100644
--- a/core/templates/layout.user.php
+++ b/core/templates/layout.user.php
@@ -104,7 +104,7 @@
 					<input id="searchbox" type="search" name="query"
 						value="" required
 						autocomplete="off" tabindex="5">
-					<button class="icon-close-white" type="reset"></button>
+					<button class="icon-close-white" type="reset"><span class="hidden-visually"><?php p($l->t('Reset search'));?></span></button>
 				</form>
 				<div id="contactsmenu">
 					<div class="icon-contacts menutoggle"></div>
@@ -142,10 +142,12 @@
 
 		<div id="sudo-login-background" class="hidden"></div>
 		<form id="sudo-login-form" class="hidden">
-			<?php p($l->t('This action requires you to confirm your password:')); ?><br>
-			<input type="password" class="question" autocomplete="new-password" name="question" value=" <?php /* Hack against browsers ignoring autocomplete="off" */ ?>"
+			<label>
+				<?php p($l->t('This action requires you to confirm your password')); ?><br/>
+				<input type="password" class="question" autocomplete="new-password" name="question" value=" <?php /* Hack against browsers ignoring autocomplete="off" */ ?>"
 				placeholder="<?php p($l->t('Confirm your password')); ?>" />
-			<input class="confirm icon-confirm" title="<?php p($l->t('Confirm')); ?>" value="" type="submit">
+			</label>
+			<input class="confirm" value="<?php p($l->t('Confirm')); ?>" type="submit">
 		</form>
 
 		<div id="content-wrapper">

From d3ae77590ac6c2f3f0738c40f8a8e00b1c261998 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Fri, 29 Sep 2017 19:30:59 +0200
Subject: [PATCH 3/7] Merge legacy app title h1 into Nextcloud h1, ref #5822

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
---
 core/templates/layout.user.php | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
index 16454b4f45e..68c167d7326 100644
--- a/core/templates/layout.user.php
+++ b/core/templates/layout.user.php
@@ -36,18 +36,11 @@
 					id="nextcloud" tabindex="1">
 					<div class="logo logo-icon">
 						<h1 class="hidden-visually">
-							<?php p($theme->getName()); ?>
+							<?php p($theme->getName()); ?> <?php p(!empty($_['application'])?$_['application']: $l->t('Apps')); ?>
 						</h1>
 					</div>
 				</a>
 
-				<a href="#" class="header-appname-container menutoggle" tabindex="2">
-					<h1 class="header-appname">
-						<?php p(!empty($_['application'])?$_['application']: $l->t('Apps')); ?>
-					</h1>
-					<div class="icon-caret"></div>
-				</a>
-
 				<ul id="appmenu">
 					<?php foreach ($_['navigation'] as $entry): ?>
 						<li data-id="<?php p($entry['id']); ?>" class="hidden">

From 21e484533c371d46d37e6e05fedaec70b13a40c3 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Fri, 29 Sep 2017 19:34:23 +0200
Subject: [PATCH 4/7] Remove redundant alternative text

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
---
 apps/files/templates/simplelist.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/apps/files/templates/simplelist.php b/apps/files/templates/simplelist.php
index c787f9eb8df..fdf882fa3fe 100644
--- a/apps/files/templates/simplelist.php
+++ b/apps/files/templates/simplelist.php
@@ -29,7 +29,7 @@
 				<a id="modified" class="columntitle" data-sort="mtime"><span><?php p($l->t( 'Modified' )); ?></span><span class="sort-indicator"></span></a>
 					<span class="selectedActions"><a href="" class="delete-selected">
 						<?php p($l->t('Delete'))?>
-						<img class="svg" alt="<?php p($l->t('Delete'))?>"
+						<img class="svg" alt=""
 							 src="<?php print_unescaped(OCP\image_path("core", "actions/delete.svg")); ?>" />
 					</a></span>
 			</th>

From 2cd467f3f0b018c2dd6d17b5266c8ebff1330c5d Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Fri, 29 Sep 2017 20:01:15 +0200
Subject: [PATCH 5/7] Remove unneeded tabindex, add keyboard focus feedback for
 app list

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
---
 core/css/header.scss           |  1 +
 core/templates/layout.user.php | 11 +++++------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/core/css/header.scss b/core/css/header.scss
index e9edfe0bfb8..656440520a0 100644
--- a/core/css/header.scss
+++ b/core/css/header.scss
@@ -459,6 +459,7 @@ nav {
 
 
 	li:hover a,
+	li a:focus,
 	li a.active {
 		opacity: 1;
 	}
diff --git a/core/templates/layout.user.php b/core/templates/layout.user.php
index 68c167d7326..5008392d2a3 100644
--- a/core/templates/layout.user.php
+++ b/core/templates/layout.user.php
@@ -33,7 +33,7 @@
 	<header role="banner"><div id="header">
 			<div class="header-left">
 				<a href="<?php print_unescaped(link_to('', 'index.php')); ?>"
-					id="nextcloud" tabindex="1">
+					id="nextcloud">
 					<div class="logo logo-icon">
 						<h1 class="hidden-visually">
 							<?php p($theme->getName()); ?> <?php p(!empty($_['application'])?$_['application']: $l->t('Apps')); ?>
@@ -45,7 +45,6 @@
 					<?php foreach ($_['navigation'] as $entry): ?>
 						<li data-id="<?php p($entry['id']); ?>" class="hidden">
 							<a href="<?php print_unescaped($entry['href']); ?>"
-							   tabindex="3"
 								<?php if ($entry['active']): ?> class="active"<?php endif; ?>>
 								<img src="<?php print_unescaped($entry['icon'] . '?v=' . $_['versionHash']); ?>"
 									 class="app-icon" alt="<?php p($entry['name']); ?>" />
@@ -71,7 +70,7 @@
 							<ul>
 								<?php foreach($_['navigation'] as $entry): ?>
 									<li data-id="<?php p($entry['id']); ?>">
-									<a href="<?php print_unescaped($entry['href']); ?>" tabindex="3"
+									<a href="<?php print_unescaped($entry['href']); ?>"
 										<?php if( $entry['active'] ): ?> class="active"<?php endif; ?>>
 										<svg width="16" height="16" viewBox="0 0 16 16">
 											<defs><filter id="invert-<?php p($entry['id']); ?>"><feColorMatrix in="SourceGraphic" type="matrix" values="-1 0 0 0 1 0 -1 0 0 1 0 0 -1 0 1 0 0 0 1 0"></feColorMatrix></filter></defs>
@@ -96,15 +95,15 @@
 					</label>
 					<input id="searchbox" type="search" name="query"
 						value="" required
-						autocomplete="off" tabindex="5">
+						autocomplete="off">
 					<button class="icon-close-white" type="reset"><span class="hidden-visually"><?php p($l->t('Reset search'));?></span></button>
 				</form>
 				<div id="contactsmenu">
-					<div class="icon-contacts menutoggle"></div>
+					<div class="icon-contacts menutoggle" tabindex="0" role="link"></div>
 					<div class="menu"></div>
 				</div>
 				<div id="settings">
-					<div id="expand" tabindex="6" role="link" class="menutoggle">
+					<div id="expand" tabindex="0" role="link" class="menutoggle">
 						<div class="avatardiv<?php if ($_['userAvatarSet']) { print_unescaped(' avatardiv-shown'); } else { print_unescaped('" style="display: none'); } ?>">
 							<?php if ($_['userAvatarSet']): ?>
 								<img alt="" width="32" height="32"

From 61f10b27bcbb9f01209946f33be53b5b3f42fdb9 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Fri, 29 Sep 2017 20:27:49 +0200
Subject: [PATCH 6/7] Improve accessibility of Contacts menu

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
---
 core/js/contactsmenu.js | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/core/js/contactsmenu.js b/core/js/contactsmenu.js
index 6d57ae72e65..41de10abb47 100644
--- a/core/js/contactsmenu.js
+++ b/core/js/contactsmenu.js
@@ -26,6 +26,7 @@
 	'use strict';
 
 	var MENU_TEMPLATE = ''
+			+ '<label class="hidden-visually" for="contactsmenu-search">' + t('core', 'Search contacts …') + '</label>'
 			+ '<input id="contactsmenu-search" type="search" placeholder="' + t('core', 'Search contacts …') + '" value="{{searchTerm}}">'
 			+ '<div class="content">'
 			+ '</div>';
@@ -51,7 +52,7 @@
 	var CONTACT_TEMPLATE = ''
 			+ '{{#if contact.avatar}}'
 			+ '<img src="{{contact.avatar}}&size=32" class="avatar"'
-			+ 'srcset="{{contact.avatar}}&size=32 1x, {{contact.avatar}}&size=64 2x, {{contact.avatar}}&size=128 4x">'
+			+ 'srcset="{{contact.avatar}}&size=32 1x, {{contact.avatar}}&size=64 2x, {{contact.avatar}}&size=128 4x" alt="">'
 			+ '{{else}}'
 			+ '<div class="avatar"></div>'
 			+ '{{/if}}'
@@ -61,12 +62,12 @@
 			+ '</div>'
 			+ '{{#if contact.topAction}}'
 			+ '<a class="top-action" href="{{contact.topAction.hyperlink}}" title="{{contact.topAction.title}}">'
-			+ '    <img src="{{contact.topAction.icon}}">'
+			+ '    <img src="{{contact.topAction.icon}}" alt="{{contact.topAction.title}}">'
 			+ '</a>'
 			+ '{{/if}}'
 			+ '{{#if contact.hasTwoActions}}'
 			+ '<a class="second-action" href="{{contact.secondAction.hyperlink}}" title="{{contact.secondAction.title}}">'
-			+ '    <img src="{{contact.secondAction.icon}}">'
+			+ '    <img src="{{contact.secondAction.icon}}" alt="{{contact.secondAction.title}}">'
 			+ '</a>'
 			+ '{{/if}}'
 			+ '{{#if contact.hasManyActions}}'
@@ -76,7 +77,7 @@
 			+ '            {{#each contact.actions}}'
 			+ '            <li>'
 			+ '                <a href="{{hyperlink}}">'
-			+ '                    <img src="{{icon}}">'
+			+ '                    <img src="{{icon}}" alt="">'
 			+ '                    <span>{{title}}</span>'
 			+ '                </a>'
 			+ '            </li>'
@@ -224,7 +225,7 @@
 			}));
 			this.delegateEvents();
 
-			// Show placeholder iff no avatar is available (avatar is rendered as img, not div)
+			// Show placeholder if no avatar is available (avatar is rendered as img, not div)
 			this.$('div.avatar').imageplaceholder(this._model.get('fullName'));
 
 			// Show tooltip for top action

From f7e6da9a8eac68cb0aa0fc9a593d3fb05e41fb89 Mon Sep 17 00:00:00 2001
From: Jan-Christoph Borchardt <hey@jancborchardt.net>
Date: Fri, 29 Sep 2017 20:28:27 +0200
Subject: [PATCH 7/7] Add empty alt text to avatars as they are decorative next
 to usernames

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
---
 core/js/jquery.avatar.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/core/js/jquery.avatar.js b/core/js/jquery.avatar.js
index a320496e250..54518c75cc7 100644
--- a/core/js/jquery.avatar.js
+++ b/core/js/jquery.avatar.js
@@ -126,9 +126,9 @@
 				} else {
 					$div.show();
 					if (ie8fix === true) {
-						$div.html('<img width="' + size + '" height="' + size + '" src="'+url+'#'+Math.floor(Math.random()*1000)+'">');
+						$div.html('<img width="' + size + '" height="' + size + '" src="'+url+'#'+Math.floor(Math.random()*1000)+'" alt="">');
 					} else {
-						$div.html('<img width="' + size + '" height="' + size + '" src="'+url+'">');
+						$div.html('<img width="' + size + '" height="' + size + '" src="'+url+'" alt="">');
 					}
 				}
 				if(typeof callback === 'function') {