upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-28 04:32:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 25

fix(TaskProcessing): Make setup checks more sensitive

Browse source 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
This commit is contained in:
Marcel Klehr 2026-04-28 11:44:51 +02:00
parent 4a68320ad1
commit 0325e20a6b
4 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
apps/settings/lib/SetupChecks/TaskProcessingPickupSpeed.php
View file

@ -16,7 +16,7 @@ use OCP\SetupCheck\SetupResult;
use OCP\TaskProcessing\IManager;
class TaskProcessingPickupSpeed implements ISetupCheck {
public const MAX_SLOW_PERCENTAGE = 0.2;
public const MAX_SLOW_PERCENTAGE = 0.1;
public const MAX_DAYS = 14;

4
apps/settings/lib/SetupChecks/TaskProcessingSuccessRate.php
View file

@ -17,7 +17,7 @@ use OCP\TaskProcessing\IManager;
use OCP\TaskProcessing\Task;
class TaskProcessingSuccessRate implements ISetupCheck {
public const MAX_FAILURE_PERCENTAGE = 0.2;
public const MAX_FAILURE_PERCENTAGE = 0.1;
public const MAX_DAYS = 14;
@ -33,7 +33,7 @@ class TaskProcessingSuccessRate implements ISetupCheck {
}
public function getName(): string {
return $this->l10n->t('Task Processing pickup speed');
return $this->l10n->t('Task Processing success rate');
}
public function run(): SetupResult {

4
apps/settings/tests/SetupChecks/TaskProcessingPickupSpeedTest.php
View file

@ -42,8 +42,8 @@ class TaskProcessingPickupSpeedTest extends TestCase {
for ($i = 0; $i < 100; $i++) {
$task = new Task('test', ['test' => 'test'], 'settings', 'user' . $i);
$task->setStartedAt(0);
if ($i < 15) {
$task->setScheduledAt(60 * 5); // 15% get 5mins
if ($i < 5) {
$task->setScheduledAt(60 * 5); // 5% get 5mins
} else {
$task->setScheduledAt(60); // the rest gets 1min
}

4
apps/settings/tests/SetupChecks/TaskProcessingSuccessRateTest.php
View file

@ -43,8 +43,8 @@ class TaskProcessingSuccessRateTest extends TestCase {
$task = new Task('test', ['test' => 'test'], 'settings', 'user' . $i);
$task->setStartedAt(0);
$task->setEndedAt(1);
if ($i < 15) {
$task->setStatus(Task::STATUS_FAILED); // 15% get status FAILED
if ($i < 5) {
$task->setStatus(Task::STATUS_FAILED); // 5% get status FAILED
} else {
$task->setStatus(Task::STATUS_SUCCESSFUL);
}