From 00e0535aecf69a1e3ef93afe3d162fd45fb00ca5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Sat, 8 Jul 2017 15:46:16 +0200 Subject: [PATCH] Add acceptance tests for unselecting items in dropdown for tags MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Daniel Calviño Sánchez --- tests/acceptance/config/behat.yml | 1 + tests/acceptance/features/app-files.feature | 72 +++++++++ .../features/bootstrap/FilesAppContext.php | 93 +++++++++++ .../features/bootstrap/SettingsContext.php | 152 ++++++++++++++++++ .../bootstrap/SettingsMenuContext.php | 16 ++ 5 files changed, 334 insertions(+) create mode 100644 tests/acceptance/features/bootstrap/SettingsContext.php diff --git a/tests/acceptance/config/behat.yml b/tests/acceptance/config/behat.yml index 86510083761..f9412935e51 100644 --- a/tests/acceptance/config/behat.yml +++ b/tests/acceptance/config/behat.yml @@ -15,6 +15,7 @@ default: - FilesSharingAppContext - LoginPageContext - NotificationContext + - SettingsContext - SettingsMenuContext - UsersSettingsContext extensions: diff --git a/tests/acceptance/features/app-files.feature b/tests/acceptance/features/app-files.feature index 8d32508513a..5a0a0095512 100644 --- a/tests/acceptance/features/app-files.feature +++ b/tests/acceptance/features/app-files.feature @@ -68,3 +68,75 @@ Feature: app-files And I see that the "Sharing" tab in the details view is eventually loaded When I open the input field for tags in the details view Then I see that the input field for tags in the details view is shown + + Scenario: create tags using the Administration settings + Given I am logged in as the admin + And I open the Admin settings + And I open the "Workflow" section + # The "create" button does nothing before JavaScript was initialized, and + # the only way to detect that is waiting for the button to select tags to be + # shown. + And I see that the button to select tags is shown + When I create the tag "tag1" in the settings + Then I see that the dropdown for tags in the settings eventually contains the tag "tag1" + + Scenario: add tags using the dropdown in the details view + Given I am logged in as the admin + And I open the Admin settings + And I open the "Workflow" section + # The "create" button does nothing before JavaScript was initialized, and + # the only way to detect that is waiting for the button to select tags to be + # shown. + And I see that the button to select tags is shown + And I create the tag "tag1" in the settings + And I create the tag "tag2" in the settings + And I create the tag "tag3" in the settings + And I create the tag "tag4" in the settings + And I see that the dropdown for tags in the settings eventually contains the tag "tag1" + And I see that the dropdown for tags in the settings eventually contains the tag "tag2" + And I see that the dropdown for tags in the settings eventually contains the tag "tag3" + And I see that the dropdown for tags in the settings eventually contains the tag "tag4" + And I log out + And I am logged in + And I open the details view for "welcome.txt" + And I open the input field for tags in the details view + # When the input field is opened the dropdown is also opened automatically. + When I check the tag "tag2" in the dropdown for tags in the details view + And I check the tag "tag4" in the dropdown for tags in the details view + Then I see that the tag "tag2" in the dropdown for tags in the details view is checked + And I see that the tag "tag4" in the dropdown for tags in the details view is checked + And I see that the input field for tags in the details view contains the tag "tag2" + And I see that the input field for tags in the details view contains the tag "tag4" + + Scenario: remove tags using the dropdown in the details view + Given I am logged in as the admin + And I open the Admin settings + And I open the "Workflow" section + # The "create" button does nothing before JavaScript was initialized, and + # the only way to detect that is waiting for the button to select tags to be + # shown. + And I see that the button to select tags is shown + And I create the tag "tag1" in the settings + And I create the tag "tag2" in the settings + And I create the tag "tag3" in the settings + And I create the tag "tag4" in the settings + And I see that the dropdown for tags in the settings eventually contains the tag "tag1" + And I see that the dropdown for tags in the settings eventually contains the tag "tag2" + And I see that the dropdown for tags in the settings eventually contains the tag "tag3" + And I see that the dropdown for tags in the settings eventually contains the tag "tag4" + And I log out + And I am logged in + And I open the details view for "welcome.txt" + And I open the input field for tags in the details view + # When the input field is opened the dropdown is also opened automatically. + And I check the tag "tag2" in the dropdown for tags in the details view + And I check the tag "tag4" in the dropdown for tags in the details view + And I check the tag "tag3" in the dropdown for tags in the details view + When I uncheck the tag "tag2" in the dropdown for tags in the details view + And I uncheck the tag "tag4" in the dropdown for tags in the details view + Then I see that the tag "tag2" in the dropdown for tags in the details view is not checked + And I see that the tag "tag4" in the dropdown for tags in the details view is not checked + And I see that the tag "tag3" in the dropdown for tags in the details view is checked + And I see that the input field for tags in the details view does not contain the tag "tag2" + And I see that the input field for tags in the details view does not contain the tag "tag4" + And I see that the input field for tags in the details view contains the tag "tag3" diff --git a/tests/acceptance/features/bootstrap/FilesAppContext.php b/tests/acceptance/features/bootstrap/FilesAppContext.php index b9ccb7316ab..61f6b115ac6 100644 --- a/tests/acceptance/features/bootstrap/FilesAppContext.php +++ b/tests/acceptance/features/bootstrap/FilesAppContext.php @@ -104,6 +104,41 @@ class FilesAppContext implements Context, ActorAwareInterface { describedAs("Input field for tags in current section details view in Files app"); } + /** + * @return Locator + */ + public static function itemInInputFieldForTagsInCurrentSectionDetailsViewForTag($tag) { + return Locator::forThe()->xpath("//span[normalize-space() = '$tag']")-> + descendantOf(self::inputFieldForTagsInCurrentSectionDetailsView())-> + describedAs("Item in input field for tags in current section details view for tag $tag in Files app"); + } + + /** + * @return Locator + */ + public static function itemInDropdownForTag($tag) { + return Locator::forThe()->xpath("//*[contains(concat(' ', normalize-space(@class), ' '), ' select2-result-label ')]//span[normalize-space() = '$tag']/ancestor::li")-> + descendantOf(self::select2Dropdown())-> + describedAs("Item in dropdown for tag $tag in Files app"); + } + + /** + * @return Locator + */ + public static function checkmarkInItemInDropdownForTag($tag) { + return Locator::forThe()->css(".checkmark")-> + descendantOf(self::itemInDropdownForTag($tag))-> + describedAs("Checkmark in item in dropdown for tag $tag in Files app"); + } + + /** + * @return Locator + */ + private static function select2Dropdown() { + return Locator::forThe()->css("#select2-drop")-> + describedAs("Select2 dropdown in Files app"); + } + /** * @return Locator */ @@ -323,6 +358,24 @@ class FilesAppContext implements Context, ActorAwareInterface { $this->actor->find(self::viewFileInFolderMenuItem(), 2)->click(); } + /** + * @When I check the tag :tag in the dropdown for tags in the details view + */ + public function iCheckTheTagInTheDropdownForTagsInTheDetailsView($tag) { + $this->iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsNotChecked($tag); + + $this->actor->find(self::itemInDropdownForTag($tag), 10)->click(); + } + + /** + * @When I uncheck the tag :tag in the dropdown for tags in the details view + */ + public function iUncheckTheTagInTheDropdownForTagsInTheDetailsView($tag) { + $this->iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked($tag); + + $this->actor->find(self::itemInDropdownForTag($tag), 10)->click(); + } + /** * @When I protect the shared link with the password :password */ @@ -389,6 +442,46 @@ class FilesAppContext implements Context, ActorAwareInterface { $this->actor->find(self::inputFieldForTagsInCurrentSectionDetailsView(), 10)->isVisible()); } + /** + * @Then I see that the input field for tags in the details view contains the tag :tag + */ + public function iSeeThatTheInputFieldForTagsInTheDetailsViewContainsTheTag($tag) { + PHPUnit_Framework_Assert::assertTrue( + $this->actor->find(self::itemInInputFieldForTagsInCurrentSectionDetailsViewForTag($tag), 10)->isVisible()); + } + + /** + * @Then I see that the input field for tags in the details view does not contain the tag :tag + */ + public function iSeeThatTheInputFieldForTagsInTheDetailsViewDoesNotContainTheTag($tag) { + $this->iSeeThatTheInputFieldForTagsInTheDetailsViewIsShown(); + + try { + PHPUnit_Framework_Assert::assertFalse( + $this->actor->find(self::itemInInputFieldForTagsInCurrentSectionDetailsViewForTag($tag))->isVisible()); + } catch (NoSuchElementException $exception) { + } + } + + /** + * @Then I see that the tag :tag in the dropdown for tags in the details view is checked + */ + public function iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsChecked($tag) { + PHPUnit_Framework_Assert::assertTrue( + $this->actor->find(self::checkmarkInItemInDropdownForTag($tag), 10)->isVisible()); + } + + /** + * @Then I see that the tag :tag in the dropdown for tags in the details view is not checked + */ + public function iSeeThatTheTagInTheDropdownForTagsInTheDetailsViewIsNotChecked($tag) { + PHPUnit_Framework_Assert::assertTrue( + $this->actor->find(self::itemInDropdownForTag($tag), 10)->isVisible()); + + PHPUnit_Framework_Assert::assertFalse( + $this->actor->find(self::checkmarkInItemInDropdownForTag($tag))->isVisible()); + } + /** * @When I see that the :tabName tab in the details view is eventually loaded */ diff --git a/tests/acceptance/features/bootstrap/SettingsContext.php b/tests/acceptance/features/bootstrap/SettingsContext.php new file mode 100644 index 00000000000..edbb6a94d15 --- /dev/null +++ b/tests/acceptance/features/bootstrap/SettingsContext.php @@ -0,0 +1,152 @@ +. + * + */ + +use Behat\Behat\Context\Context; + +class SettingsContext implements Context, ActorAwareInterface { + + use ActorAware; + + /** + * @return Locator + */ + public static function systemTagsSelectTagButton() { + return Locator::forThe()->id("s2id_systemtag")-> + describedAs("Select tag button in system tags section in Administration Settings"); + } + + /** + * @return Locator + */ + public static function systemTagsItemInDropdownForTag($tag) { + return Locator::forThe()->xpath("//*[contains(concat(' ', normalize-space(@class), ' '), ' select2-result-label ')]//span[normalize-space() = '$tag']/ancestor::li")-> + descendantOf(self::select2Dropdown())-> + describedAs("Item in dropdown for tag $tag in system tags section in Administration Settings"); + } + + /** + * @return Locator + */ + private static function select2Dropdown() { + return Locator::forThe()->css("#select2-drop")-> + describedAs("Select2 dropdown in Settings"); + } + + /** + * @return Locator + */ + private static function select2DropdownMask() { + return Locator::forThe()->css("#select2-drop-mask")-> + describedAs("Select2 dropdown mask in Settings"); + } + + /** + * @return Locator + */ + public static function systemTagsTagNameInput() { + return Locator::forThe()->id("systemtag_name")-> + describedAs("Tag name input in system tags section in Administration Settings"); + } + + /** + * @return Locator + */ + public static function systemTagsCreateOrUpdateButton() { + return Locator::forThe()->id("systemtag_submit")-> + describedAs("Create/Update button in system tags section in Administration Settings"); + } + + /** + * @return Locator + */ + public static function systemTagsResetButton() { + return Locator::forThe()->id("systemtag_reset")-> + describedAs("Reset button in system tags section in Administration Settings"); + } + + /** + * @When I create the tag :tag in the settings + */ + public function iCreateTheTagInTheSettings($tag) { + $this->actor->find(self::systemTagsResetButton(), 10)->click(); + $this->actor->find(self::systemTagsTagNameInput())->setValue($tag); + $this->actor->find(self::systemTagsCreateOrUpdateButton())->click(); + } + + /** + * @Then I see that the button to select tags is shown + */ + public function iSeeThatTheButtonToSelectTagsIsShown() { + PHPUnit_Framework_Assert::assertTrue($this->actor->find(self::systemTagsSelectTagButton(), 10)->isVisible()); + } + + /** + * @Then I see that the dropdown for tags in the settings eventually contains the tag :tag + */ + public function iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag($tag) { + // When the dropdown is opened it is not automatically updated if new + // tags are added to the server, and when a tag is created, no explicit + // feedback is provided to the user about the completion of that + // operation (that is, when the tag is added to the server). Therefore, + // to verify that creating a tag does in fact add it to the server it is + // necessary to repeatedly open the dropdown until the tag is shown in + // the dropdown (or the limit of tries is reached). + + PHPUnit_Framework_Assert::assertTrue($this->actor->find(self::systemTagsSelectTagButton(), 10)->isVisible()); + + $actor = $this->actor; + + $tagFoundInDropdownCallback = function() use($actor, $tag) { + // Open the dropdown to look for the tag. + $actor->find(self::systemTagsSelectTagButton())->click(); + + // When the dropdown is opened it is initially empty, and its + // contents are updated once received from the server. Therefore, a + // timeout must be used when looking for the tags. + try { + $tagFound = $this->actor->find(self::systemTagsItemInDropdownForTag($tag), 10)->isVisible(); + } catch (NoSuchElementException $exception) { + $tagFound = false; + } + + // Close again the dropdown after looking for the tag. When a + // dropdown is opened Select2 creates a special element that masks + // every other element but the dropdown to get all mouse clicks; + // this is used by Select2 to close the dropdown when the user + // clicks outside it. + $actor->find(self::select2DropdownMask())->click(); + + return $tagFound; + }; + + $numberOfTries = 5; + for ($i = 0; $i < $numberOfTries; $i++) { + if ($tagFoundInDropdownCallback()) { + return; + } + } + + PHPUnit_Framework_Assert::fail("The dropdown in system tags section in Administration Settings does not contain the tag $tag after $numberOfTries tries"); + } + +} diff --git a/tests/acceptance/features/bootstrap/SettingsMenuContext.php b/tests/acceptance/features/bootstrap/SettingsMenuContext.php index 1ff5d94e98f..cc0fc81cf78 100644 --- a/tests/acceptance/features/bootstrap/SettingsMenuContext.php +++ b/tests/acceptance/features/bootstrap/SettingsMenuContext.php @@ -43,6 +43,13 @@ class SettingsMenuContext implements Context, ActorAwareInterface { describedAs("Settings menu"); } + /** + * @return Locator + */ + public static function adminMenuItem() { + return self::menuItemFor("Admin"); + } + /** * @return Locator */ @@ -73,6 +80,15 @@ class SettingsMenuContext implements Context, ActorAwareInterface { $this->actor->find(self::settingsMenuButton(), 10)->click(); } + /** + * @When I open the Admin settings + */ + public function iOpenTheAdminSettings() { + $this->iOpenTheSettingsMenu(); + + $this->actor->find(self::adminMenuItem(), 2)->click(); + } + /** * @When I open the User settings */