upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-06-12 02:00:51 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 33

Do not allow transfer ownership when the user isn't the owner

Browse source 
Signed-off-by: Gary Kim <gary@garykim.dev>
This commit is contained in:
Gary Kim 2020-03-04 13:58:55 +08:00
parent 8607a9871c
commit 00dd295c09
No known key found for this signature in database
GPG key ID: 9349B59FB54594AC
4 changed files with 12 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
apps/files/js/dist/personal-settings.js vendored
View file

File diff suppressed because one or more lines are too long

2
apps/files/js/dist/personal-settings.js.map vendored
View file

File diff suppressed because one or more lines are too long

4
apps/files/lib/Controller/TransferOwnershipController.php
View file

@ -96,6 +96,10 @@ class TransferOwnershipController extends OCSController {
return new DataResponse([], Http::STATUS_BAD_REQUEST);
}
if ($node->getOwner()->getUID() !== $this->userId) {
return new DataResponse([], Http::STATUS_FORBIDDEN);
}
$transferOwnership = new TransferOwnershipEntity();
$transferOwnership->setSourceUser($this->userId);
$transferOwnership->setTargetUser($recipient);

6
apps/files/src/components/TransferOwnershipDialogue.vue
View file

@ -215,7 +215,11 @@ export default {
.catch(error => {
logger.error('Could not send ownership transfer request', { error })
this.submitError = error.message || t('files', 'Unknown error')
if (error && error.response && error.response.status === 403) {
this.submitError = t('files', 'Cannot transfter ownership of a file or folder you don\'t own')
} else {
this.submitError = error.message || t('files', 'Unknown error')
}
})
},
},