77fc3548ae
This fixes an issue that appears when running check_procs over NRPE,
where the default shell is configured to (for example) dash, as is the
case on Debian.
dash (and tcsh, and mksh, and probably others), when invoked with -c forks an additional process
to execute the argument string. Contrast this with bash, which does not
do this, provided that the argument string simply can be exec()'d as-is.
To demonstrate:
$ bash -c pstree
init─┬ ..
...
├─sshd─-─sshd───pstree
versus
$ dash -c pstree
init─┬ ..
...
├─sshd─-─sshd───dash───pstree
The consequence of this fork is that the following invocation:
/opt/plugins/check_procs -a init
will result in this output:
PROCS OK: 2 processes with args 'init' | processes=2;;;0;
because the check_procs, in addition to finding the actual init process,
finds its parent shell as well.
This example is a bit contrived, but I think it illustrates the
point.
This wouldn't really be a problem, and normally isn't, if it weren't
for the fact that NRPE uses a call to popen() which does exactly the
above (executes '/bin/sh -c ...'), causing inconsistent behaviour
between distributions and much confusion for end users.
The argument may be made that the dash process spawned by NRPE is just a
process like any other, and should therefore be included in the process
count just like any other. However, this is not very intuitive, because
of the previously mentioned inconsistencies.
The argument might also well be made that we're _never_ interested in the
immediate ancestor of the plugin, and while it is unknown how many
installations have already made the necessary modifications to their
setups to make up for the fact that the plugin behaves the way it does,
it is not deemed worthwhile to entertain such workarounds.
Thus, this patch ignores the parent process.
See also these bug reports:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626913
http://sourceforge.net/p/nagiosplug/bugs/512/
https://github.com/nagios-plugins/nagios-plugins/issues/999
https://bugs.op5.com/view.php?id=4398
|
||
|---|---|---|
| build-aux | ||
| config_test | ||
| doc | ||
| gl | ||
| lib | ||
| m4 | ||
| perlmods | ||
| pkg | ||
| plugins | ||
| plugins-root | ||
| plugins-scripts | ||
| po | ||
| tap | ||
| tools | ||
| .gitignore | ||
| ABOUT-NLS | ||
| acinclude.m4 | ||
| ACKNOWLEDGEMENTS | ||
| AUTHORS | ||
| autogen.sh | ||
| CODING | ||
| config.rpath | ||
| configure.in | ||
| COPYING | ||
| FAQ | ||
| LEGAL | ||
| Makefile.am | ||
| mkinstalldirs | ||
| nagios-plugins.spec.in | ||
| NEWS | ||
| NP-VERSION-GEN | ||
| NPTest.pm | ||
| opttest.pl | ||
| README | ||
| README.md | ||
| REQUIREMENTS | ||
| ROADMAP | ||
| SUPPORT | ||
| test.pl.in | ||
| THANKS.in | ||
Nagios Plugins
-
For instructions on installing these plugins for use with Nagios, see below. In addition, generic instructions for the GNU toolchain can be found in the
INSTALLfile. -
For major changes between releases, read the
NEWSfile. -
For information on detailed changes that have been made or plugins that have been added, read the
ChangeLogfile. -
Some plugins require that you have additional programs and/or libraries installed on your system before they can be used. Plugins that are dependent on other programs/libraries that are missing are usually not compiled. Read the
REQUIREMENTSfile for more information. -
Individual plugins are self-documenting. All plugins that comply with the basic guidelines for development will provide detailed help when invoked with the
-hor--helpoptions.
You can check for the latest plugins at:
Send an email to nagiosplug-help@lists.sourceforge.net for assistance.
Please include the OS type and version that you are using. Also, run the
plugin with the -vvv option and provide the resulting version information.
Of course, there may be additional diagnostic information required as well.
Use good judgment.
Send an email to nagiosplug-devel@lists.sourceforge.net for developer discussions.
For patch submissions and bug reports, please use the appropriate resources at https://github.com/nagios-plugins/nagios-plugins.
Installation Instructions
-
If you are using the Git tree, you will need m4, gettext, automake, and autoconf. To start out, run:
./tools/setupFor more detail, see the developer guidelines at https://www.nagios-plugins.org/doc/guidelines.html.
-
Run the configure script to initialize variables and create a Makefile, etc.
./configure --prefix=BASEDIRECTORY --with-cgiurl=SOMEURLReplace
BASEDIRECTORYwith the path of the directory under which Nagios is installed (default is/usr/local/nagios), and replaceSOMEURLwith the path used to access the Nagios CGIs with a web browser (default is/nagios/cgi-bin). -
Compile the plugins with the following command:
make -
Install the compiled plugins and plugin scripts with the following command:
make installThe installation procedure will attempt to place the plugins in a
libexec/subdirectory in the base directory you specified with the--prefixargument to the configure script. -
There are some plugins that require setuid. If you run make install as a non-root user, they will not be installed. To install, switch to root and run:
make install-root
That's it! If you have any problems or questions, feel free to send an email to nagiosplug-help@lists.sourceforge.net.
License Stuff
This software is released under the GNU General Public License, Version 3, with the additional exemption that compiling, linking and/or using OpenSSL is allowed.
See the COPYING file for the complete GPLv3 text.