mirror of
https://github.com/monitoring-plugins/monitoring-plugins.git
synced 2026-04-15 22:00:06 -04:00
117cd8e4b8
* check_disk increase alert precision
Free disk percentage value was rounded to a full integer meaning it alerted about ~1% percent too early. This is about 10GB on a 1TB disk.
The warning and critical thresholds already support float values, so just the percentage calculation needs to be improved.
old:
./check_disk -w 35% -c 20% -p / -f -vvv
Thresholds(pct) for / warn: 35.000000 crit 20.000000
calling stat on /
For /, used_pct=65 free_pct=35 used_units=286451 free_units=156651 total_units=443102 used_inodes_pct=11 free_inodes_pct=89 fsp.fsu_blocksize=4096 mult=1048576
Freespace_units result=0
Freespace% result=1
Usedspace_units result=0
Usedspace_percent result=0
Usedinodes_percent result=0
Freeinodes_percent result=0
DISK WARNING - free space: WARNING [ / 156651MiB (35% inode=89%)];| /=300365643776B;302006979788;371700898201;0;464626122752
new:
./check_disk -w 35% -c 20% -p / -f -vvv
Thresholds(pct) for / warn: 35.000000 crit 20.000000
calling stat on /
For /, used_pct=64.649722 free_pct=35.350278 used_units=286464 free_units=156637 total_units=443102 used_inodes_pct=10.016183 free_inodes_pct=89.983817 fsp.fsu_blocksize=4096 mult=1048576
Freespace_units result=0
Freespace% result=0
Usedspace_units result=0
Usedspace_percent result=0
Usedinodes_percent result=0
Freeinodes_percent result=0
DISK OK - free space: / 156637MiB (35.4% inode=90%);| /=300379275264B;302006979788;371700898201;0;464626122752
* check_disk: adjust test case to support float precision
|
||
|---|---|---|
| .. | ||
| check_apt_input | ||
| check_apt.t | ||
| check_by_ssh.t | ||
| check_cluster.t | ||
| check_curl.t | ||
| check_dbi.t | ||
| check_dig.t | ||
| check_disk.t | ||
| check_dns.t | ||
| check_dummy.t | ||
| check_fping.t | ||
| check_ftp.t | ||
| check_hpjd.t | ||
| check_http.t | ||
| check_imap.t | ||
| check_jabber.t | ||
| check_ldap.t | ||
| check_load.t | ||
| check_mysql.t | ||
| check_mysql_query.t | ||
| check_nagios.nagios1.status.log | ||
| check_nagios.nagios2.status.dat | ||
| check_nagios.t | ||
| check_ntp.t | ||
| check_ping.t | ||
| check_pop.t | ||
| check_procs.t | ||
| check_smtp.t | ||
| check_snmp.t | ||
| check_ssh.t | ||
| check_swap.t | ||
| check_tcp.t | ||
| check_time.t | ||
| check_udp.t | ||
| check_users.t | ||
| negate.t | ||