Commit graph

96 commits

Author SHA1 Message Date
Thomas Guyot-Sionnest
e7e9a99117 Fix usage of repeated -o options in check_snmp 2009-10-22 03:25:41 -04:00
Thomas Guyot-Sionnest
b8a64210bd Fix segfault in check_snmp (definitive fix is still in the works - see bug #2832451) 2009-08-05 03:13:08 -04:00
Thomas Guyot-Sionnest
1295c93651 Fix check_snmp passing single-quotes as -m argument when it should be empty 2009-07-31 23:35:50 -04:00
Thomas Guyot-Sionnest
43571dba91 check_snmp: Add some verbose output and tests 2009-07-31 03:52:10 -04:00
Thomas Guyot-Sionnest
7cb3ae0933 check_snmp: Make use of standard threshold functions
This patch makes use of standard threshold functions. This allows using
	doubles as thresholds.

	Since SNMP supports only integers, double precision numbers are only
	printed when parsed from a STRING type.

	In addition, support for printing properly Timeticks type has been added,
	and the code has been thoroughly cleaned.
2009-05-28 08:10:49 -04:00
Thomas Guyot-Sionnest
34fe4d62fe Fix whitespaces in check_snmp 2009-05-27 01:38:28 -04:00
Thomas Guyot-Sionnest
e9f5442bb3 check_snmp: Fix potential buffer overflow - enforce MAX_OIDS limit (John A. Barbuto) 2009-03-18 03:47:23 -04:00
Thomas Guyot-Sionnest
e2aec83e61 check_snmp fixes:
- Fix broken compilation caused by typo in command ending
- Remove extra whitespaces at EOL
- Fix invalid host test on Ubuntu Hardy (and possibly others)
2009-03-16 01:37:00 -04:00
Ton Voon
12c17fe8a2 Ignore stderr messages unless return code is non-zero or there is no output 2009-03-14 02:36:20 +00:00
Ton Voon
36e58ae0c3 Fixed passing of quotes in OID for check_snmp (#1985230 - Jan Wagner, patch by John Barbuto) 2009-03-14 01:17:50 +00:00
Thomas Guyot-Sionnest
660dabd5ac check_snmp long help missing retries entry (#2608223)
Fix for check_snmp long help, reported by Richard Edward Horner
2009-02-24 04:43:09 -05:00
Ton Voon
5324544855 Typo fixes (Jan Wagner - SF 1878971) 2009-02-20 00:00:13 +00:00
Ton Voon
639f7b2c82 Allow privproto to be passed through check_snmp to snmpget. Defaults to DES
for compatibility
2008-12-23 11:52:04 +00:00
Thomas Guyot-Sionnest
6fbd14fea5 Removing CVS/SVN tags and replacing with git-based versioning
For contrib/, full tags have been imported from subversion


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2091 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-23 05:38:47 +00:00
Thomas Guyot-Sionnest
caa8bd6423 Bulk EOL cleanup
$ git diff --ignore-space-change|diffstat
 0 files changed


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2087 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-19 06:45:18 +00:00
Matthias Eble
be144b6720 check_snmp now only prints perfdata for non numeric values (Joerg Linge #1867716)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2021 f882894a-f735-0410-b71e-b25c423dba1c
2008-07-09 21:53:12 +00:00
Thomas Guyot-Sionnest
44f8455b2c Added support for --extra-opts in all C plugins (disabled by default, see configure --help)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1991 f882894a-f735-0410-b71e-b25c423dba1c
2008-05-07 10:02:42 +00:00
Thomas Guyot-Sionnest
ed62784a0b --help output cleanup (plus removal of spaces on blank lines)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1984 f882894a-f735-0410-b71e-b25c423dba1c
2008-04-27 14:35:26 +00:00
Thomas Guyot-Sionnest
6c4468a728 Bump plugin/ to GPLv3 (check_overcr to check_users)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1917 f882894a-f735-0410-b71e-b25c423dba1c
2008-01-31 10:44:26 +00:00
Thomas Guyot-Sionnest
2af978187c Plenty of french translations (and a few fixes BTW)
- No more fuzzy french translations
 - Only (!) 355 strings to translate


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1859 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-10 07:52:00 +00:00
Thomas Guyot-Sionnest
1bb5e1e2ff Fix broken usage2 in check_snmp and check_cluster
Fix check_cluster blocking some special characters for thresholds ("-", "@", "~")



git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1827 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-11 16:29:05 +00:00
Thomas Guyot-Sionnest
d2f758c5ee Fix check_snmp buffer overflow (CVE-2007-5623)
This patch comes from the Gentoo Portage tree but I couldn't find the author. I sent an email and will give credits when I get an answer.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1814 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-09 16:05:48 +00:00
Thomas Guyot-Sionnest
dca25be31a Fix missing \n in --help output
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1812 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-09 13:06:32 +00:00
Holger Weiss
745b58a68b Hide the SNMP community string (and v3 passwords) from error messages
(Bernhard Fischer on nagiosplug-devel@)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1809 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-24 15:08:34 +00:00
Thomas Guyot-Sionnest
063d2541ef check_snmp don't warn anymore if something is printed on stderr
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1721 f882894a-f735-0410-b71e-b25c423dba1c
2007-05-29 05:22:32 +00:00
Thomas Guyot-Sionnest
757e1676f1 change a bunch of whitespaces (no code was harmed)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1720 f882894a-f735-0410-b71e-b25c423dba1c
2007-05-29 04:25:24 +00:00
Thomas Guyot-Sionnest
6a564052ea Fix bug #1344584: Counter64 values not handled correctly
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1687 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-15 06:44:46 +00:00
Thomas Guyot-Sionnest
0dbab53464 Fix parsing of multiple OIDs sets needmibs = TRUE
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1605 f882894a-f735-0410-b71e-b25c423dba1c
2007-02-02 09:10:22 +00:00
Holger Weiss
fd329a1e91 Don't try to print `optarg' (which will be a NULL pointer) if an unknown
command line option was used, as this leads to a segfault on some
systems.  The unknown option will be printed by getopt(3) anyway.  So,
simply call print_usage() and exit UNKNOWN via the new usage5() instead.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1590 f882894a-f735-0410-b71e-b25c423dba1c
2007-01-28 21:46:41 +00:00
Ton Voon
70b519bb27 Reverting back accidently regressed code
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1513 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-20 07:53:31 +00:00
Benoit Mortier
a99ce595ef adding missing check_snmp
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1510 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-19 23:56:04 +00:00
Ton Voon
420f2b0009 Initialise strings for Fedora Core 5 (Henning Schmiedehausen)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1505 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-19 19:36:00 +00:00
Ton Voon
92585ee4a5 Removed asprintf for perf data (Craig Orsinger, Robby Giffin - 1310495)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1504 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-19 19:25:52 +00:00
Ton Voon
3834b3262a type variable not cleared in Sol 10 (Kyle Tucker)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1503 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-19 19:13:45 +00:00
Benoit Mortier
679f03fbee cleaning help and usage
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1437 f882894a-f735-0410-b71e-b25c423dba1c
2006-06-21 11:05:00 +00:00
Benoit Mortier
f2d66913f9 cleaning help and usage + license
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1435 f882894a-f735-0410-b71e-b25c423dba1c
2006-06-20 11:17:03 +00:00
Ton Voon
5fd2550d4c Use coreutils' regexp libraries, so regexp always available now
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1403 f882894a-f735-0410-b71e-b25c423dba1c
2006-05-25 12:33:24 +00:00
Ton Voon
f7bb6d16e6 Variables need to be declared at top of code for better portability
(Gerhard Lausser)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1399 f882894a-f735-0410-b71e-b25c423dba1c
2006-05-24 09:05:35 +00:00
M. Sean Finney
3038819fef code cleanups, largely resulting from turning on -Wall. mostly
unused variables and explicit casting issues, but there were a
couple gotchas in there too.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1267 f882894a-f735-0410-b71e-b25c423dba1c
2005-10-31 20:03:19 +00:00
Subhendu Ghosh
bba4957fb2 only load mibs if needed or specified - patch 1212395
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1187 f882894a-f735-0410-b71e-b25c423dba1c
2005-06-01 19:41:01 +00:00
Subhendu Ghosh
11ad8930d1 support for getnext - 1106430
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1182 f882894a-f735-0410-b71e-b25c423dba1c
2005-05-25 15:40:32 +00:00
Subhendu Ghosh
1c13d632b4 v2c support - 1155754
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1178 f882894a-f735-0410-b71e-b25c423dba1c
2005-05-25 03:23:19 +00:00
Harper Mann
5d7f904c20 This is a first cut at adding performance data to check_snmp. I wasn't sure
how to handle UOM so only values that return SNMP type Counter32: are labled
with "c".  All other values have a blank UOM.  I also left off warn, crit,
max and min values in the performance data until we come up with a way to
handle them.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1157 f882894a-f735-0410-b71e-b25c423dba1c
2005-04-05 21:26:56 +00:00
Harper Mann
5e2927a2b8 Tracker 1106378 fixed - The -t (timeout) arg was not handled correctly when passed to the snmpget command. Added -e --retries for the correct retries value to snmpcmd.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1092 f882894a-f735-0410-b71e-b25c423dba1c
2005-01-21 01:03:56 +00:00
Benoit Mortier
7df9bd7bab more internationalization fixes
internationalization freeze for beta1


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1067 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-30 00:41:41 +00:00
Benoit Mortier
e9ccc6b21a various fixes for localization
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1061 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-25 23:17:46 +00:00
Benoit Mortier
e71d2c2b71 patch 1028033
minor internationalization fixes


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1013 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-08 00:36:19 +00:00
Matthew Kent
a7b1d2b060 Fix for -s string matching (#756567, Tony Missana)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1006 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-05 22:07:30 +00:00
Benoit Mortier
30a4266a3a reverting my changes from !=TRUE to == ERROR, that's not good ;-( sorry
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@998 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03 23:55:29 +00:00
Benoit Mortier
5e3fc41c61 print_help and print_usage() cleanup
other misc cleanups


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@996 f882894a-f735-0410-b71e-b25c423dba1c
2004-12-03 23:02:04 +00:00