Commit graph

1856 commits

Author SHA1 Message Date
RincewindsHat
ce355c80cf Initialize slaveresult to 0 and use strncat instead of bsd strlcat 2023-09-18 22:58:34 +02:00
RincewindsHat
c405dbafcc Add mysql_close to avoid spamming the server logs 2023-09-18 19:18:35 +02:00
Gerardo Malazdrewicz
3929c5ac37
check_mysql.c: Detect running mysqldump
When checking a slave, if the IO Thread or the SQL Thread are stopped, check for running mysqldump threads, return STATE_OK if there is any.
Requires PROCESS privilege to work (else the mysqldump thread(s) would not be detected).

Enlarged SLAVERESULTSIZE to fit "Mysqldump: in progress" at the end of the string.
Got a NULL pointer in row[seconds_behind_field] instead of the "NULL" string when a mysqldump is running [mysql 5.7.34 + libmariadb3 10.3.31], so added a check for that.
2021-10-31 09:37:55 -03:00
RincewindsHat
884327ee21 Replace tabs with spaces and do some formatting 2021-10-27 12:53:13 +02:00
RincewindsHat
5974b0481c Remove whitespace at the end of lines 2021-10-27 12:53:13 +02:00
RincewindsHat
4c8ab67dd3 Fix my own errors for real this time and add some comments, so I wont do them again 2021-10-26 21:09:55 +02:00
RincewindsHat
73ed8109e5 Re-add separation semicolons for perfdata, which I deleted 2021-10-26 20:47:28 +02:00
RincewindsHat
6e0586c8e3 Reform some arithmetical operations for more clarity 2021-10-26 17:07:09 +02:00
RincewindsHat
1c0882def0 hopefully fix warning high tide with percentage 2021-10-26 17:07:09 +02:00
RincewindsHat
726a29a3ac Fix some tests 2021-10-26 17:07:09 +02:00
RincewindsHat
d3af7a353e Remove useless lines and fix some formatting 2021-10-26 17:07:09 +02:00
RincewindsHat
50fc9b73a2 Switch to uint64_t 2021-10-26 17:07:09 +02:00
RincewindsHat
8f2cfd1c80 Reformat a little bit for easier reading 2021-10-26 17:07:09 +02:00
RincewindsHat
078c69d2dd Recognice IEC binary units and format accordingly to base2 (always) 2021-10-26 17:07:09 +02:00
Harald Jenny
e79ada81a6 Update check_load.t
adjust tests for new plugin output
2021-10-25 16:28:15 +02:00
Harald Jenny
a08215368e Create check_load.c
just a cosmetic fix so the load plugin display a LOAD prefix before check results
2021-10-25 16:28:15 +02:00
RincewindsHat
46c5327e34 Revert to poor man's logic 2021-10-02 23:37:12 +02:00
RincewindsHat
d2f2da175e Change all to comments to old comment style 2021-10-02 12:47:50 +02:00
RincewindsHat
f55ea7632f Fix comparing logic 2021-09-26 01:34:45 +02:00
RincewindsHat
280ae58ed8 Remove spaces from tests 2021-09-26 00:34:44 +02:00
rincewind
4621427ba8 check_swap: Fix perfdata und thresholds for big values and simplify code
The original problem was https://github.com/monitoring-plugins/monitoring-plugins/pull/1705
where the performance data output of check_swap did not conform to
the parser logic of a monitoring system (which decided to go for
"correct" SI or IEC units.
The PR was accompanied by a change to byte values in the performance
data which broke the _perfdata_ helper function which could not handle
values of this size.
The fix for this, was to use _fperfdata_ which could, but would
use float values.

I didn't like that (since all values here are discreet) and this
is my proposal for a fix for the problem.

It introduces some helper functions which do now explicitely work
with (u)int64_t, including a special version of the _perfdata_ helper.

In the process of introducing this to check_swap, I stumbled over
several sections of the check_swap code which I found problematic.
Therefore I tried to simplify the code and make it more readable
and less redundant.

I am kinda sorry about this, but sincerely hope my changes can
be helpful.
2021-09-25 23:24:45 +02:00
rincewind
66e2453759 Introduce new perfdata functions and stuff for using (u)int64_t 2021-09-25 23:24:34 +02:00
Jonny007-MKD
cfc43a3275 Improvements suggested by tobiaswiese 2021-09-02 09:56:39 +02:00
Jonny007-MKD
2056c58531 check_dns: Fix memory leak 2021-09-02 09:56:39 +02:00
Jonny007-MKD
70f55ca9db check_dns: add --expect-nxdomain 2021-09-02 09:56:39 +02:00
Sven Nierlein
e17c1e9ed9
Merge pull request #1388 from waja/check_proc_consumption_1357
check_disk: Fixing the stuff that is broken on btrfs
2021-08-24 09:05:01 +02:00
Andreas Baumann
67088216ab Merge branch 'master' into feature_check_curl 2021-07-28 19:17:46 +02:00
Andreas Baumann
de5503063e check_curl: fixed a potential buffer overflow in retir/uri_string 2021-07-25 18:49:06 +02:00
Andreas Baumann
3f5c54c783 check_curl: fixed DNS caching for SSL hostnames (avoid CURLOPT_RESOLVE entry errors) 2021-07-25 18:39:07 +02:00
Sven Nierlein
e72ff30017
Merge pull request #1690 from xFuture603/change_state_from_infinite_redirect_loop
check_http: changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loop
2021-07-08 11:31:56 +02:00
Andreas Baumann
6e696643a5 check_curl: changed to STATE_CRITICAL for infinite loops (-ffollow) 2021-07-04 18:43:42 +02:00
Lorenz Kästle
6e5ee70d07 Let ssh decide if a host is valid, enables usage of ssh .config file 2021-06-25 12:12:48 +02:00
Andreas Baumann
0b6838ffca fix for missing X509_up_ref on old systems with only OpenSSL 1.0 2021-06-24 17:08:20 +00:00
Daniel Uhlmann
a1af8be978 changed 'STATE_CRITICAL' to 'STATE_WARNING' for infinite loop 2021-06-24 11:37:14 +02:00
Andreas Baumann
20e9451fad added option --enable-automatic-decompression 2021-06-24 11:02:28 +02:00
Andreas Baumann
beb609ffcf check_curl:
- added verbose output in verify_callback
- pin refcounting for certs (avoid subject extraction error when checking
  certs in is_openssl_callback mode)
2021-05-27 15:32:08 +02:00
Sven Nierlein
b428cc17f7 tests: ignore sigpipes in https test daemon
check_http closes the connection after checking the certificate with -C. This leads to sigpipe
errors when the ssl daemon wants to send a response and the daemon quits which makes the
subsequent tests fail.
2021-05-20 20:57:59 +02:00
Sven Nierlein
eb75d847ae tests: increase startup sleep
github action might fail from to time otherwise
2021-05-20 18:04:49 +02:00
Jacob Hansen
0bbcb60f02
Refactor check_fping
* Set correct amount of tests based on conditionals.
* When running the test as non-root, we would previously check is the
setuid bit is set. This doesn't seem to be needed, so just check if the
binary is executable for the user running the test.
* Use cmp_ok to check if tests succeeds rather than couting.

Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-19 13:36:04 +02:00
Jacob Hansen
ae2fe683e3
check_curl.t: Adjust test to use -f curl
It appears that `-f follow` doesn't work correctly in `check_curl` at
the moment. Test adjusted to use `-f curl` instead.

Issue for the above created: https://github.com/monitoring-plugins/monitoring-plugins/issues/1685

Signed-off-by: Jacob Hansen <jhansen@op5.com>
2021-05-18 15:19:43 +02:00
Aksel Sjögren
5ab03a7095
Fix conditional tests for check_http, check_curl
Set correct number of tests in skip- blocks to avoid the error "Bad
plan.  You planned 50 tests but ran 55" when run with/without
/usr/bin/faketime and NP_INTERNET_ACCESS=yes/no.
2021-04-30 11:13:59 +02:00
Sven Nierlein
fc71e3f930 migrate travis ci to github actions 2021-04-30 09:56:52 +02:00
Sven Nierlein
444a3579b2 fix fping test
in case of dns errors, fping returns an unknown and thats ok.
2021-04-30 09:56:52 +02:00
Barak Shohat
f0ac7fcc7c check_curl: Fix bug where headers beginning with HTTP_ cause the status line parsing to fail. 2021-04-13 12:06:18 +02:00
Andreas Baumann
cd358cd08a check_curl: backported --show-body/-B to print body (from check_http) 2021-04-08 20:39:48 +02:00
Andreas Baumann
1debd29b57 check_curl: make -C obvious (from check_http, part 2) 2021-04-08 15:14:53 +02:00
Andreas Baumann
a6acea7941 check_curl: make -C obvious (from check_http) 2021-04-08 14:15:54 +02:00
Andreas Baumann
f90aec83cb check_curl: Increase regexp limit (to 1024 as in check_http) 2021-04-08 14:07:20 +02:00
Sven Nierlein
f6fd14e886
Merge pull request #1669 from bazzisoft/verify-cert
Add an option to check_curl to verify the peer certificate & host using the system CA's
2021-04-07 17:51:38 +02:00
Sven Nierlein
b145ea1998
Merge pull request #1554 from stblassitude/master
Docs check_http: make -C obvious
2021-04-07 17:16:12 +02:00