upstream/monitoring-plugins
1
0
Fork 0
mirror of https://github.com/monitoring-plugins/monitoring-plugins.git synced 2026-03-28 13:23:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 2
2135 commits 22 branches 38 tags 27 MiB
Commit graph

37 commits

Author SHA1 Message Date
Holger Weiss
08f8307204 Fix Debian bug #482947: No --nas-ip-address option 
| check_radius doesn't seem to provide any way to modify the
| NAS-IP-Address attribute that it uses in the packets it sends, but it
| does so for NAS-Identifier.
|
| Instead, it hardcodes the IP address that it gets from the
| rc_own_ipaddress() library call, and that in turn translates into
| calling gethostbyname() on the result of uname(). This call can easily
| fail, and its result can easily be unsuitable - for example when the
| Nagios instance uses its own virtual host, and you don't want the
| original system hostname leaked to the RADIUS servers you monitor with
| this.
|
| Furthermore, this behaviour is inconsistent with RFC 2865, which
| defines the two attributes as analogous and never suggests hardcoding
| the value of either of them in client software.

Therefore, this commit adds the "-N, --nas-ip-address" option which
allows for specifying the value of the NAS-IP-Address attribute.

| I've also noticed that the original code for NAS-IP-Address hardcoding
| is broken in its error handling - it does "return (ERROR_PC)", which
| is meaningless in the context of check_radius.c. That actually seems
| to be copy&waste from radiusclient-0.3.2/src/radexample.c. :) I fixed
| that.
|
| While debugging, I also took the opportunity to decouple the
| nas-identifier rc_avpair_add() instance from the initial three,
| because this is just bad practice to lump a fourth optional attribute
| into the same block with the required attributes, the error handling
| for which is throwing the same daft message "Out of Memory?"...

[ http://bugs.debian.org/482947 ]

(Contributed by Josip Rodin, forwarded by Jan Wagner.)
 2010-04-11 16:33:44 +02:00
Ton Voon
5324544855 Typo fixes (Jan Wagner - SF 1878971) 2009-02-20 00:00:13 +00:00
Thomas Guyot-Sionnest
6fbd14fea5 Removing CVS/SVN tags and replacing with git-based versioning 
For contrib/, full tags have been imported from subversion


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2091 f882894a-f735-0410-b71e-b25c423dba1c
 2008-11-23 05:38:47 +00:00
Thomas Guyot-Sionnest
caa8bd6423 Bulk EOL cleanup 
$ git diff --ignore-space-change|diffstat
 0 files changed


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2087 f882894a-f735-0410-b71e-b25c423dba1c
 2008-11-19 06:45:18 +00:00
Thomas Guyot-Sionnest
eaf61e51ac Clobber password in check_radius process list aguments 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1994 f882894a-f735-0410-b71e-b25c423dba1c
 2008-05-20 07:57:13 +00:00
Thomas Guyot-Sionnest
44f8455b2c Added support for --extra-opts in all C plugins (disabled by default, see configure --help) 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1991 f882894a-f735-0410-b71e-b25c423dba1c
 2008-05-07 10:02:42 +00:00
Thomas Guyot-Sionnest
ed62784a0b --help output cleanup (plus removal of spaces on blank lines) 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1984 f882894a-f735-0410-b71e-b25c423dba1c
 2008-04-27 14:35:26 +00:00
Thomas Guyot-Sionnest
140a93ce6b Correct typo and make the --help notes a bit simpler. 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1983 f882894a-f735-0410-b71e-b25c423dba1c
 2008-04-23 08:19:13 +00:00
Thomas Guyot-Sionnest
6c4468a728 Bump plugin/ to GPLv3 (check_overcr to check_users) 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1917 f882894a-f735-0410-b71e-b25c423dba1c
 2008-01-31 10:44:26 +00:00
Thomas Guyot-Sionnest
2af978187c Plenty of french translations (and a few fixes BTW) 
- No more fuzzy french translations
 - Only (!) 355 strings to translate


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1859 f882894a-f735-0410-b71e-b25c423dba1c
 2007-12-10 07:52:00 +00:00
Holger Weiss
faf593d23a Drop the weird and undocumented behaviour of using positional argument 
parsing instead of getopt(3) if 8 command line arguments were given (as
suggested by Matthias) and check whether all required arguments have
been specified in order to spit out proper error messages and to avoid a
possible segfault (as suggested by Thomas).


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1800 f882894a-f735-0410-b71e-b25c423dba1c
 2007-09-26 10:57:44 +00:00
Matthias Eble
d1c9a5cf6a Added radiusclient-ng support for check_radius. Thanks to Sebastien Guay (#1218438) 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1788 f882894a-f735-0410-b71e-b25c423dba1c
 2007-09-23 09:48:37 +00:00
Holger Weiss
fd329a1e91 Don't try to print `optarg' (which will be a NULL pointer) if an unknown 
command line option was used, as this leads to a segfault on some
systems.  The unknown option will be printed by getopt(3) anyway.  So,
simply call print_usage() and exit UNKNOWN via the new usage5() instead.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1590 f882894a-f735-0410-b71e-b25c423dba1c
 2007-01-28 21:46:41 +00:00
Holger Weiss
5aa4d5bbb9 Initialize `data' to zero, fixes potential segfault (Nobuhiro Ban - 1642658) 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1576 f882894a-f735-0410-b71e-b25c423dba1c
 2007-01-23 16:42:01 +00:00
Benoit Mortier
d8ecf6bfc2 another round of localization cleaning 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1509 f882894a-f735-0410-b71e-b25c423dba1c
 2006-10-19 23:53:28 +00:00
Benoit Mortier
f2d66913f9 cleaning help and usage + license 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1435 f882894a-f735-0410-b71e-b25c423dba1c
 2006-06-20 11:17:03 +00:00
Benoit Mortier
e9ccc6b21a various fixes for localization 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1061 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-25 23:17:46 +00:00
Benoit Mortier
30a4266a3a reverting my changes from !=TRUE to == ERROR, that's not good ;-( sorry 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@998 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-03 23:55:29 +00:00
Benoit Mortier
5e3fc41c61 print_help and print_usage() cleanup 
other misc cleanups


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@996 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-03 23:02:04 +00:00
Benoit Mortier
edf60f6dce remove UT_HLP_VRS from print_usage 
this was not a good idea ;-)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@994 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-03 20:28:53 +00:00
Benoit Mortier
2ad398d2e0 fixes for internationalization 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@990 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-03 16:56:27 +00:00
Benoit Mortier
016d33230e bump copyright year 
initialize result to STATE_UNKNOW in place of STATE_OK


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@982 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-03 00:55:28 +00:00
Benoit Mortier
234481163f More internationalization work 
new usage4 function to permit localisation of think like check_ssh: xxxxx


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@979 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-02 16:51:25 +00:00
Benoit Mortier
df1bd0c89f return of process_arguments() is TRUE not OK ! 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@978 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-02 14:54:36 +00:00
Benoit Mortier
230d67e18a changed Error: by CRITICAL - 
more localization fixes


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@971 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-02 01:11:01 +00:00
Benoit Mortier
d19edd4043 standardize localization string 
standardize unknow arguments


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@969 f882894a-f735-0410-b71e-b25c423dba1c
 2004-12-01 23:54:51 +00:00
Ton Voon
0c1c9f51e2 Making messages more consistent 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@930 f882894a-f735-0410-b71e-b25c423dba1c
 2004-11-24 00:46:40 +00:00
Ton Voon
9ec2c84dbf Option to fill in NAS-identifier to Emulate pam_radius behaviour (Alexander Kulak) 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@851 f882894a-f735-0410-b71e-b25c423dba1c
 2004-03-18 20:31:52 +00:00
Karl DeBisschop
22bd672d19 - bindtextdomain for gettext, a few other smale cleanups here and there 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@690 f882894a-f735-0410-b71e-b25c423dba1c
 2003-08-22 06:22:38 +00:00
Karl DeBisschop
f4f92be60c the last round of pedantic compiler warnings 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@676 f882894a-f735-0410-b71e-b25c423dba1c
 2003-08-10 06:53:22 +00:00
Karl DeBisschop
9e17dab6c3 replace "terminate" with "die" for shorter name and better readability 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@656 f882894a-f735-0410-b71e-b25c423dba1c
 2003-08-07 11:51:12 +00:00
Karl DeBisschop
55def28f66 markup for translation 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@643 f882894a-f735-0410-b71e-b25c423dba1c
 2003-08-04 07:42:24 +00:00
Ton Voon
7283211f00 Remove getopt_long checks 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@396 f882894a-f735-0410-b71e-b25c423dba1c
 2003-03-11 22:22:12 +00:00
Karl DeBisschop
e200689550 semicolon needed where praogname define was replced 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@246 f882894a-f735-0410-b71e-b25c423dba1c
 2003-01-16 06:22:03 +00:00
Karl DeBisschop
0c3386274e convert PROGANE from a define to a const char 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@238 f882894a-f735-0410-b71e-b25c423dba1c
 2003-01-13 12:15:16 +00:00
Karl DeBisschop
2a68978c56 remove call_getopt and ssprintf 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@191 f882894a-f735-0410-b71e-b25c423dba1c
 2002-11-14 02:26:34 +00:00
Ethan Galstad
44a321cb8a Initial revision 
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2 f882894a-f735-0410-b71e-b25c423dba1c
 2002-02-28 06:42:51 +00:00