Commit graph

1464 commits

Author SHA1 Message Date
Jan Wagner
2e8d440e73 check_mysql: ignore authentication failure
This patch allows checking if MySQL server is running without providing valid
username and password. Similar to check_ssh plugin it returns MySQL server
version string and protocol number.

Example:
check_mysql -n -H aaa.bbb.ccc.ddd
MySQL OK - Version: 5.0.51a-24+lenny5 (protocol 10)

This is useful for monitoring servers where one does not have administrator
privileges or does not want to grant any privileges for the monitoring station.

To enable this functionality new option --ignore-auth (-n) is added to
check_mysql plugin.

Thanks to Julius Kriukas

Closes #1020
Closes #1178
2014-07-28 22:13:02 +02:00
Holger Weiss
b785a770e4 plugins/tests/check_http.t: Adjust date strings
Adjust the expected date strings to the now-localized output produced by
plugins/sslutils.c.

Closes #1275.
2014-07-21 21:52:33 +02:00
Holger Weiss
c5a64eeef8 plugins/t/check_dns.t: Fix Perl warning
Perl said: "Unrecognized escape \d passed through at ./t/check_dns.t
line 57."
2014-07-21 13:59:22 +02:00
Jan Wagner
3bf812beae sslutils: expire time in local timezone format
sshutils prints the expiry time of certificates in US format
this patch uses the strftime %c, I don't know how portable that is

Thanks to Neil Prockter.

Closes #1188
Closes #1161
Closes #977
Closes #976
Closes #975
Closes #840
Closes #382
2014-07-21 13:32:20 +02:00
Jan Wagner
71063655e5 travis-ci: Adding ports for check_hpjd 2014-07-20 23:36:18 +02:00
abrist
479509ad59 added tests for check_hpjd port options
---
Closes #1160 and #973
2014-07-20 23:36:05 +02:00
abrist
8e187dfefe Added check_hpjd port option to news and clarified the port usage error. 2014-07-20 23:35:54 +02:00
abrist
3c7d24478c check_hpjd - Added a switch for port specification. Defaults to 161. 2014-07-20 23:35:41 +02:00
abrist
78d00d338a check_ntp.t - fixed tests for new status output
closes #1236 and #1239
2014-07-20 23:35:03 +02:00
abrist
495cf3b2f8 check_ntp_peer - Added specific state output for each metric. It now should be easy to see which check caused the alert. 2014-07-20 23:34:41 +02:00
Mikael Falkvidd
f54d10fe9b check_procs: Add delay after forking in test
Forking raises a race condition, where the parent might run the
test before the child has had time to fork. If that happens,
an error similar to this is produced:
 Failed test 'Output correct'
 at ./t/check_procs.t line 32.
                 'PROCS OK: 0 processes with args 'sleep 7' | processes=0;;;0;'
   doesn't match '/^PROCS OK: 1 process?/'

Sleeping a bit should avoid the problem. It might be enough to
sleep less than a second, but perl's built-in sleep function only
supports integer seconds.

In our build environment, the build failed 3 of 4 times before
this patch. After the patch it failed 0 of 7 times.

Signed-off-by: Mikael Falkvidd <mfalkvidd@op5.com>
2014-07-10 21:10:48 +02:00
Holger Weiss
a2505f049d plugins/netutils.h: Adjust UNIX_PATH_MAX for BSD
On at least FreeBSD, NetBSD, OpenBSD, DragonFly, and OS X, this is
hard-coded at 104 bytes.

Closes #1267.
2014-07-07 11:33:39 +02:00
Jan Wagner
b62f2c14fb Merge PR #1265 from waja/check_tcp_server_addr 2014-06-30 15:13:39 +02:00
abrist
4277f47bff check_jabber.t - fixed tests for new status output including hostname 2014-06-30 13:55:42 +02:00
Sven Nierlein
ed914472e9 Merge pull request #1190 from waja/github780
check_ssh: check protocol
2014-06-30 13:42:02 +02:00
Sven Nierlein
2438931a3f Merge pull request #1262 from waja/fix_aix
Include common.h before any system headers.
2014-06-28 22:24:52 +02:00
Sven Nierlein
8d6c183347 Merge pull request #1264 from waja/check_nt_units
check_nt.c - Changed 'Mb' to 'MB' in MEMUSE.
2014-06-28 22:23:03 +02:00
Sven Nierlein
ea8ab2002c Merge pull request #1263 from waja/coverity_fixes
Serveral coverity fixes from nagios-plugins
2014-06-28 22:14:02 +02:00
Sven Nierlein
e566021a54 tests: added check_dns performance data test
Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-06-28 22:05:25 +02:00
abrist
e49973493c check_dns.c Added a bit more logic to thresholds
Added two if elses to cover when only one threshold is set.
2014-06-28 22:01:16 +02:00
Jean-Claude Computing
79ba1f90db check_dns: add warning and critical thresholds to perfdata 2014-06-28 22:01:16 +02:00
abrist
b5d78f9556 Cleaned up status output of check_tcp changes 2014-06-28 21:08:55 +02:00
Davide Madrisan
4231415878 check_tcp: also display the server addr when host_specified is set. This will help the admins when multiple checks are configured
Signed-off-by: Davide Madrisan <davide.madrisan@gmail.com>
2014-06-28 20:47:51 +02:00
abrist
6e12805fa4 check_nt.c - Changed 'Mb' to 'MB' in MEMUSE. 2014-06-28 20:13:50 +02:00
Spenser Reinhardt
aa16beb971 plugins/negate.c - Function should not return.
Coverity 66479 - validate_arguments has no need to return anything, as it dies on error, yet was set to return an int. Set to void to resolve warning.
2014-06-28 18:24:08 +02:00
Spenser Reinhardt
88472d1804 plugins/negate.c - Reorder if statement, aiob
Coverity 66480 - Potential array index out of bounds, since result was not verified to be positive prior to using as an index for state[]. Simply reording the if statement should resolve the issue. - SR
2014-06-28 18:23:09 +02:00
Spenser Reinhardt
5866cb0a09 plugins/check_http.c - leakage fix
Coverity 66514 - Possible leakage and overflow with addr in redirect functionality. Not confirmed as null terminated, and externally gathered. Restrict string comparisons and duplications by size. - SR
2014-06-28 18:21:26 +02:00
Spenser Reinhardt
a04df3e1b6 plugins/check_ntp.c - Verify struct from response
Coverity 66524 - req.data is not neccessarily null terminated but still feed to printf statements. This both does that, and verifies the struct more so than before. - SR
2014-06-28 18:18:28 +02:00
Spenser Reinhardt
b61f51ad02 plugins/check_real.c - recv string null terminate
Recv into buffer is not properly null terminated prior to strstr and possible other string functions expecting a null termination. Simply take bytes received and use as an index to append \0 after. We are creating buffer[] with size of MAX_INPUT_BUFFER and recv with MAX_INPUT_BUFFER-1 so this should never overflow.
2014-06-28 18:17:48 +02:00
Spenser Reinhardt
9ce73696b0 plugins/check_apt.c - Print uninitialized ereg
Coverity 66531 - ereg.buffer can be printed without being initialized if do_include and do_exclude are null and critical is an invalid regex. While minor this may leak memory and cause undefined behavior.
2014-06-28 18:16:59 +02:00
Eric J. Mislivec
6e246799b9 Include common.h before any system headers.
This should fix some problems building on AIX.
2014-06-28 18:09:28 +02:00
Sven Nierlein
b35d12e931 tests: always build and test on travis
also make test is now working on travis-ci

Signed-off-by: Sven Nierlein <sven@nierlein.de>
2014-06-24 15:07:44 +02:00
Jan Wagner
580bdd2863 check_ide_smart: Fixing spelling bug 2014-06-23 22:33:29 +02:00
Jan Wagner
9ac3fe7d50 check_mrtg: Fixing spelling bug 2014-06-23 22:28:28 +02:00
Jan Wagner
be55da1d23 check_ups/check_dbi: Fixing spelling bug 2014-06-23 22:20:03 +02:00
Holger Weiss
7979837c0d check_radius.c: Add newline to die() calls
Our die() function doesn't append a newline character to the message.
2014-06-22 21:43:38 +02:00
Holger Weiss
c0311d9848 check_radius: Support FreeRADIUS Client library
Allow for using the FreeRADIUS Client library instead of radiusclient or
radiusclient-ng.  The latter two projects are dead.

Closes #1231.
2014-06-22 14:10:38 +02:00
Holger Weiss
b63974c2cb plugins/runcmd.c: Remove superfluous newline
The puts(3) function already appends a newline character to the string.
2014-06-18 18:40:23 +02:00
Sven Nierlein
b2fed383b1 tests: freebsds snmpd does not use quotes
when returning syscontact. So make them optional since we want to test
check_snmp and not the snmpd.

Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13 16:34:03 +02:00
Sven Nierlein
4102eaae0e tests: check_proc tests fail if uid -2 does not map to nobody
so make sure our tests only run if -2 maps to nobody

Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13 15:57:21 +02:00
Sven Nierlein
93901d5ff1 tests: fping checks require being root or setuid root
on the fping binary. Check this before running the test.

Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-13 15:23:18 +02:00
Sven Nierlein
fb89accaaa require at least HTTP::Daemon 6.01
since the test uses send_header from HTTP::Daemon::ClientConn which has been introduced in
HTTP::Daemon 6.01
2014-06-13 14:01:12 +02:00
Sven Nierlein
c5a6c5136a tests: testCmd has own timeout which overwrites local one
so add configurable/optional timeout to testCmd.

Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-12 13:56:48 +02:00
Sven Nierlein
3529d7465d tests: parts of the check_procs test only work when uid -2 exists
skip those tests if the uid does not exist

Signed-off-by: Sven Nierlein <Sven.Nierlein@consol.de>
2014-06-12 11:45:49 +02:00
Holger Weiss
083952c426 Fix compilation with GnuTLS
GnuTLS doesn't provide a SSL_CTX_check_private_key() function.

Closes #1254.
2014-06-12 00:02:26 +02:00
Gunnar Beutner
1b3890572e Make check_disk work on Windows. 2014-04-27 19:59:06 +02:00
Gunnar Beutner
5e03bd8e8c Make check_users work on Windows. 2014-04-27 19:59:06 +02:00
Gunnar Beutner
e0af39d7e9 Make check_ping work on Windows. 2014-04-27 19:59:06 +02:00
Anton Lofgren
4e0da0216d check_snmp: Handle SNMPv3 noAuthNoPriv properly
The SNMPv3 noAuthNoPriv security level, somewhat unintuitively, requires
a security name to be passed along together with the request. Check_snmp
previously did not do this, causing snmpget to throw an error:

"External command error: No log handling enabled - turning on stderr
logging
snmpget: No securityName specified"

This patch fixes the issue by always providing the security name when
noAuthNoPriv is specified.

See also:
https:://bugs.op5.com/view.php?id=8385.

Signed-off-by: Anton Lofgren <alofgren@op5.com>
2014-04-24 08:49:54 +02:00
Sam Kottler
c887890e9f Remove the suggestion to run check_apt with --verbose since it doesn't do anything 2014-04-04 16:55:59 +06:00