Sven Nierlein
6fde27e478
check_ntp(_time): don't die on connect errors
...
connect errors may happen if clients check agains dual
stacked ipv4/6 ntp servers.
2012-11-28 13:51:16 +01:00
Sven Nierlein
24772e755e
unified ipv4/6 usage and help text
2012-11-28 11:03:11 +01:00
Anders Kaseorg
028d50d6f9
Die when asprintf fails
...
Fixes many instances of
warning: ignoring return value of 'asprintf', declared with attribute warn_unused_result [-Wunused-result]
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2012-06-29 13:39:11 +02:00
Thomas Guyot-Sionnest
eaf3cb27f4
Add newline after "Usage:" in --help
2010-04-22 08:57:14 -04:00
Thomas Guyot-Sionnest
884aee0667
Standardize the extra-opts notes
2010-04-21 23:29:18 -04:00
Thomas Guyot-Sionnest
25d1ee331d
Fix translations when extra-opts aren't enabled
...
Bug #2832884 reported problem with translations outputting pot file
headers. This is caused by "" matching the header of the translation
files.
This patch moves gettext macros inside utils macros and update some
french translations.
2010-04-14 08:33:06 -04:00
Thomas Guyot-Sionnest
b649333321
Update french translation (fix all fuzzy's)
2010-04-14 05:48:41 -04:00
Thomas Guyot-Sionnest
6fbd14fea5
Removing CVS/SVN tags and replacing with git-based versioning
...
For contrib/, full tags have been imported from subversion
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2091 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-23 05:38:47 +00:00
Thomas Guyot-Sionnest
caa8bd6423
Bulk EOL cleanup
...
$ git diff --ignore-space-change|diffstat
0 files changed
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2087 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-19 06:45:18 +00:00
Thomas Guyot-Sionnest
16f53e0717
Fixed buffer overflow in check_ntp/check_ntp_peer ( #1999319 , Ubuntu #291265 )
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2086 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-19 05:59:33 +00:00
Thomas Guyot-Sionnest
44f8455b2c
Added support for --extra-opts in all C plugins (disabled by default, see configure --help)
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1991 f882894a-f735-0410-b71e-b25c423dba1c
2008-05-07 10:02:42 +00:00
Thomas Guyot-Sionnest
dbd7b90170
Use UT_THRESHOLDS_NOTES in all plugins
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1986 f882894a-f735-0410-b71e-b25c423dba1c
2008-04-29 09:01:48 +00:00
Thomas Guyot-Sionnest
ed62784a0b
--help output cleanup (plus removal of spaces on blank lines)
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1984 f882894a-f735-0410-b71e-b25c423dba1c
2008-04-27 14:35:26 +00:00
Thomas Guyot-Sionnest
b12edc52d6
check_ntp and check_ntp_peer now show proper jitter/stratum thresholds longopts in --help
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1977 f882894a-f735-0410-b71e-b25c423dba1c
2008-04-05 08:02:47 +00:00
Thomas Guyot-Sionnest
fa4efcdf6d
Bump plugins/ to GPLv3 (check_apt to check_nwstat)
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1916 f882894a-f735-0410-b71e-b25c423dba1c
2008-01-30 10:53:47 +00:00
Thomas Guyot-Sionnest
34cfb0c103
Fix bugs and flaws in best offset server selection of check_ntp_time and (deprecated) check_ntp
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1909 f882894a-f735-0410-b71e-b25c423dba1c
2008-01-29 08:54:48 +00:00
Thomas Guyot-Sionnest
b5d3997aa3
Fix Bug #1862300 : check_ntp_time segfault in 1.4.11 (Also apply to check_ntp)
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1887 f882894a-f735-0410-b71e-b25c423dba1c
2008-01-05 14:09:29 +00:00
Thomas Guyot-Sionnest
56c9db8516
Adding missing function calls needed for i18n (only for plugins already in POTFILES.in)
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1861 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-11 05:57:35 +00:00
Thomas Guyot-Sionnest
c1b08bca7b
OOPS! Last commit should have included these files.
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1858 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-10 04:00:40 +00:00
Thomas Guyot-Sionnest
6bf37c8cf6
missing word in comment block.
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1838 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-04 11:14:36 +00:00
Thomas Guyot-Sionnest
ef999f8f45
- Use max_state_alt in check_ntp to fix some issues with the latest commits.
...
- Roll back the stratum check as there were issues with it and a better one is already implemented in check_ntp_peer (about to be included)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1830 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-23 04:21:09 +00:00
Thomas Guyot-Sionnest
b24243c2d9
Fix newly added stratum check (has to be decreased by one when using normal NTP packets versus control packets)
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1822 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-10 17:37:11 +00:00
Thomas Guyot-Sionnest
2acc26005c
check_ntp now return UNKNOWN instead of WARNING if jitter is
...
unavailable. If no offset threshold is specified and
the offset is unavailable, will return UNKNOWN as well.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1811 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-25 21:06:08 +00:00
Thomas Guyot-Sionnest
474d1713ce
Add stratum thresholds support for check_ntp (feature request #1703823 )
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1806 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-11 04:21:27 +00:00
Thomas Guyot-Sionnest
998bb7dc4b
Use provided threshold functions (no functionnal change apart the check for overlaping thresholds)
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1805 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-11 02:56:17 +00:00
Thomas Guyot-Sionnest
0b66867288
Patch #1798774 : check_ntp: honor ntp flags
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1799 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-26 04:16:21 +00:00
Matthias Eble
06372d2d91
check_ntp: Fixed typo in typo in argument sanity check. Thanks to Aurelien Bompard ( #1753506 )
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1756 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-14 18:30:21 +00:00
Thomas Guyot-Sionnest
05ef3c4bd9
- Fix possibility of printing scientific numbers in perfdata
...
- Use fperfdata function for perfdata formatting
- Make the printing part a bit more flexible (similar to check_disk)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1678 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-10 07:17:18 +00:00
Thomas Guyot-Sionnest
cff02b30d5
Fix for getting dispersion instead of jitter on older servers (like xntpd on Solaris).
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1676 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-04 20:08:59 +00:00
Holger Weiss
b19f0704f3
Fix the synchronization source selection on big-endian systems.
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1675 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-03 17:19:04 +00:00
Thomas Guyot-Sionnest
fd440b64a6
Temporary fix for jitter calculation
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1674 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-03 01:31:25 +00:00
Holger Weiss
dcbf7bdf6b
Don't rely on the assumption that the size of a READSTAT response is a
...
multiple of sizeof(ntp_assoc_status_pair).
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1673 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-02 12:39:30 +00:00
Thomas Guyot-Sionnest
3315c3f25e
Fix byte order in verbose logging
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1671 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-02 07:32:30 +00:00
Thomas Guyot-Sionnest
7856e1ba2b
Seems like we don't get any jitter sometimes. While this needs to be fixed we should at least handle it gracefully.
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1670 f882894a-f735-0410-b71e-b25c423dba1c
2007-04-02 06:00:59 +00:00
Holger Weiss
cedc77a0ae
Fix an out-of-bounds memcpy(3) and add a realloc(3) error check in
...
jitter_request().
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1666 f882894a-f735-0410-b71e-b25c423dba1c
2007-03-31 18:48:17 +00:00
Holger Weiss
eac5cdc26f
Add a warning to the verbose output if jitter_request() found no
...
synchronization source.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1665 f882894a-f735-0410-b71e-b25c423dba1c
2007-03-31 17:35:08 +00:00
Holger Weiss
7770530829
Avoid division by zero.
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1664 f882894a-f735-0410-b71e-b25c423dba1c
2007-03-31 17:29:50 +00:00
Holger Weiss
180ce88b3f
Remove the '-O' option, as it's ignored.
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1663 f882894a-f735-0410-b71e-b25c423dba1c
2007-03-31 17:25:43 +00:00
Ton Voon
a77626cb62
Adding help text for jitter flags
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1651 f882894a-f735-0410-b71e-b25c423dba1c
2007-03-29 10:25:01 +00:00
Holger Weiss
fd329a1e91
Don't try to print `optarg' (which will be a NULL pointer) if an unknown
...
command line option was used, as this leads to a segfault on some
systems. The unknown option will be printed by getopt(3) anyway. So,
simply call print_usage() and exit UNKNOWN via the new usage5() instead.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1590 f882894a-f735-0410-b71e-b25c423dba1c
2007-01-28 21:46:41 +00:00
M. Sean Finney
3b5742d0b9
compilation fixes for check_ntp.c:
...
- check_ntp.c:290: warning: overflow in implicit constant conversion
fixed with an explicit cast to int8_t.
- check_ntp.c:544: warning: pointer of type âvoid *â used in arithmetic
fixed by casting to ptrdiff_t before arithmetic and (void*) afterwards
- in TVtoNTP64, cast arithmetic result passed to R32 as uint64_t.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1571 f882894a-f735-0410-b71e-b25c423dba1c
2007-01-20 10:59:25 +00:00
Benoit Mortier
082cfc29e3
first pass at cleaning localization for new release
...
first pass at making all the headre be the same licence, plugin, etc...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1499 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-19 00:25:16 +00:00
Ton Voon
caaf4be9b6
Removed extraneous comma in perf data output
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1492 f882894a-f735-0410-b71e-b25c423dba1c
2006-10-12 14:22:57 +00:00
Ton Voon
0c2be6a608
Catch no responses from any server (1538341 - nmdias)
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1467 f882894a-f735-0410-b71e-b25c423dba1c
2006-08-11 08:26:34 +00:00
Benoit Mortier
cbbfed30eb
cleaning up help and usage
...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1433 f882894a-f735-0410-b71e-b25c423dba1c
2006-06-17 12:28:43 +00:00
M. Sean Finney
e667553b97
- check_ntp:
...
- now roughly feature-complete.
- various bugfixes, esp. offset calculation.
- enhanced the asynchronous offset polling to set requests that
haven't recieved a response in >= 1 second to stale and retransmit them,
which results in much better performance on unreliable networks.
- we only spend timeout/2 seconds polling offsets, and if we don't get
everything by that point we work with what we have and set status to
warning/critical depending on how much data we have.
- set the same defaults as the perl script.
- commit changes to configure.in to support automatic building of check_apt
(if apt-get is installed and regex libraries available) and check_ntp
(unconditionally), now defaulting to check_ntp.c instead of the perl script.
if this is an issue we can back out the commit of course. an eye
should be kept on check_ntp building and running correctly in different
environments, esp. 64-bit and big-endian platforms, and those with more
"esoteric" API's (do any of the platforms not have poll()?).
- similar changes to Makefile.am's.
- common.h: add statement to include sys/poll.h
- runcmd.c: exit STATE_UNKNOWN if execve() fails.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1386 f882894a-f735-0410-b71e-b25c423dba1c
2006-05-01 21:52:42 +00:00
M. Sean Finney
1b207c0b27
the offset_requests are now parallelized. still stuff needs to be
...
done (conveniently marked with XXX), but on well behaving networks
the plugin should behave more or less identical to check_ntp.pl now.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1373 f882894a-f735-0410-b71e-b25c423dba1c
2006-04-12 10:00:23 +00:00
M. Sean Finney
35f52fe9a8
added a currently unused but "good for reference" version of offset_request
...
which attempts to behave more like ntpdate, but this doesn't yet and
the code isn't actually used yet.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1372 f882894a-f735-0410-b71e-b25c423dba1c
2006-04-12 06:33:14 +00:00
M. Sean Finney
077a1f6a51
another big code-commit to check_ntp. jitter calculations now work, and
...
the program is becoming much closer on the packet-for-packet level to
how check_ntp.pl behaves. i'll send an email in the morning :)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1371 f882894a-f735-0410-b71e-b25c423dba1c
2006-04-11 23:24:07 +00:00
M. Sean Finney
8250d65061
- shuffling some code around to keep things tidy.
...
- now average the result of 4 queries just as ntpdate does
- put things in place for jitter calculation
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1332 f882894a-f735-0410-b71e-b25c423dba1c
2006-03-20 22:06:07 +00:00