Commit graph

942 commits

Author SHA1 Message Date
Thomas Guyot-Sionnest
b5f11055dc Merge more changes from trunk
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1845 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-04 12:33:00 +00:00
Thomas Guyot-Sionnest
c1418c9daf Comment (Fixed in trunk already)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1844 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-04 12:28:50 +00:00
Thomas Guyot-Sionnest
084a9b444f Cleanups only
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1842 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-04 12:24:48 +00:00
Thomas Guyot-Sionnest
d358f1cc95 Add a quiet mode to avoid notification when NTP server isn't sync (check_ntp_peer and heck_ntp_time)
Fix default jitter and stratum ranges not including -1


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1840 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-04 12:08:34 +00:00
Thomas Guyot-Sionnest
6157cdf6e5 Small cleanups
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1839 f882894a-f735-0410-b71e-b25c423dba1c
2007-12-04 11:18:40 +00:00
Thomas Guyot-Sionnest
20470f273a Safer handling of te data pointer...
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1837 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-27 13:52:38 +00:00
Thomas Guyot-Sionnest
ef1f4e1e69 Fix bug introduced in last commit: jitter and stratum must be initialized at the begining (and /me must have some rest now).
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1836 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-26 10:34:43 +00:00
Thomas Guyot-Sionnest
ef1863eed9 - fix segfault in extract_value called with no data (should never happen though)
- Will now retry with empty getvar request if all else fail and parse what it can
- check_ntp used to get the average of all candidates of there's no sync peer. Average of a clock offset isn't obvious, so it gets the offset, jitter and stratum of the best candidate (based of current ooffset)
- Various fixes
- check conversion of stratum (using strtol instead of atoi)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1835 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-26 10:23:25 +00:00
Thomas Guyot-Sionnest
986d0ecf36 More refined check, clearer messages
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1834 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-26 07:53:30 +00:00
Thomas Guyot-Sionnest
04a8b31d19 comments and notes
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1833 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-23 22:06:28 +00:00
Thomas Guyot-Sionnest
97131650ea Rename check_ntp* and merge change in Trunk
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1832 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-23 21:47:04 +00:00
Thomas Guyot-Sionnest
643e6a0a4f [1/2] Rename (plus some minor modifications)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1831 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-23 21:38:53 +00:00
Thomas Guyot-Sionnest
cbae6033d1 New tests!! + single file to test all three plugins (Can be split again if ppl prefer that).
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1826 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-10 22:55:46 +00:00
Thomas Guyot-Sionnest
05f9bbfdc2 Cleanup check_time_ntp.c (and some small cleanups on check_ntpd.c as well)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1825 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-10 22:13:43 +00:00
Thomas Guyot-Sionnest
6ea43dd18e More cleanups, some fixes
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1824 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-10 21:22:58 +00:00
Thomas Guyot-Sionnest
a22c1454b6 Commiting current work (check_ntpd.c mainly completed, check_time_ntp.c not started yet)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1823 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-10 17:42:44 +00:00
Thomas Guyot-Sionnest
cecee3b342 Just a copy (for now)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/branches/dermoth_ntp_rework@1821 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-10 17:20:34 +00:00
Thomas Guyot-Sionnest
7a05ad0166 Moved base64 function to /lib.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1817 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-09 21:17:03 +00:00
Thomas Guyot-Sionnest
d2f758c5ee Fix check_snmp buffer overflow (CVE-2007-5623)
This patch comes from the Gentoo Portage tree but I couldn't find the author. I sent an email and will give credits when I get an answer.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1814 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-09 16:05:48 +00:00
Thomas Guyot-Sionnest
2562434648 Close the socket on all exits (not just the OK one)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1813 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-09 13:08:43 +00:00
Thomas Guyot-Sionnest
dca25be31a Fix missing \n in --help output
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1812 f882894a-f735-0410-b71e-b25c423dba1c
2007-11-09 13:06:32 +00:00
Thomas Guyot-Sionnest
2acc26005c check_ntp now return UNKNOWN instead of WARNING if jitter is
unavailable. If no offset threshold is specified and
the offset is unavailable, will return UNKNOWN as well.



git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1811 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-25 21:06:08 +00:00
Ton Voon
cf0dee616a Automatically update website with --help output. Cosmetic
fixes for some help output


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1810 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-25 20:43:04 +00:00
Holger Weiss
745b58a68b Hide the SNMP community string (and v3 passwords) from error messages
(Bernhard Fischer on nagiosplug-devel@)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1809 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-24 15:08:34 +00:00
Holger Weiss
b9548623f8 Fix a possible segfault if using "-f follow" and the server sends a
forged "LLLLocation" header prefixed with multiple "L"s (fabiodds -
1813346)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1807 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-14 22:19:29 +00:00
Thomas Guyot-Sionnest
474d1713ce Add stratum thresholds support for check_ntp (feature request #1703823)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1806 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-11 04:21:27 +00:00
Thomas Guyot-Sionnest
998bb7dc4b Use provided threshold functions (no functionnal change apart the check for overlaping thresholds)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1805 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-11 02:56:17 +00:00
Holger Weiss
604da49392 Fix regression in 1.4.10 where following redirects to relative URLs on
virtual hosts failed if both "-H" and "-I" were specified (noted by
Rodrigo A. G. Schichaschwili on nagiosplug-devel@)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1804 f882894a-f735-0410-b71e-b25c423dba1c
2007-10-02 13:51:41 +00:00
Holger Weiss
faf593d23a Drop the weird and undocumented behaviour of using positional argument
parsing instead of getopt(3) if 8 command line arguments were given (as
suggested by Matthias) and check whether all required arguments have
been specified in order to spit out proper error messages and to avoid a
possible segfault (as suggested by Thomas).


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1800 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-26 10:57:44 +00:00
Thomas Guyot-Sionnest
0b66867288 Patch #1798774: check_ntp: honor ntp flags
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1799 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-26 04:16:21 +00:00
Holger Weiss
0b579a3456 Let ./configure --without-ipv6 suppress non-IPv4 DNS lookups (noted by
Mark Frost on nagios-users@)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1794 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-24 00:30:14 +00:00
Matthias Eble
6483a72b16 Removed some c99 style comments
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1793 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-23 12:29:36 +00:00
Matthias Eble
e8d6f41fad Added multiline output capability to check_by_ssh. Thanks to Matthias Flacke (#1769653)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1792 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-23 12:26:03 +00:00
Matthias Eble
9e64dc2d7f Fixed bug: stat was called on remote fs even if -l was given
Added -L option to call stat on remote fs but without threshold comparison


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1789 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-23 10:58:09 +00:00
Matthias Eble
d1c9a5cf6a Added radiusclient-ng support for check_radius. Thanks to Sebastien Guay (#1218438)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1788 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-23 09:48:37 +00:00
Matthias Eble
bb32ecb79c substituted bool/true/false with int/TRUE/FALSE (discussed on np-devel)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1787 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-22 17:48:33 +00:00
Matthias Eble
d23b17e656 Added -i/-I to ignore pathes/partitions based on regular expressions
Added check_disk -A selecting all filesystems 
-E option must now be passed before -p or -r/-R
Passing -E after -p or -r results in UNKNOWN state
Fixed bug when mixing case sensitive and insensitive regexes


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1786 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-22 17:40:35 +00:00
Thomas Guyot-Sionnest
520f297fa9 Rewrite the "map changes to return codes" patch nearly from scratch.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1785 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-22 03:00:46 +00:00
Ton Voon
8a39526e1b Stop double expansion of parameters for negate - works like
time command now


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1784 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-21 23:01:28 +00:00
Thomas Guyot-Sionnest
7a70525129 My solaris box needs %llu to display 64bits integers.
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1783 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-21 05:05:58 +00:00
Thomas Guyot-Sionnest
5ca8c84715 - Added some variables at verbose==3
- Removed support for verbose<0 (-q). -q was broken and tried to to the same as -e.
- -q in now an undocumented alias of -e (for backward-compatibility).
NB: Long help text for -d was already missing.
- Reordered the switches so that:
    a. less-important ones are in alphabetical order
    b. short and long help orders match.
- Enclosed "-p | -x" inside braces instead of brackets as one or the other is required.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1782 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-21 04:59:15 +00:00
Holger Weiss
05a980ba4b Properly handle SMTP server responses which are split into multiple
packets (noted by Chris Adams on nagiosplug-help@).  TODO: The new
recvline()/recvlines() functions should buffer received data instead of
reading one byte at a time and they should be moved to netutils.c so
that other plugins can use them, too.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1780 f882894a-f735-0410-b71e-b25c423dba1c
2007-09-15 14:25:56 +00:00
Holger Weiss
da6aa00a83 Don't use C++ style comments (noted by Johannes Kingma on
nagiosplug-help@)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1770 f882894a-f735-0410-b71e-b25c423dba1c
2007-08-09 12:32:28 +00:00
Holger Weiss
0616123167 Read the response to an SMTP QUIT command before closing the socket
(noted by Dieter Hendricks on nagiosplug-help@)


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1769 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-31 14:47:04 +00:00
Ton Voon
37287823f0 Removing all .cvsignore files
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1761 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-24 00:35:42 +00:00
Holger Weiss
475ee7b55a Add "Connection: close" to the HTTP request header, which tells HTTP/1.1
servers to close the connection after completion of the response.  This
should be compatible with HTTP/1.0, as HTTP/1.0 allows for custom header
fields which should be ignored if not recognized by the server.  With
some server configurations, the server would keep the connection alive
without this header line (despite the plugin requesting HTTP/1.0),
resulting in the plugin running into either the server's or it's own
timeout (reported by Roman Schliessmeyer and Jesse Morgan via IRC).


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1759 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-21 16:29:01 +00:00
Matthias Eble
d77b785d23 Make ps column count in zombie detection less restrictive. Thanks to Andrew Elwell (#1280470)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1758 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-15 15:21:51 +00:00
Matthias Eble
c134205981 Fixed segfault in argument processing. Thanks to Christoph Schell (#1742066)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1757 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-14 19:36:48 +00:00
Matthias Eble
06372d2d91 check_ntp: Fixed typo in typo in argument sanity check. Thanks to Aurelien Bompard (#1753506)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1756 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-14 18:30:21 +00:00
Matthias Eble
aca23c4640 Added examples for new features to check_disk
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@1755 f882894a-f735-0410-b71e-b25c423dba1c
2007-07-10 20:45:48 +00:00