Commit graph

166 commits

Author SHA1 Message Date
Ton Voon
1749ff0147 Add test files 2010-06-23 14:15:28 +01:00
Ton Voon
9ff89b1a99 Added np_set_args, to set arguments after np_extra_opts has been run 2010-06-22 11:47:54 +01:00
Ton Voon
10364a6004 Invalid chars in keyname now die() 2010-06-21 22:40:29 +01:00
Ton Voon
72074a8f2e Use AM_CPPFLAGS instead of DEFS as per autoconf documentation 2010-06-21 21:07:40 +01:00
Ton Voon
9de4938ba8 Use NP_STATE_DIR_PREFIX as compile variable 2010-06-21 20:43:33 +01:00
Ton Voon
bc9c95bdf4 Check return codes from malloc and strdup 2010-06-21 16:24:41 +01:00
Ton Voon
833fd7ca04 Added sha1 from gnulib. Also filled out _np_state_generate_key() 2010-06-21 15:19:50 +01:00
Ton Voon
29cf8ff2fe Convert bad chars to underscore 2010-06-21 13:31:21 +01:00
Ton Voon
602896277c Change np_state_write_string() to not be a pointer 2010-06-21 13:03:24 +01:00
Ton Voon
f58aa8e66b Implemented writes to state file 2010-06-18 17:34:24 +01:00
Ton Voon
68eb836e52 More tests 2010-06-18 14:45:02 +01:00
Ton Voon
62c9525669 np_init() with this_nagios_plugin 2010-06-17 23:18:17 +01:00
Ton Voon
17f96bc145 Added calculate location directory 2010-06-17 11:11:57 +01:00
Ton Voon
301599a4ec Add skeleton tests 2010-06-17 10:57:59 +01:00
Ton Voon
95b190f3de Added skeleton 2010-06-17 10:16:43 +01:00
Thomas Guyot-Sionnest
6e5d12b5d0 Use a more "natural" way of writing argument lists in extra-opts tests. 2009-06-11 00:14:23 -04:00
Holger Weiss
9eabd8d054 Fix the memory allocation for the thresholds data
Allocate the appropriate amount of memory for storing the thresholds
data.  Before, we allocated the amount of memory required for storing a
_pointer_ to the thresholds data.  This crashed (at least) check_mysql
when using its "-S" option on FreeBSD/amd64 (as reported and analyzed by
Nikita Kalabukhov - 2797757).

Signed-off-by: Holger Weiss <holger@zedat.fu-berlin.de>
2009-06-02 01:11:19 +02:00
Thomas Guyot-Sionnest
7cb3ae0933 check_snmp: Make use of standard threshold functions
This patch makes use of standard threshold functions. This allows using
	doubles as thresholds.

	Since SNMP supports only integers, double precision numbers are only
	printed when parsed from a STRING type.

	In addition, support for printing properly Timeticks type has been added,
	and the code has been thoroughly cleaned.
2009-05-28 08:10:49 -04:00
Thomas Guyot-Sionnest
ba132e9e52 Make extract_value more generic:
Add a separator argument passed using defines.
2009-01-26 02:05:21 -05:00
Thomas Guyot-Sionnest
0a74b6fda0 Remove the commented out blocks
The die tests are implemented in the test_*3.t files
2009-01-24 07:41:45 -05:00
Thomas Guyot-Sionnest
1b1dc7a48b Fix paths in test_ini tests 2009-01-24 00:41:00 -05:00
Thomas Guyot-Sionnest
8b103c0c77 Add die tests for parse_ini 2009-01-23 02:43:59 -05:00
Thomas Guyot-Sionnest
485f306868 Return UNKNOWN if none of the default files can be found.
It makes no sense to return unknown if an implicit section is not found, but
go on if the file is missing
2009-01-22 02:24:39 -05:00
Thomas Guyot-Sionnest
bf4abd5395 Add die tests for extra-opts 2009-01-22 02:04:31 -05:00
Thomas Guyot-Sionnest
a4647be424 Move check_ntp's extract_value to utils_base.c.
This function can also be used to parse performance data strings which
could be useful in the future.
2009-01-21 01:27:40 -05:00
Thomas Guyot-Sionnest
81871eaa82 Accidentally included built executables - also updated .gitignore 2009-01-21 01:25:06 -05:00
Thomas Guyot-Sionnest
3b69f13467 Some platform are missing setenv
Instead of adding the gnulib module for solving tests only I split the test
in two, setting environment from Perl for the later.
2009-01-20 23:58:02 -05:00
Thomas Guyot-Sionnest
26bf63a5bb Fix (or try at least) for IRIX compile to tap tests
Gnulib says: "$(LTLIBINTL) when linking with libtool, $(LIBINTL) otherwise"
Everywhere else we use LTLIBINTL so I assume the tests should use it as well.
2009-01-20 22:28:30 -05:00
Thomas Guyot-Sionnest
82674792c7 Re-apply "Cleanup; fix the way libraries are linked; Make-It-Simple(tm)"
This reverts commit 7449b16b17.
2009-01-18 16:26:58 -05:00
Thomas Guyot-Sionnest
09f9ddd18d Typo 2009-01-15 06:12:04 -05:00
Thomas Guyot-Sionnest
301871bd6f Make /lib before /lib/tests to satisfy dependencies (building tests fails on IRIX) 2009-01-13 04:31:30 -05:00
Thomas Guyot-Sionnest
f8c6d8b52e Fix test from last commit 2009-01-09 08:16:52 -05:00
Thomas Guyot-Sionnest
4d5eb82a47 basename check in test_utils.c was accidentaly added again.
In 538b97c I reverted a serie of libtap patch by Ton Voon; it included
the removal of the useless basename check.

Relevant portion of the changelog from which it was removed (f31cd40):

  Removed basename test as we should use base_name from GNUlib which is
	tested separately
2009-01-09 02:44:36 -05:00
Thomas Guyot-Sionnest
7449b16b17 Revert "Cleanup; fix the way libraries are linked; Make-It-Simple(tm)"
Trying to see if this has any relation to the tinderbox failure. I doubt it
and will revert back as soon as it's tested.

This reverts commit a97e5fbda2.
2009-01-09 02:27:02 -05:00
Thomas Guyot-Sionnest
254baca111 Try to make IRIX happy (this fixes a similar warning in Solaris) 2009-01-08 08:14:19 -05:00
Thomas Guyot-Sionnest
a97e5fbda2 Cleanup; fix the way libraries are linked; Make-It-Simple(tm)
lib/Makefile.am       |    2 +-
 lib/tests/Makefile.am |   37 ++++---------------------------------
 2 files changed, 5 insertions(+), 34 deletions(-)
2009-01-07 04:41:54 -05:00
Thomas Guyot-Sionnest
2bbf2e6967 Add Libtap as a bundled library (does not change any behaviour without --enable-libtap)
Detects system library as pre-1.4.13 and does not install the built-in library anymore

Tested on:
  - Linux x86_64, with and without local libtap (System libtap installed)
	- Linux x86, with and without local libtap (System libtap NOT installed)
  - Solaris SPARC, with and without local libtap, with and without system libtap installed
2008-11-29 04:38:54 -05:00
Thomas Guyot-Sionnest
538b97cea6 Revert inclusion of libtap into nagiosplugins
(except for the NEWS file)

This reverts the following commits (latest first): f3e0909, 9f16b54, be8df51, f31cd40, 5270c7d, a25083f, f1bfe40, c503d85 and 6c476db
2008-11-28 03:22:39 -05:00
Thomas Guyot-Sionnest
6fbd14fea5 Removing CVS/SVN tags and replacing with git-based versioning
For contrib/, full tags have been imported from subversion


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2091 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-23 05:38:47 +00:00
Thomas Guyot-Sionnest
caa8bd6423 Bulk EOL cleanup
$ git diff --ignore-space-change|diffstat
 0 files changed


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2087 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-19 06:45:18 +00:00
Thomas Guyot-Sionnest
5305852212 check_disk: rerpopulate the mount list after doing a stat() on paths specified with -p for better automount support.
NB: There's a memory leak here - properly freeing the mount list would invlove
    much more work - there's many other places where leaks can happen so it
    should be a project on its own.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2085 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-19 05:59:22 +00:00
Ton Voon
a688e9338a Need to add in the libgnu.la for Solaris and other platforms
where missing functions have been replaced by GNUlib


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2071 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-05 17:07:40 +00:00
Thomas Guyot-Sionnest
3011838fe9 Fix calculation of extra-opts parameters.
By reading the current list instead of the additional one when counting parameters, extra-opts calculation was allocating insuficient space for the final array if later sections contained more arguments than the sum of all previously parsed sections.


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2069 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-05 16:15:59 +00:00
Thomas Guyot-Sionnest
cca36dc245 Fixed the test (not the bug yet) and added similar one to test_ini (that one works)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2066 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-04 21:52:45 +00:00
Thomas Guyot-Sionnest
83ec9f2694 Corrected test_opts plan
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2065 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-04 21:31:10 +00:00
Thomas Guyot-Sionnest
5847c4eb83 Adding extra-opts check that crash on my prod servers (*** glibc detected *** malloc(): memory corruption: 0x0804e248 ***)
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2064 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-04 21:29:36 +00:00
Thomas Guyot-Sionnest
51ec51a8dc Make extra-opts (C plugins) behave more like N::P:
N::P allows both '#' and ';' for comments. Extra-opts used to allow only '#', it now allows both (';' is the standard for ini files)
  Extra-opts does not allow trailing comments anymore (like N::P)



git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2063 f882894a-f735-0410-b71e-b25c423dba1c
2008-11-04 17:41:53 +00:00
Ton Voon
f31cd40f7a Correctly link to included libtap. Simplify invoking test scripts.
Removed basename test as we should use base_name from GNUlib which is
tested separately


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2042 f882894a-f735-0410-b71e-b25c423dba1c
2008-08-21 15:18:58 +00:00
Thomas Guyot-Sionnest
77362a18ba Typos in comments
git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2035 f882894a-f735-0410-b71e-b25c423dba1c
2008-08-21 04:17:25 +00:00
Ton Voon
b93562e6e2 check_procs captures stderr and adds to plugin output. This is
from a merge of branch nagiosplug/branches/new_threshold_syntax 1979:1982


git-svn-id: https://nagiosplug.svn.sourceforge.net/svnroot/nagiosplug/nagiosplug/trunk@2019 f882894a-f735-0410-b71e-b25c423dba1c
2008-07-08 09:31:04 +00:00