check_oracle: --tns bad string matching

check_oracle in the 1.4.15 release doesn't correctly parse the output gotten
from at least Oracle 11 (with german locales). I guess it's probably more.
Also it completely needlessly uses sed where basic bash string parsing actually
does more than suffice (and does not run into possible problems with locales
like sed ;)).
--
Just turning attached patch of github issue #1015 into a push request.
(Closes #1015 and #1191)
This commit is contained in:
Jan Wagner 2013-10-01 14:59:35 +02:00
parent 50cad9ae5d
commit d8b81e9ef3
2 changed files with 2 additions and 1 deletions

View file

@ -323,3 +323,4 @@ Eric J. Mislivec
Jean-Claude Computing
Andy Brist
Mikael Falkvidd
Frederic Krueger

View file

@ -137,7 +137,7 @@ case "$cmd" in
tnschk=` tnsping $2`
tnschk2=` echo $tnschk | grep -c OK`
if [ ${tnschk2} -eq 1 ] ; then
tnschk3=` echo $tnschk | sed -e 's/.*(//' -e 's/).*//'`
tnschk3=${tnschk##*(}; tnschk3=${tnschk3%)*}
echo "OK - reply time ${tnschk3} from $2"
exit $STATE_OK
else