upstream/monitoring-plugins
1
0
Fork 0
mirror of https://github.com/monitoring-plugins/monitoring-plugins.git synced 2026-06-09 08:42:17 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #2133 from rlaager/fix-check_ssh-buffer-overflow

Browse source 
Fix check ssh buffer overflow
This commit is contained in:
Lorenz Kästle 2025-08-01 14:27:48 +02:00 committed by GitHub
commit b05087d9aa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
plugins/check_ssh.c
View file

@ -255,7 +255,7 @@ int ssh_connect(mp_check *overall, char *haddr, int hport, char *desired_remote_
byte_offset = 0;
char *index = NULL;
unsigned long len = 0;
size_t len = 0;
while ((index = strchr(output + byte_offset, '\n')) != NULL) {
/*Partition the buffer so that this line is a separate string,
* by replacing the newline with NUL*/
@ -273,12 +273,14 @@ int ssh_connect(mp_check *overall, char *haddr, int hport, char *desired_remote_
}
if (version_control_string == NULL) {
/* move unconsumed data to beginning of buffer, null rest */
memmove((void *)output, (void *)(output + byte_offset + 1), BUFF_SZ - len + 1);
memset(output + byte_offset + 1, 0, BUFF_SZ - byte_offset + 1);
/* move unconsumed data to beginning of buffer */
memmove((void *)output, (void *)(output + byte_offset), BUFF_SZ - byte_offset);
/*start reading from end of current line chunk on next recv*/
byte_offset = strlen(output);
/* NUL the rest of the buffer */
memset(output + byte_offset, 0, BUFF_SZ - byte_offset);
}
} else {
byte_offset += recv_ret;