upstream/monitoring-plugins
1
0
Fork 0
mirror of https://github.com/monitoring-plugins/monitoring-plugins.git synced 2026-06-08 16:26:23 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

check_snmp: Small improvements + fix dereference bug

Browse source
This commit is contained in:
Lorenz Kästle 2025-08-30 14:19:06 +02:00
parent 7f1877f760
commit a7c6760cfe
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
plugins/check_snmp.c
View file

@ -214,8 +214,7 @@ int main(int argc, char **argv) {
sc_oid_test.output = strdup("");
}
char oid_string[(MAX_OID_LEN * 2) + 1];
memset(oid_string, 0, (MAX_OID_LEN * 2) + 1);
char oid_string[(MAX_OID_LEN * 2) + 1] = {};
int oid_string_result =
snprint_objid(oid_string, (MAX_OID_LEN * 2) + 1, vars->name, vars->name_length);
@ -404,9 +403,11 @@ int main(int argc, char **argv) {
// Use oid for perdata label
pd_num_val.label = strdup(oid_string);
// TODO strdup error checking
} else if (config.test_units[loop_index].label != NULL ||
} else if (config.test_units[loop_index].label != NULL &&
strcmp(config.test_units[loop_index].label, "") != 0) {
pd_num_val.label = config.test_units[loop_index].label;
} else {
pd_num_val.label = config.test_units[loop_index].oid;
}
if (config.test_units[loop_index].unit_value != NULL &&