upstream/monitoring-plugins
1
0
Fork 0
mirror of https://github.com/monitoring-plugins/monitoring-plugins.git synced 2026-04-21 14:19:30 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

check_icmp: trigger help before anything important

Browse source
This commit is contained in:
Lorenz Kästle 2025-06-23 11:44:46 +02:00
parent 6ac0580a10
commit 8626d22fc5
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
plugins-root/check_icmp.c
View file

@ -353,6 +353,7 @@ check_icmp_config_wrapper process_arguments(int argc, char **argv) {
long int arg;
while ((arg = getopt_long(argc, argv, opts_str, longopts, NULL)) != EOF) {
switch (arg) {
case '4':
if (enforced_ai_family != AF_UNSPEC) {
crash("Multiple protocol versions not supported");
@ -369,6 +370,11 @@ check_icmp_config_wrapper process_arguments(int argc, char **argv) {
result.config.number_of_hosts++;
break;
}
case 'h': /* help */
// Trigger help here to avoid adding hosts before that (and doing DNS queries)
print_help();
exit(STATE_UNKNOWN);
break;
case 'v':
debug++;
break;
@ -490,10 +496,6 @@ check_icmp_config_wrapper process_arguments(int argc, char **argv) {
case 'V': /* version */
print_revision(progname, NP_VERSION);
exit(STATE_UNKNOWN);
case 'h': /* help */
print_help();
exit(STATE_UNKNOWN);
break;
case 'R': /* RTA mode */ {
get_threshold2_wrapper rta_th = get_threshold2(
optarg, strlen(optarg), result.config.warn, result.config.crit, const_rta_mode);