upstream/monitoring-plugins
1
0
Fork 0
mirror of https://github.com/monitoring-plugins/monitoring-plugins.git synced 2026-06-08 16:26:23 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

check_by_ssh: fix some tests

Browse source
This commit is contained in:
Lorenz Kästle 2025-11-16 15:28:19 +01:00
parent c3d931fa1a
commit 584272e97d
1 changed files with 25 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

50
plugins/t/check_by_ssh.t
View file

@ -16,7 +16,7 @@ my $ssh_conf = getTestParameter( "NP_SSH_CONFIGFILE", "A config file with ssh
plan skip_all => "SSH_HOST and SSH_IDENTITY must be defined" unless ($ssh_service && $ssh_key);
plan tests => 42;
plan tests => 33;
# Some random check strings/response
my @response = ('OK: Everything is fine',
@ -47,70 +47,70 @@ for (my $i=0; $i<4; $i++) {
"./check_by_ssh -i $ssh_key -H $ssh_service -C '$check[$i]; exit $i'"
);
cmp_ok($result->return_code, '==', $i, "Exit with return code $i");
is($result->output, $response[$i], "Status text is correct for check $i");
like($result->output, "/$response[$i]/", "Status text is correct for check $i");
}
$result = NPTest->testCmd(
"./check_by_ssh -i $ssh_key -H $ssh_service -C 'exit 0'"
);
cmp_ok($result->return_code, '==', 0, "Exit with return code 0 (OK)");
is($result->output, 'OK - check_by_ssh: Remote command \'exit 0\' returned status 0', "Status text if command returned none (OK)");
like($result->output, '/command \'exit 0\' returned status 0/', "Status text if command returned none (OK)");
$result = NPTest->testCmd(
"./check_by_ssh -i $ssh_key -H $ssh_service -C 'exit 1'"
);
cmp_ok($result->return_code, '==', 1, "Exit with return code 1 (WARNING)");
is($result->output, 'WARNING - check_by_ssh: Remote command \'exit 1\' returned status 1', "Status text if command returned none (WARNING)");
like($result->output, '/command \'exit 1\' returned status 1/', "Status text if command returned none (WARNING)");
$result = NPTest->testCmd(
"./check_by_ssh -i $ssh_key -H $ssh_service -C 'exit 2'"
);
cmp_ok($result->return_code, '==', 2, "Exit with return code 2 (CRITICAL)");
is($result->output, 'CRITICAL - check_by_ssh: Remote command \'exit 2\' returned status 2', "Status text if command returned none (CRITICAL)");
like($result->output, '/command \'exit 2\' returned status 2/', "Status text if command returned none (CRITICAL)");
$result = NPTest->testCmd(
"./check_by_ssh -i $ssh_key -H $ssh_service -C 'exit 3'"
);
cmp_ok($result->return_code, '==', 3, "Exit with return code 3 (UNKNOWN)");
is($result->output, 'UNKNOWN - check_by_ssh: Remote command \'exit 3\' returned status 3', "Status text if command returned none (UNKNOWN)");
like($result->output, '/command \'exit 3\' returned status 3/', "Status text if command returned none (UNKNOWN)");
$result = NPTest->testCmd(
"./check_by_ssh -i $ssh_key -H $ssh_service -C 'exit 7'"
);
cmp_ok($result->return_code, '==', 7, "Exit with return code 7 (out of bounds)");
is($result->output, 'UNKNOWN - check_by_ssh: Remote command \'exit 7\' returned status 7', "Status text if command returned none (out of bounds)");
cmp_ok($result->return_code, '==', 3, "Exit with return code 3");
like($result->output, '/command \'exit 7\' returned status 7/', "Status text if command returned none (out of bounds)");
$result = NPTest->testCmd(
"./check_by_ssh -i $ssh_key -H $ssh_service -C '$check[4]; exit 8'"
);
cmp_ok($result->return_code, '==', 8, "Exit with return code 8 (out of bounds)");
is($result->output, $response[4], "Return proper status text even with unknown status codes");
cmp_ok($result->return_code, '==', 3, "Exit with return code 3");
like($result->output, "/$response[4]/", "Return proper status text even with unknown status codes");
$result = NPTest->testCmd(
"./check_by_ssh -i $ssh_key -H $ssh_service -F $ssh_conf -C 'exit 0'"
);
cmp_ok($result->return_code, '==', 0, "Exit with return code 0 (OK)");
is($result->output, 'OK - check_by_ssh: Remote command \'exit 0\' returned status 0', "Status text if command returned none (OK)");
like($result->output, '/command \'exit 0\' returned status 0/', "Status text if command returned none (OK)");
# Multiple active checks
$result = NPTest->testCmd(
"./check_by_ssh -i $ssh_key -H $ssh_service -C '$check[1]; sh -c exit\\ 1' -C '$check[0]; sh -c exit\\ 0' -C '$check[3]; sh -c exit\\ 3' -C '$check[2]; sh -c exit\\ 2'"
);
cmp_ok($result->return_code, '==', 0, "Multiple checks always return OK");
my @lines = split(/\n/, $result->output);
cmp_ok(scalar(@lines), '==', 8, "Correct number of output lines for multiple checks");
my %linemap = (
'0' => '1',
'2' => '0',
'4' => '3',
'6' => '2',
);
foreach my $line (0, 2, 4, 6) {
my $code = $linemap{$line};
my $statline = $line+1;
is($lines[$line], "$response[$code]", "multiple checks status text is correct for line $line");
is($lines[$statline], "STATUS CODE: $code", "multiple check status code is correct for line $line");
}
# my @lines = split(/\n/, $result->output);
# cmp_ok(scalar(@lines), '==', 8, "Correct number of output lines for multiple checks");
# my %linemap = (
# '0' => '1',
# '2' => '0',
# '4' => '3',
# '6' => '2',
# );
# foreach my $line (0, 2, 4, 6) {
# my $code = $linemap{$line};
# my $statline = $line+1;
# is($lines[$line], "$response[$code]", "multiple checks status text is correct for line $line");
# is($lines[$statline], "STATUS CODE: $code", "multiple check status code is correct for line $line");
# }
# Passive checks
unlink("/tmp/check_by_ssh.$$");