upstream/monitoring-plugins
1
0
Fork 0
mirror of https://github.com/monitoring-plugins/monitoring-plugins.git synced 2026-02-20 00:10:09 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fixed testcases for check_snmp, check_ifstatus and check_ifoperstatus when no snmp community is specified

Browse source 
The checks for invalid/unavailable hosts need a complete command line.
They failed on hosts where no community was specified. Now, an invalid community is used so
the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway.
This commit is contained in:
Matthias Eble 2009-06-13 18:13:49 +02:00
parent 05b801284c
commit 38e20a1a33
3 changed files with 15 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugins-scripts/t/check_ifoperstatus.t
View file

@ -19,7 +19,7 @@ SKIP: {
my $host_snmp = getTestParameter( "NP_HOST_SNMP", "A host providing an SNMP Service", "localhost");
my $snmp_community = getTestParameter( "NP_SNMP_COMMUNITY",
"The SNMP Community string for SNMP Testing (pick default rather than 'none' when no snmp host is available)",
"The SNMP Community string for SNMP Testing",
"public");
my ($snmp_interface, $snmp_ifxtable);
@ -75,15 +75,17 @@ SKIP: {
}
# These checks need a complete command line. An invalid community is used so
# the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway
SKIP: {
skip "no non responsive host defined", 1 if ( ! $host_nonresponsive );
$res = NPTest->testCmd( "./$plugin -H $host_nonresponsive -C $snmp_community -k 1");
$res = NPTest->testCmd( "./$plugin -H $host_nonresponsive -C np_foobar -k 1");
cmp_ok( $res->return_code, '==', 1, "Exit WARNING with non responsive host" );
}
SKIP: {
skip "no invalid host defined", 2 if ( ! $hostname_invalid );
$res = NPTest->testCmd( "./$plugin -H $hostname_invalid -C $snmp_community -k 1");
$res = NPTest->testCmd( "./$plugin -H $hostname_invalid -C np_foobar -k 1");
cmp_ok( $res->return_code, '==', 3, "Exit UNKNOWN with invalid host" );
like($res->output, "/Unable to resolve.*$hostname_invalid/", "String matches unable to resolve.*$hostname_invalid");
}

8
plugins-scripts/t/check_ifstatus.t
View file

@ -19,7 +19,7 @@ SKIP: {
my $host_snmp = getTestParameter( "NP_HOST_SNMP", "A host providing an SNMP Service", "localhost");
my $snmp_community = getTestParameter( "NP_SNMP_COMMUNITY",
"The SNMP Community string for SNMP Testing (pick default rather than 'none' when no snmp host is available)",
"The SNMP Community string for SNMP Testing",
"public");
my $host_nonresponsive = getTestParameter( "NP_HOST_NONRESPONSIVE",
@ -49,15 +49,17 @@ SKIP: {
}
# These checks need a complete command line. An invalid community is used so
# the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway
SKIP: {
skip "no non responsive host defined", 1 if ( ! $host_nonresponsive );
$res = NPTest->testCmd( "./$plugin -H $host_nonresponsive -C $snmp_community");
$res = NPTest->testCmd( "./$plugin -H $host_nonresponsive -C np_foobar");
cmp_ok( $res->return_code, '==', 2, "Exit CRITICAL with non responsive host" );
}
SKIP: {
skip "no invalid host defined", 2 if ( ! $hostname_invalid );
$res = NPTest->testCmd( "./$plugin -H $hostname_invalid -C $snmp_community");
$res = NPTest->testCmd( "./$plugin -H $hostname_invalid -C np_foobar");
cmp_ok( $res->return_code, '==', 3, "Exit UNKNOWN with invalid host" );
like($res->output, "/Unable to resolve.*$hostname_invalid/", "String matches unable to resolve.*$hostname_invalid");
}

8
plugins/t/check_snmp.t
View file

@ -44,7 +44,7 @@ SKIP: {
like( $res->output, "/check_snmp: Invalid SNMP version - 3c/" );
SKIP: {
skip "no snmp host defined", 30 if ( ! $host_snmp );
skip "no snmp host defined", 32 if ( ! $host_snmp );
$res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o system.sysUpTime.0 -w 1: -c 1:");
cmp_ok( $res->return_code, '==', 0, "Exit OK when querying uptime" );
@ -114,16 +114,18 @@ SKIP: {
}
# These checks need a complete command line. An invalid community is used so
# the tests can run on hosts w/o snmp host/community in NPTest.cache. Execution will fail anyway
SKIP: {
skip "no non responsive host defined", 2 if ( ! $host_nonresponsive );
$res = NPTest->testCmd( "./check_snmp -H $host_nonresponsive -C $snmp_community -o system.sysUpTime.0 -w 1: -c 1:");
$res = NPTest->testCmd( "./check_snmp -H $host_nonresponsive -C np_foobar -o system.sysUpTime.0 -w 1: -c 1:");
cmp_ok( $res->return_code, '==', 3, "Exit UNKNOWN with non responsive host" );
like($res->output, '/External command error: Timeout: No Response from /', "String matches timeout problem");
}
SKIP: {
skip "no non invalid host defined", 2 if ( ! $hostname_invalid );
$res = NPTest->testCmd( "./check_snmp -H $hostname_invalid -C $snmp_community -o system.sysUpTime.0 -w 1: -c 1:");
$res = NPTest->testCmd( "./check_snmp -H $hostname_invalid -C np_foobar -o system.sysUpTime.0 -w 1: -c 1:");
cmp_ok( $res->return_code, '==', 3, "Exit UNKNOWN with non responsive host" );
like($res->output, '/External command error: .*(nosuchhost|Name or service not known|Unknown host)/', "String matches invalid host");
}