upstream/monitoring-plugins
1
0
Fork 0
mirror of https://github.com/monitoring-plugins/monitoring-plugins.git synced 2026-02-19 02:27:55 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #1830 from monitoring-plugins/fix_1829

Browse source 
check_http: Fix memory reallocation error in chunk decoding logic
This commit is contained in:
Lorenz 2023-01-31 12:18:14 +01:00 committed by GitHub
commit 2ad962c134
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
plugins/check_http.c
View file

@ -1399,7 +1399,6 @@ char *unchunk_content(const char *content) {
char *endptr;
long length_of_chunk = 0;
size_t overall_size = 0;
char *result_ptr;
while (true) {
size_of_chunk = strtol(pointer, &endptr, 16);
@ -1439,26 +1438,28 @@ char *unchunk_content(const char *content) {
overall_size += length_of_chunk;
if (result == NULL) {
result = (char *)calloc(length_of_chunk, sizeof(char));
// Size of the chunk plus the ending NULL byte
result = (char *)malloc(length_of_chunk +1);
if (result == NULL) {
if (verbose) {
printf("Failed to allocate memory for unchunked body\n");
}
return NULL;
}
result_ptr = result;
} else {
void *tmp = realloc(result, overall_size);
// Enlarge memory to the new size plus the ending NULL byte
void *tmp = realloc(result, overall_size +1);
if (tmp == NULL) {
if (verbose) {
printf("Failed to allocate memory for unchunked body\n");
}
return NULL;
} else {
result = tmp;
}
}
memcpy(result_ptr, start_of_chunk, size_of_chunk);
result_ptr = result_ptr + size_of_chunk;
memcpy(result + (overall_size - size_of_chunk), start_of_chunk, size_of_chunk);
}
result[overall_size] = '\0';