mirror of
https://github.com/mattermost/mattermost.git
synced 2026-02-19 02:28:08 -05:00
fddd4a70bc
Some checks failed
ESR Upgrade / Run ESR upgrade script from 5.37 to 7.8 (push) Has been cancelled
ESR Upgrade / Run ESR upgrade script from 5.37 to 6.3 (push) Has been cancelled
ESR Upgrade / Run ESR upgrade script from 6.3 to 7.8 (push) Has been cancelled
Server CI Master / master-ci (push) Has been cancelled
Web App CI Master / master-ci (push) Has been cancelled
This commit reverts PR #30214, which addressed bug MM-60790 but caused a performance regression tracked by MM-66782. This revert has two implications: 1. The performance issue is solved. 2. The original bug is re-introduced. Re-introducing the original bug seems not to be ideal, but I argue that the original PR did not actually fix the bug: - Before that PR, looking for a quoted string would return additional results: the UX was slightly confusing, because when the user looked for the word "stateful", the results would contain matches like "states" (see MM-60790). - After that PR, looking for a quoted string can timeout, so that the list of results becomes empty. The UX here may be less confusing, since the user simply doesn't find what they're looking for, and they may assume that string is not present in any post, but it's completely wrong: the result list is empty because the SQL query timed out and thus the endpoint returned 0 results. The solution to the original issue should be addressed via Elasticsearch, which should provide a more refined and precise search results. For more information on the investigation on this issue and the motivation behind the revert, see https://mattermost.atlassian.net/wiki/x/IYAk_w Co-authored-by: Mattermost Build <build@mattermost.com> |
||
|---|---|---|
| .. | ||
| bin | ||
| build | ||
| channels | ||
| cmd | ||
| config | ||
| einterfaces | ||
| enterprise | ||
| fonts | ||
| i18n | ||
| platform | ||
| public | ||
| scripts | ||
| templates | ||
| tests | ||
| .gitignore | ||
| .go-version | ||
| .golangci.yml | ||
| .sass-lint.yml | ||
| config.mk | ||
| copyright.txt | ||
| docker-compose.makefile.m1.yml | ||
| docker-compose.makefile.yml | ||
| docker-compose.yaml | ||
| go.mod | ||
| go.sum | ||
| Makefile | ||
| path.go | ||