mirror of
https://github.com/mattermost/mattermost.git
synced 2026-02-18 18:18:23 -05:00
1e98250566
* Change moduleResolution to bundler This makes TS follow the module resolution of newer versions of Node.js which makes it use the `imports` and `exports` fields of the package.json while not requiring file extensions in some cases which it does when set to node16 or nodenext. I'm changing this to make it so that VS Code can correctly import things from our types package without adding `/src/` to the import path erroneously. Hopefully it doesn't introduce any other issues. * Change make clean to use package.json script * Remove missing fields from SystemEmoji type These were removed from emoji.json in https://github.com/mattermost/mattermost-webapp/pull/9597, but we forgot to remove the fields from the type definition. They weren't used anyway. * MM-66867 Add initial version of shared package This initial version includes the shared context, React Intl support (although that's currently untested), linting, and testing support. It builds with Parcel. * Move isSystemEmoji into Types package * MM-67318 Add Emoji component to shared package To limit the number of changes to the web app, it still uses RenderEmoji which wraps the new component for the time being. I'll likely replace RenderEmoji with using it directly in a future PR, but I may leave it as-is if the changes are too big because the API is different. * Add postinstall script to build shared package * Revert changes to moduleResolution and add typesVersions to shared package I plan to still change moduleResolution to bundler since it's the new default for TS projects, and since it lets TS use the exports field in package.json, but it requires other changes to fix some minor issues in this repo which I don't want to muddy this PR with. Adding typesVersions lets TS resolve the components in the shared package like it does with the types package while using the old value for moduleResolution. Plugins still use the old value for moduleResolution, so this will let them use the shared package with fewer updates changes as well. * Fix Webpack not always watching other packages for changes * Add shared package dependencies and build output to CI cache * Update @parcel/watcher to fix segfaults This package seems to be older than the rest of the newly added Parcel dependencies because it's used by sass. * Fix build script not doing that * Go back to manually specifying postinstall order I just learned that postinstall scripts run in parallel because I was running into an issue where the client and types packages were building at the same time, causing one of them to fail. They still run in parallel, so that may still occasionally happen, but by specifying the order manually, we hopefully avoid that happening like we seemed to do before. * Further revert changes to postinstall script The subpackages were also being built when installed by a plugin * Increment cache keys * Fix typo * Change the cache busting to look at shared/package.json * Attempt to debug tests and caching * Debugging... * Add shared package to platform code coverage * Remove caching of package builds and manually run postinstall during web app CI setup * Debugging... * Remove CI debugging logic * Update package-lock.json * Change Emoji component back to taking an emojiName prop * Add .parcel-cache to .gitignore
113 lines
2.9 KiB
Makefile
113 lines
2.9 KiB
Makefile
-include config.override.mk
|
|
include config.mk
|
|
|
|
# The CI environment variable is set automatically in CircleCI and GitLab CI
|
|
CI ?= false
|
|
|
|
# Detect Linux/ARM64 and set a flag to fix the issue with optipng-bin on it:
|
|
# please see optipng-bin Linux arm64 support issue (https://github.com/imagemin/optipng-bin/issues/118) for details:
|
|
ifeq ($(shell uname)/$(shell uname -m),Linux/aarch64)
|
|
LINUX_ARM64 = true
|
|
CPPFLAGS += -DPNG_ARM_NEON_OPT=0
|
|
endif
|
|
# Exact same issue but for Linux/PPC64
|
|
ifeq ($(findstring Linux/ppc64,$(shell uname)/$(shell uname -m)),Linux/ppc64)
|
|
LINUX_PPC64 = true
|
|
CPPFLAGS += -DPNG_POWERPC_VSX_OPT=0
|
|
endif
|
|
|
|
.PHONY: run
|
|
run: node_modules ## Runs app
|
|
@echo Running Mattermost Web App for development
|
|
|
|
npm run run
|
|
|
|
.PHONY: stop
|
|
stop: ## Stops webpack
|
|
@echo Stopping changes watching
|
|
|
|
ifeq ($(OS),Windows_NT)
|
|
wmic process where "Caption='node.exe' and CommandLine like '%webpack%'" call terminate
|
|
else
|
|
-@pkill -f webpack || true
|
|
endif
|
|
|
|
.PHONY: restart
|
|
restart: | stop run ## Restarts the app
|
|
|
|
.PHONY: dev
|
|
dev: node_modules ## Runs app with webpack-dev-server
|
|
npm run dev-server
|
|
|
|
.PHONY: test
|
|
test: node_modules ## Runs tests
|
|
@echo Running jest unit/component testing
|
|
|
|
npm run test
|
|
|
|
.PHONY: check-style
|
|
check-style: node_modules ## Checks JS file for ESLint confirmity
|
|
@echo Checking for style guide compliance
|
|
|
|
npm run check
|
|
|
|
.PHONY: fix-style
|
|
fix-style: node_modules ## Fix JS file ESLint issues
|
|
@echo Fixing lint issues to follow style guide
|
|
|
|
npm run fix
|
|
|
|
.PHONY: check-types
|
|
check-types: node_modules ## Checks TS file for TypeScript confirmity
|
|
@echo Checking for TypeScript compliance
|
|
|
|
npm run check-types
|
|
|
|
.PHONY: i18n-extract
|
|
i18n-extract: node_modules ## Extracts i18n messages from code to en.json
|
|
@echo Extracting i18n messages
|
|
|
|
npm run i18n-extract
|
|
|
|
.PHONY: i18n-extract-check
|
|
i18n-extract-check: node_modules ## Checks if en.json is in sync with code
|
|
@echo Checking i18n message sync
|
|
|
|
npm run i18n-extract:check
|
|
|
|
.PHONY: dist
|
|
dist: node_modules ## Builds all web app packages
|
|
@echo Packaging Mattermost Web App
|
|
|
|
npm run build
|
|
|
|
node_modules: package.json $(wildcard package-lock.json)
|
|
@echo Getting dependencies using npm
|
|
|
|
ifeq ($(CI),false)
|
|
CPPFLAGS="$(CPPFLAGS)" npm install
|
|
else
|
|
# This runs in CI with NODE_ENV=production which skips devDependencies without this flag
|
|
npm ci --include=dev
|
|
endif
|
|
|
|
touch $@
|
|
|
|
.PHONY: clean
|
|
clean: ## Clears cached; deletes node_modules and dist directories
|
|
@echo Cleaning Web App
|
|
|
|
npm run clean
|
|
|
|
.PHONY: package
|
|
package: node_modules dist ## Generates ./mattermost-webapp.tar.gz for use by someone customizing the web app
|
|
mkdir tmp
|
|
mv channels/dist tmp/client
|
|
tar -C tmp -czf mattermost-webapp.tar.gz client
|
|
mv tmp/client channels/dist
|
|
rmdir tmp
|
|
|
|
## Help documentation à la https://marmelab.com/blog/2016/02/29/auto-documented-makefile.html
|
|
.PHONY: help
|
|
help:
|
|
@grep -E '^[0-9a-zA-Z_-]+:.*?## .*$$' ./Makefile | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
|