mattermost/app/plugin_deadlock_test.go
Jesse Hallam 04749027f6
MM-11575: change plugin nil semantics (#9212)
* change MessageWillBePosted nil return semantics

* change FileWillBeUploaded nil return semantics

* use LogDebug to verify plugin inputs vs. the confusing Delete(User|Team)
2018-08-03 13:15:51 -04:00

211 lines
4.3 KiB
Go

// Copyright (c) 2017-present Mattermost, Inc. All Rights Reserved.
// See License.txt for license information.
package app
import (
"os"
"strings"
"testing"
"text/template"
"time"
"github.com/mattermost/mattermost-server/model"
)
func TestPluginDeadlock(t *testing.T) {
t.Run("Single Plugin", func(t *testing.T) {
th := Setup().InitBasic()
defer th.TearDown()
pluginPostOnActivate := template.Must(template.New("pluginPostOnActivate").Parse(`
package main
import (
"github.com/mattermost/mattermost-server/plugin"
"github.com/mattermost/mattermost-server/model"
)
type MyPlugin struct {
plugin.MattermostPlugin
}
func (p *MyPlugin) OnActivate() error {
_, err := p.API.CreatePost(&model.Post{
UserId: "{{.User.Id}}",
ChannelId: "{{.Channel.Id}}",
Message: "message",
})
if err != nil {
panic(err.Error())
}
return nil
}
func (p *MyPlugin) MessageWillBePosted(c *plugin.Context, post *model.Post) (*model.Post, string) {
if _, from_plugin := post.Props["from_plugin"]; from_plugin {
return nil, ""
}
p.API.CreatePost(&model.Post{
UserId: "{{.User.Id}}",
ChannelId: "{{.Channel.Id}}",
Message: "message",
Props: map[string]interface{}{
"from_plugin": true,
},
})
return nil, ""
}
func main() {
plugin.ClientMain(&MyPlugin{})
}
`,
))
templateData := struct {
User *model.User
Channel *model.Channel
}{
th.BasicUser,
th.BasicChannel,
}
plugins := []string{}
pluginTemplates := []*template.Template{
pluginPostOnActivate,
}
for _, pluginTemplate := range pluginTemplates {
b := &strings.Builder{}
pluginTemplate.Execute(b, templateData)
plugins = append(plugins, b.String())
}
done := make(chan bool)
go func() {
SetAppEnvironmentWithPlugins(t, plugins, th.App, th.App.NewPluginAPI)
close(done)
}()
select {
case <-done:
case <-time.After(30 * time.Second):
t.Fatal("plugin failed to activate: likely deadlocked")
go func() {
time.Sleep(5 * time.Second)
os.Exit(1)
}()
}
})
t.Run("Multiple Plugins", func(t *testing.T) {
th := Setup().InitBasic()
defer th.TearDown()
pluginPostOnHasBeenPosted := template.Must(template.New("pluginPostOnHasBeenPosted").Parse(`
package main
import (
"github.com/mattermost/mattermost-server/plugin"
"github.com/mattermost/mattermost-server/model"
)
type MyPlugin struct {
plugin.MattermostPlugin
}
func (p *MyPlugin) MessageWillBePosted(c *plugin.Context, post *model.Post) (*model.Post, string) {
if _, from_plugin := post.Props["from_plugin"]; from_plugin {
return nil, ""
}
p.API.CreatePost(&model.Post{
UserId: "{{.User.Id}}",
ChannelId: "{{.Channel.Id}}",
Message: "message",
Props: map[string]interface{}{
"from_plugin": true,
},
})
return nil, ""
}
func main() {
plugin.ClientMain(&MyPlugin{})
}
`,
))
pluginPostOnActivate := template.Must(template.New("pluginPostOnActivate").Parse(`
package main
import (
"github.com/mattermost/mattermost-server/plugin"
"github.com/mattermost/mattermost-server/model"
)
type MyPlugin struct {
plugin.MattermostPlugin
}
func (p *MyPlugin) OnActivate() error {
_, err := p.API.CreatePost(&model.Post{
UserId: "{{.User.Id}}",
ChannelId: "{{.Channel.Id}}",
Message: "message",
})
if err != nil {
panic(err.Error())
}
return nil
}
func main() {
plugin.ClientMain(&MyPlugin{})
}
`,
))
templateData := struct {
User *model.User
Channel *model.Channel
}{
th.BasicUser,
th.BasicChannel,
}
plugins := []string{}
pluginTemplates := []*template.Template{
pluginPostOnHasBeenPosted,
pluginPostOnActivate,
}
for _, pluginTemplate := range pluginTemplates {
b := &strings.Builder{}
pluginTemplate.Execute(b, templateData)
plugins = append(plugins, b.String())
}
done := make(chan bool)
go func() {
SetAppEnvironmentWithPlugins(t, plugins, th.App, th.App.NewPluginAPI)
close(done)
}()
select {
case <-done:
case <-time.After(30 * time.Second):
t.Fatal("plugin failed to activate: likely deadlocked")
go func() {
time.Sleep(5 * time.Second)
os.Exit(1)
}()
}
})
}