mirror of
https://github.com/mattermost/mattermost.git
synced 2026-05-27 12:13:29 -04:00
* MM-68149: upgrade to Go 1.26.2 Update go directive in go.mod and .go-version. * MM-68149: replace pointer helpers with Go 1.26 new() Go 1.26 extends the built-in new() to accept an initial value expression, making typed-pointer helpers like model.NewPointer(x), bToP(x), and boolPtr(x) redundant. Replace every call site with new(x) and remove the now-unused helper functions and their //go:fix inline directives. * MM-68149: apply go fix for reflect API and format-string changes - reflect.Ptr → reflect.Pointer (renamed in Go 1.18, deprecated alias removed in 1.26) - reflect range-over-struct: for i := 0; i < t.NumField(); i++ → for field := range t.Fields() and the equivalent for Methods() and interface types - Fix format-string concatenation and variadic-arg mismatches flagged by go vet * MM-68149: update JPEG fixtures and test infrastructure for Go 1.26 encoder Go 1.26 ships a new image/jpeg encoder that produces slightly different output. Regenerate all JPEG fixture files and switch the comparison helpers from byte-equality to pixel-level comparison with a small per-channel tolerance, so minor encoder drift across patch versions is handled automatically. Add -update-fixtures flag to make it easy to regenerate fixtures after future major Go upgrades. Document the update procedure in tests/README.md. * MM-68149: CI check that go fix ./... produces no changes * Fix real bugs flagged by CodeRabbit review - group.go: set newGroup.MemberCount not group.MemberCount (member count was populated on the wrong variable and lost before publish/return) - file_test.go: guard compareImage(GetFilePreview) on the preview slice length, not the thumbnail slice length (copy-paste error) - config_test.go: remove duplicate MinimumLength assignment * fixup! Fix real bugs flagged by CodeRabbit review
171 lines
4 KiB
Go
171 lines
4 KiB
Go
package panel
|
|
|
|
import (
|
|
"errors"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/pluginapi/experimental/bot/logger"
|
|
"github.com/mattermost/mattermost/server/public/pluginapi/experimental/bot/poster"
|
|
"github.com/mattermost/mattermost/server/public/pluginapi/experimental/common"
|
|
"github.com/mattermost/mattermost/server/public/pluginapi/experimental/panel/settings"
|
|
)
|
|
|
|
type Panel interface {
|
|
Set(userID, settingID string, value any) error
|
|
Print(userID string)
|
|
ToPost(userID string) (*model.Post, error)
|
|
Clear(userID string) error
|
|
URL() string
|
|
GetSettingIDs() []string
|
|
}
|
|
|
|
type panel struct {
|
|
settings map[string]settings.Setting
|
|
settingKeys []string
|
|
poster poster.Poster
|
|
logger logger.Logger
|
|
store Store
|
|
settingHandler string
|
|
pluginURL string
|
|
}
|
|
|
|
func NewSettingsPanel(
|
|
settingList []settings.Setting,
|
|
p poster.Poster,
|
|
l logger.Logger,
|
|
store Store,
|
|
settingHandler,
|
|
pluginURL string,
|
|
) Panel {
|
|
settingsMap := make(map[string]settings.Setting)
|
|
settingKeys := []string{}
|
|
for _, s := range settingList {
|
|
settingsMap[s.GetID()] = s
|
|
settingKeys = append(settingKeys, s.GetID())
|
|
}
|
|
|
|
panel := &panel{
|
|
settings: settingsMap,
|
|
settingKeys: settingKeys,
|
|
poster: p,
|
|
logger: l,
|
|
store: store,
|
|
settingHandler: settingHandler,
|
|
pluginURL: pluginURL,
|
|
}
|
|
|
|
return panel
|
|
}
|
|
|
|
func (p *panel) Set(userID, settingID string, value any) error {
|
|
s, ok := p.settings[settingID]
|
|
if !ok {
|
|
return errors.New("cannot find setting " + settingID)
|
|
}
|
|
|
|
err := s.Set(userID, value)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (p *panel) GetSettingIDs() []string {
|
|
return p.settingKeys
|
|
}
|
|
|
|
func (p *panel) URL() string {
|
|
return p.settingHandler
|
|
}
|
|
|
|
func (p *panel) Print(userID string) {
|
|
err := p.cleanPreviousSettingsPosts(userID)
|
|
if err != nil {
|
|
p.logger.Errorf("could not clean previous setting post, %s", err.Error())
|
|
}
|
|
|
|
sas := []*model.MessageAttachment{}
|
|
for _, key := range p.settingKeys {
|
|
s := p.settings[key]
|
|
sa, loopErr := s.GetMessageAttachments(userID, p.pluginURL+p.settingHandler, p.isSettingDisabled(userID, s))
|
|
if loopErr != nil {
|
|
p.logger.Errorf("error creating the message attachment, err=%s", loopErr.Error())
|
|
continue
|
|
}
|
|
sas = append(sas, sa)
|
|
}
|
|
postID, err := p.poster.DMWithAttachments(userID, sas...)
|
|
if err != nil {
|
|
p.logger.Errorf("error creating the message, err=%s", err.Error())
|
|
return
|
|
}
|
|
|
|
err = p.store.SetPanelPostID(userID, postID)
|
|
if err != nil {
|
|
p.logger.Errorf("could not set the post IDs, err=%s", err.Error())
|
|
}
|
|
}
|
|
|
|
func (p *panel) ToPost(userID string) (*model.Post, error) {
|
|
post := &model.Post{}
|
|
|
|
sas := []*model.MessageAttachment{}
|
|
for _, key := range p.settingKeys {
|
|
s := p.settings[key]
|
|
sa, err := s.GetMessageAttachments(userID, p.pluginURL+p.settingHandler, p.isSettingDisabled(userID, s))
|
|
if err != nil {
|
|
p.logger.Errorf("error creating the message attachment for setting %s, err=%s", s.GetID(), err.Error())
|
|
continue
|
|
}
|
|
sas = append(sas, sa)
|
|
}
|
|
|
|
model.ParseMessageAttachment(post, sas)
|
|
return post, nil
|
|
}
|
|
|
|
func (p *panel) cleanPreviousSettingsPosts(userID string) error {
|
|
postID, err := p.store.GetPanelPostID(userID)
|
|
if err == common.ErrNotFound {
|
|
return nil
|
|
}
|
|
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
err = p.poster.DeletePost(postID)
|
|
if err != nil {
|
|
p.logger.Errorf("could not delete setting post, %s", err)
|
|
}
|
|
|
|
err = p.store.DeletePanelPostID(userID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (p *panel) Clear(userID string) error {
|
|
return p.cleanPreviousSettingsPosts(userID)
|
|
}
|
|
|
|
func (p *panel) isSettingDisabled(userID string, s settings.Setting) bool {
|
|
dependencyID := s.GetDependency()
|
|
if dependencyID == "" {
|
|
return false
|
|
}
|
|
dependency, ok := p.settings[dependencyID]
|
|
if !ok {
|
|
p.logger.Errorf("settings dependency %s not found", dependencyID)
|
|
return false
|
|
}
|
|
|
|
value, err := dependency.Get(userID)
|
|
if err != nil {
|
|
p.logger.Errorf("cannot get dependency %s value", dependencyID)
|
|
return false
|
|
}
|
|
return s.IsDisabled(value)
|
|
}
|