mirror of
https://github.com/mattermost/mattermost.git
synced 2026-05-28 04:35:04 -04:00
e3fbf8711f
* MM-68149: upgrade to Go 1.26.2 Update go directive in go.mod and .go-version. * MM-68149: replace pointer helpers with Go 1.26 new() Go 1.26 extends the built-in new() to accept an initial value expression, making typed-pointer helpers like model.NewPointer(x), bToP(x), and boolPtr(x) redundant. Replace every call site with new(x) and remove the now-unused helper functions and their //go:fix inline directives. * MM-68149: apply go fix for reflect API and format-string changes - reflect.Ptr → reflect.Pointer (renamed in Go 1.18, deprecated alias removed in 1.26) - reflect range-over-struct: for i := 0; i < t.NumField(); i++ → for field := range t.Fields() and the equivalent for Methods() and interface types - Fix format-string concatenation and variadic-arg mismatches flagged by go vet * MM-68149: update JPEG fixtures and test infrastructure for Go 1.26 encoder Go 1.26 ships a new image/jpeg encoder that produces slightly different output. Regenerate all JPEG fixture files and switch the comparison helpers from byte-equality to pixel-level comparison with a small per-channel tolerance, so minor encoder drift across patch versions is handled automatically. Add -update-fixtures flag to make it easy to regenerate fixtures after future major Go upgrades. Document the update procedure in tests/README.md. * MM-68149: CI check that go fix ./... produces no changes * Fix real bugs flagged by CodeRabbit review - group.go: set newGroup.MemberCount not group.MemberCount (member count was populated on the wrong variable and lost before publish/return) - file_test.go: guard compareImage(GetFilePreview) on the preview slice length, not the thumbnail slice length (copy-paste error) - config_test.go: remove duplicate MinimumLength assignment * fixup! Fix real bugs flagged by CodeRabbit review
557 lines
17 KiB
Go
557 lines
17 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package commands
|
|
|
|
import (
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/v8/channels/api4"
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/mattermost/mattermost/server/v8/cmd/mmctl/client"
|
|
"github.com/mattermost/mattermost/server/v8/cmd/mmctl/printer"
|
|
)
|
|
|
|
func (s *MmctlE2ETestSuite) TestChannelGroupEnableCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
channelName := api4.GenerateTestChannelName()
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: channelName,
|
|
DisplayName: "dn_" + channelName,
|
|
Type: model.ChannelTypeOpen,
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
err := s.th.App.DeleteChannel(s.th.Context, channel, "")
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
id := model.NewId()
|
|
group, appErr := s.th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: new("name" + id),
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: new(model.NewId()),
|
|
})
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
_, err := s.th.App.DeleteGroup(group.Id)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
_, appErr = s.th.App.UpsertGroupSyncable(&model.GroupSyncable{
|
|
GroupId: group.Id,
|
|
SyncableId: channel.Id,
|
|
Type: model.GroupSyncableTypeChannel,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
_, err := s.th.App.DeleteGroupSyncable(group.Id, channel.Id, model.GroupSyncableTypeChannel)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Run("Should not allow regular user to enable group for channel", func() {
|
|
printer.Clean()
|
|
|
|
err := channelGroupEnableCmdF(s.th.Client, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
|
|
s.Require().Error(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Should enable group sync for the channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := channelGroupEnableCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
|
|
s.Require().NoError(err)
|
|
|
|
channel.GroupConstrained = new(false)
|
|
defer func() {
|
|
_, err := s.th.App.UpdateChannel(s.th.Context, channel)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
ch, appErr := s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
s.Require().Nil(appErr)
|
|
s.Require().True(ch.IsGroupConstrained())
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestChannelGroupDisableCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
channelName := api4.GenerateTestChannelName()
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: channelName,
|
|
DisplayName: "dn_" + channelName,
|
|
Type: model.ChannelTypeOpen,
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
err := s.th.App.DeleteChannel(s.th.Context, channel, "")
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
id := model.NewId()
|
|
group, appErr := s.th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: new("name" + id),
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: new(model.NewId()),
|
|
})
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
_, err := s.th.App.DeleteGroup(group.Id)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
_, appErr = s.th.App.UpsertGroupSyncable(&model.GroupSyncable{
|
|
GroupId: group.Id,
|
|
SyncableId: channel.Id,
|
|
Type: model.GroupSyncableTypeChannel,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
_, err := s.th.App.DeleteGroupSyncable(group.Id, channel.Id, model.GroupSyncableTypeChannel)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
channel.GroupConstrained = new(true)
|
|
defer func() {
|
|
_, err := s.th.App.UpdateChannel(s.th.Context, channel)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Run("Should not allow regular user to disable group for channel", func() {
|
|
printer.Clean()
|
|
|
|
err := channelGroupDisableCmdF(s.th.Client, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
|
|
s.Require().Error(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("Should disable group sync for the channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := channelGroupDisableCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
|
|
s.Require().NoError(err)
|
|
|
|
channel.GroupConstrained = new(true)
|
|
defer func() {
|
|
_, err := s.th.App.UpdateChannel(s.th.Context, channel)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
ch, appErr := s.th.App.GetChannel(s.th.Context, channel.Id)
|
|
s.Require().Nil(appErr)
|
|
s.Require().False(ch.IsGroupConstrained())
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestListLdapGroupsCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
configForLdap(s.th)
|
|
|
|
s.Run("MM-T3977 Should not allow regular user to list LDAP groups", func() {
|
|
printer.Clean()
|
|
|
|
err := listLdapGroupsCmdF(s.th.Client, &cobra.Command{}, nil)
|
|
s.Require().Error(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("MM-T3976 Should list LDAP groups", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
// we rely on the test data generated for the openldap server
|
|
// i.e. "test-data.ldif" script
|
|
err := listLdapGroupsCmdF(c, &cobra.Command{}, nil)
|
|
s.Require().NoError(err)
|
|
s.Require().NotEmpty(printer.GetLines())
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestChannelGroupStatusCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
channelName := api4.GenerateTestChannelName()
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: channelName,
|
|
DisplayName: "dn_" + channelName,
|
|
Type: model.ChannelTypeOpen,
|
|
GroupConstrained: new(true),
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
err := s.th.App.DeleteChannel(s.th.Context, channel, "")
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
channelName2 := api4.GenerateTestChannelName()
|
|
channel2, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: channelName2,
|
|
DisplayName: "dn_" + channelName2,
|
|
Type: model.ChannelTypeOpen,
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
err := s.th.App.DeleteChannel(s.th.Context, channel2, "")
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.RunForAllClients("MM-T3974 Should allow to get status of a group constrained channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := channelGroupStatusCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
|
|
s.Require().NoError(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Equal(printer.GetLines()[0], "Enabled")
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForAllClients("MM-T3975 Should allow to get status of a regular channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := channelGroupStatusCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName2})
|
|
s.Require().NoError(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Equal(printer.GetLines()[0], "Disabled")
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestChannelGroupListCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
channelName := api4.GenerateTestChannelName()
|
|
channel, appErr := s.th.App.CreateChannel(s.th.Context, &model.Channel{
|
|
TeamId: s.th.BasicTeam.Id,
|
|
Name: channelName,
|
|
DisplayName: "dn_" + channelName,
|
|
Type: model.ChannelTypeOpen,
|
|
}, false)
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
err := s.th.App.DeleteChannel(s.th.Context, channel, "")
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
id := model.NewId()
|
|
group, appErr := s.th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: new("name" + id),
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: new(model.NewId()),
|
|
})
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
_, err := s.th.App.DeleteGroup(group.Id)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
_, appErr = s.th.App.UpsertGroupSyncable(&model.GroupSyncable{
|
|
GroupId: group.Id,
|
|
SyncableId: channel.Id,
|
|
Type: model.GroupSyncableTypeChannel,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
_, err := s.th.App.DeleteGroupSyncable(group.Id, channel.Id, model.GroupSyncableTypeChannel)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Run("MM-T3970 Should not allow regular user to get list of LDAP groups in a channel", func() {
|
|
printer.Clean()
|
|
|
|
err := channelGroupListCmdF(s.th.Client, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
|
|
s.Require().Error(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("MM-T3969 Should allow to get list of LDAP groups in a channel", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := channelGroupListCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
|
|
s.Require().NoError(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
gs, ok := printer.GetLines()[0].(*model.GroupWithSchemeAdmin)
|
|
s.Require().True(ok)
|
|
s.Require().Equal(gs.Group, *group)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestTeamGroupDisableCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
team, _, cleanUpFn := createTestGroupTeam(s)
|
|
defer cleanUpFn()
|
|
|
|
team.GroupConstrained = new(true)
|
|
_, err := s.th.App.UpdateTeam(team)
|
|
s.Require().Nil(err)
|
|
|
|
s.Run("MM-T3919 Should not allow regular user to disable group for team", func() {
|
|
printer.Clean()
|
|
|
|
err := teamGroupDisableCmdF(s.th.Client, &cobra.Command{}, []string{team.Name})
|
|
s.Require().Error(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("MM-T3920 Should disable group sync for the team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := teamGroupDisableCmdF(c, &cobra.Command{}, []string{team.Name})
|
|
s.Require().NoError(err)
|
|
|
|
team.GroupConstrained = new(true)
|
|
defer func() {
|
|
_, err := s.th.App.UpdateTeam(team)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
tm, appErr := s.th.App.GetTeam(team.Id)
|
|
s.Require().Nil(appErr)
|
|
s.Require().False(tm.IsGroupConstrained())
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestTeamGroupEnableCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
team, _, cleanUpFn := createTestGroupTeam(s)
|
|
defer cleanUpFn()
|
|
|
|
s.Run("MM-T3917 Should not allow regular user to enable group for team", func() {
|
|
printer.Clean()
|
|
|
|
err := teamGroupEnableCmdF(s.th.Client, &cobra.Command{}, []string{team.Name})
|
|
s.Require().Error(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("MM-T3918 Should enable group sync for the team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := teamGroupEnableCmdF(c, &cobra.Command{}, []string{team.Name})
|
|
s.Require().NoError(err)
|
|
|
|
team.GroupConstrained = new(false)
|
|
defer func() {
|
|
_, err := s.th.App.UpdateTeam(team)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
tm, appErr := s.th.App.GetTeam(team.Id)
|
|
s.Require().Nil(appErr)
|
|
s.Require().True(tm.IsGroupConstrained())
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestTeamGroupStatusCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
team, _, cleanUpFn := createTestGroupTeam(s)
|
|
defer func() {
|
|
cleanUpFn()
|
|
}()
|
|
|
|
teamName2 := api4.GenerateTestTeamName()
|
|
team2, appErr := s.th.App.CreateTeam(s.th.Context, &model.Team{
|
|
Name: teamName2,
|
|
DisplayName: "dn_" + teamName2,
|
|
Type: model.TeamInvite,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
defer func() {
|
|
err := s.th.App.PermanentDeleteTeam(s.th.Context, team2)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Run("MM-T3921 Should not allow regular user to get status of LDAP groups in a team where they are not a member of", func() {
|
|
printer.Clean()
|
|
|
|
err := teamGroupStatusCmdF(s.th.Client, &cobra.Command{}, []string{team.Name})
|
|
s.Require().Error(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
_, _, appErr = s.th.App.AddUserToTeam(s.th.Context, team.Id, s.th.BasicUser.Id, s.th.SystemAdminUser.Id)
|
|
s.Require().Nil(appErr)
|
|
|
|
_, _, appErr = s.th.App.AddUserToTeam(s.th.Context, team2.Id, s.th.BasicUser.Id, s.th.SystemAdminUser.Id)
|
|
s.Require().Nil(appErr)
|
|
|
|
s.RunForAllClients("MM-T3922 Should allow to get status of a group constrained team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := teamGroupStatusCmdF(c, &cobra.Command{}, []string{team.Name})
|
|
s.Require().NoError(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Equal(printer.GetLines()[0], "Enabled")
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForAllClients("MM-T3923 Should allow to get status of a regular team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := teamGroupStatusCmdF(c, &cobra.Command{}, []string{teamName2})
|
|
s.Require().NoError(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Equal(printer.GetLines()[0], "Disabled")
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestTeamGroupListCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
team, group, cleanUpFn := createTestGroupTeam(s)
|
|
defer func() {
|
|
cleanUpFn()
|
|
}()
|
|
|
|
s.Run("MM-T3924 Should not allow regular user to get list of LDAP groups in a team", func() {
|
|
printer.Clean()
|
|
|
|
err := teamGroupListCmdF(s.th.Client, &cobra.Command{}, []string{team.Name})
|
|
s.Require().Error(err)
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
|
|
s.RunForSystemAdminAndLocal("MM-T3925 Should allow to get list of LDAP groups in a team", func(c client.Client) {
|
|
printer.Clean()
|
|
|
|
err := teamGroupListCmdF(c, &cobra.Command{}, []string{team.Name})
|
|
s.Require().NoError(err)
|
|
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
gs, ok := printer.GetLines()[0].(*model.GroupWithSchemeAdmin)
|
|
s.Require().True(ok)
|
|
s.Require().Equal(gs.Group, *group)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
}
|
|
|
|
func createTestGroupTeam(s *MmctlE2ETestSuite) (*model.Team, *model.Group, func()) {
|
|
teamName := api4.GenerateTestTeamName()
|
|
team, appErr := s.th.App.CreateTeam(s.th.Context, &model.Team{
|
|
Name: teamName,
|
|
DisplayName: "dn_" + teamName,
|
|
Type: model.TeamOpen,
|
|
GroupConstrained: new(true),
|
|
})
|
|
s.Require().Nil(appErr)
|
|
|
|
id := model.NewId()
|
|
group, appErr := s.th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: new("name" + id),
|
|
Source: model.GroupSourceLdap,
|
|
Description: "description_" + id,
|
|
RemoteId: new(model.NewId()),
|
|
})
|
|
s.Require().Nil(appErr)
|
|
|
|
_, appErr = s.th.App.UpsertGroupSyncable(&model.GroupSyncable{
|
|
GroupId: group.Id,
|
|
SyncableId: team.Id,
|
|
Type: model.GroupSyncableTypeTeam,
|
|
})
|
|
s.Require().Nil(appErr)
|
|
|
|
cleanUpFn := func() {
|
|
_, err := s.th.App.DeleteGroupSyncable(group.Id, team.Id, model.GroupSyncableTypeTeam)
|
|
s.Require().Nil(err)
|
|
|
|
_, err = s.th.App.DeleteGroup(group.Id)
|
|
s.Require().Nil(err)
|
|
|
|
err = s.th.App.PermanentDeleteTeamId(s.th.Context, team.Id)
|
|
s.Require().Nil(err)
|
|
}
|
|
|
|
return team, group, cleanUpFn
|
|
}
|
|
|
|
func (s *MmctlE2ETestSuite) TestUserGroupRestoreCmd() {
|
|
s.SetupEnterpriseTestHelper().InitBasic(s.T())
|
|
|
|
// create group
|
|
id := model.NewId()
|
|
group, appErr := s.th.App.CreateGroup(&model.Group{
|
|
DisplayName: "dn_" + id,
|
|
Name: new("name" + id),
|
|
Source: model.GroupSourceCustom,
|
|
Description: "description_" + id,
|
|
RemoteId: new(model.NewId()),
|
|
})
|
|
s.Require().Nil(appErr)
|
|
s.th.App.Srv().SetLicense(model.NewTestLicenseSKU(model.LicenseShortSkuProfessional, "ldap"))
|
|
|
|
defer func() {
|
|
_, err := s.th.App.DeleteGroup(group.Id)
|
|
s.Require().Nil(err)
|
|
}()
|
|
|
|
s.Run("Should allow group restore after deletion", func() {
|
|
printer.Clean()
|
|
|
|
_, appErr := s.th.App.DeleteGroup(group.Id)
|
|
s.Require().Nil(appErr)
|
|
|
|
s.th.RemovePermissionFromRole(s.T(), model.PermissionRestoreCustomGroup.Id, model.SystemUserRoleId)
|
|
err := userGroupRestoreCmdF(s.th.Client, &cobra.Command{}, []string{group.Id})
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal(err.Error(), "You do not have the appropriate permissions.")
|
|
|
|
s.th.AddPermissionToRole(s.T(), model.PermissionRestoreCustomGroup.Id, model.SystemUserRoleId)
|
|
err = userGroupRestoreCmdF(s.th.Client, &cobra.Command{}, []string{group.Id})
|
|
s.Require().Nil(err)
|
|
s.Require().Len(printer.GetLines(), 1)
|
|
s.Require().Equal(printer.GetLines()[0].(string), "Group successfully restored with ID: "+group.Id)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
|
|
// shouldn't allow restoring of active groups
|
|
printer.Clean()
|
|
err = userGroupRestoreCmdF(s.th.Client, &cobra.Command{}, []string{group.Id})
|
|
s.Require().NotNil(err)
|
|
s.Require().Equal(err.Error(), "no matching group found")
|
|
s.Require().Len(printer.GetLines(), 0)
|
|
s.Require().Len(printer.GetErrorLines(), 0)
|
|
})
|
|
}
|