mirror of
https://github.com/mattermost/mattermost.git
synced 2026-05-26 03:22:20 -04:00
c6b59cc9a7
* Generalize the file storage Test Connection endpoint Replaces the S3-only /api/v4/file/s3_test handler with a backend-agnostic POST /api/v4/file/test that validates mandatory fields per driver and runs a write/read/delete probe against the configured backend. The legacy /file/s3_test route stays as a thin wrapper so existing clients keep working. The driver switch validates S3 and Azure mandatory fields explicitly, treats Local as a no-op (no required credentials), and rejects unknown or empty driver names with a 400 and a specific error code so admins get a useful message instead of a generic backend failure. Reuses config.Desanitize (renamed from the package-private desanitize) so the FakeSetting placeholder swap for secrets is shared with the PUT /api/v4/config save path. Adding a new driver-secret in the future only requires touching config.Desanitize once. Desanitize is also made nil-safe on every pointer dereference so callers can hand it a partial config without first running SetDefaults(). Mattermost-redux and the webapp client gain a corresponding TestFileStoreConnection method that the admin console action layer calls instead of the deprecated S3-specific method. ------ AI assisted commit * Wire Azure Blob Storage into the file storage admin console Adds the Azure Blob Storage option to the File Storage panel in the System Console. Selecting it enables Azure-specific fields for the storage account name, container, optional path prefix, shared key, optional endpoint override, secure-connections toggle, and request timeout. The fields are hidden and disabled when the driver is set to Local or S3, matching the existing pattern. Help text and placeholders are added in the webapp i18n catalog so admins see the same field labels documented in the admin guide. The same set of fields is repeated for the Files Export panel when DedicatedExportStore is enabled, keeping the export backend configurable independently of the primary file store. ------ AI assisted commit * Document /api/v4/file/test in the OpenAPI spec Adds the new backend-agnostic file storage Test Connection endpoint to the public OpenAPI surface. The request body is optional: callers that omit it test the running server configuration, callers that include a full AdminConfig test the supplied configuration without persisting anything. The deprecated /api/v4/file/s3_test endpoint is left unchanged in the spec for the existing S3-only flow. ------ AI assisted commit * Add UI-only Cypress coverage for the Azure file storage panel Adds a Cypress spec that drives the System Console File Storage panel, switches the driver to Azure Blob Storage, fills in the Azure fields, and asserts the expected fields appear (and S3 fields are hidden). The spec is UI-only and does not depend on an Azure backend or Azurite, so it can run in CI without external infrastructure. Updates the existing environment_spec.js so it tolerates the new Azure option in the driver dropdown. ------ AI assisted commit * Nil-guard file storage mandatory-field checks CheckMandatoryS3Fields and CheckMandatoryAzureFields built a FileBackendSettings via NewFileBackendSettingsFromConfig before validating, but that constructor dereferences pointers unconditionally and would panic if a caller skipped the api handler's reflective nil check. Validate the required pointers directly against FileSettings instead, dropping the throwaway constructor call so the methods are safe to call from any path. ------ AI assisted commit * Check permission before validating file settings The /file/test handler ran checkHasNilFields before SessionHasPermissionTo, so an unauthorized caller posting a partial config got a 400, leaking config shape, rather than a 403. Swap the two blocks so the permission decision happens first. ------ AI assisted commit * Preserve FakeSetting when desanitize has no actual The Azure access key, export Azure access key, and S3 secret access key branches in Desanitize reassigned target to actual without checking actual for nil. When the running config had no value, the FakeSetting placeholder in target was replaced with nil, dropping the field from the round-trip. Guard the assignment so the placeholder stays in place when actual is unset. ------ AI assisted commit --------- Co-authored-by: Mattermost Build <build@mattermost.com> |
||
|---|---|---|
| .. | ||
| access_control.yaml | ||
| actions.yaml | ||
| agents.yaml | ||
| audit_logging.yaml | ||
| boards.yaml | ||
| bookmarks.yaml | ||
| bots.yaml | ||
| brand.yaml | ||
| channels.yaml | ||
| cloud.yaml | ||
| cluster.yaml | ||
| commands.yaml | ||
| compliance.yaml | ||
| content_flagging.yaml | ||
| custom_profile_attributes.yaml | ||
| dataretention.yaml | ||
| definitions.yaml | ||
| elasticsearch.yaml | ||
| emoji.yaml | ||
| exports.yaml | ||
| files.yaml | ||
| groups.yaml | ||
| imports.yaml | ||
| introduction.yaml | ||
| ip_filters.yaml | ||
| jobs.yaml | ||
| ldap.yaml | ||
| limits.yaml | ||
| logs.yaml | ||
| metrics.yaml | ||
| oauth.yaml | ||
| outgoing_oauth_connections.yaml | ||
| permissions.yaml | ||
| plugins.yaml | ||
| posts.yaml | ||
| preferences.yaml | ||
| properties.yaml | ||
| reactions.yaml | ||
| recaps.yaml | ||
| remoteclusters.yaml | ||
| reports.yaml | ||
| roles.yaml | ||
| saml.yaml | ||
| scheduled_post.yaml | ||
| schemes.yaml | ||
| service_terms.yaml | ||
| sharedchannels.yaml | ||
| status.yaml | ||
| system.yaml | ||
| teams.yaml | ||
| uploads.yaml | ||
| usage.yaml | ||
| users.yaml | ||
| views.yaml | ||
| webhooks.yaml | ||