mirror of
https://github.com/mattermost/mattermost.git
synced 2026-04-13 04:57:45 -04:00
* Remove legacy quoteColumnName() utility Since Mattermost only supports PostgreSQL, the quoteColumnName() helper that was designed to handle database-specific column quoting is no longer needed. The function was a no-op that simply returned the column name unchanged. Remove the function from utils.go and update status_store.go to use the "Manual" column name directly. * Remove legacy driver checks from store.go Since Mattermost only supports PostgreSQL, remove conditional checks for different database drivers: - Simplify specialSearchChars() to always return PostgreSQL-compatible chars - Remove driver check from computeBinaryParam() - Remove driver check from computeDefaultTextSearchConfig() - Simplify GetDbVersion() to use PostgreSQL syntax directly - Remove switch statement from ensureMinimumDBVersion() - Remove unused driver parameter from versionString() * Remove MySQL alternatives for batch delete operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific DELETE...LIMIT syntax and keep only the PostgreSQL array-based approach: - reaction_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - file_info_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - preference_store.go: Use PostgreSQL tuple IN subquery for DeleteInvalidVisibleDmsGms * Remove MySQL alternatives for UPDATE...FROM syntax Since Mattermost only supports PostgreSQL, remove the MySQL-specific UPDATE syntax that joins tables differently: - thread_store.go: Use PostgreSQL UPDATE...FROM syntax in MarkAllAsReadByChannels and MarkAllAsReadByTeam - post_store.go: Use PostgreSQL UPDATE...FROM syntax in deleteThreadFiles * Remove MySQL alternatives for JSON and subquery operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific JSON and subquery syntax: - thread_store.go: Use PostgreSQL JSONB operators for updating participants - access_control_policy_store.go: Use PostgreSQL JSONB @> operator for querying JSON imports - session_store.go: Use PostgreSQL subquery syntax for Cleanup - job_store.go: Use PostgreSQL subquery syntax for Cleanup * Remove MySQL alternatives for CTE queries Since Mattermost only supports PostgreSQL, simplify code that uses CTEs (Common Table Expressions): - channel_store.go: Remove MySQL CASE-based fallback in UpdateLastViewedAt and use PostgreSQL CTE exclusively - draft_store.go: Remove driver checks in DeleteEmptyDraftsByCreateAtAndUserId, DeleteOrphanDraftsByCreateAtAndUserId, and determineMaxDraftSize * Remove driver checks in migrate.go and schema_dump.go Simplify migration code to use PostgreSQL driver directly since PostgreSQL is the only supported database. * Remove driver checks in sqlx_wrapper.go Always apply lowercase named parameter transformation since PostgreSQL is the only supported database. * Remove driver checks in user_store.go Simplify user store functions to use PostgreSQL-only code paths: - Remove isPostgreSQL parameter from helper functions - Use LEFT JOIN pattern instead of subqueries for bot filtering - Always use case-insensitive LIKE with lower() for search - Remove MySQL-specific role filtering alternatives * Remove driver checks in post_store.go Simplify post_store.go to use PostgreSQL-only code paths: - Inline getParentsPostsPostgreSQL into getParentsPosts - Use PostgreSQL TO_CHAR/TO_TIMESTAMP for date formatting in analytics - Use PostgreSQL array syntax for batch deletes - Simplify determineMaxPostSize to always use information_schema - Use PostgreSQL jsonb subtraction for thread participants - Always execute RefreshPostStats (PostgreSQL materialized views) - Use materialized views for AnalyticsPostCountsByDay - Simplify AnalyticsPostCountByTeam to always use countByTeam * Remove driver checks in channel_store.go Simplify channel_store.go to use PostgreSQL-only code paths: - Always use sq.Dollar.ReplacePlaceholders for UNION queries - Use PostgreSQL LEFT JOIN for retention policy exclusion - Use PostgreSQL jsonb @> operator for access control policy imports - Simplify buildLIKEClause to always use LOWER() for case-insensitive search - Simplify buildFulltextClauseX to always use PostgreSQL to_tsvector/to_tsquery - Simplify searchGroupChannelsQuery to use ARRAY_TO_STRING/ARRAY_AGG * Remove driver checks in file_info_store.go Simplify file_info_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL to_tsvector/to_tsquery for file search - Use file_stats materialized view for CountAll() - Use file_stats materialized view for GetStorageUsage() when not including deleted - Always execute RefreshFileStats() for materialized view refresh * Remove driver checks in attributes_store.go Simplify attributes_store.go to use PostgreSQL-only code paths: - Always execute RefreshAttributes() for materialized view refresh - Remove isPostgreSQL parameter from generateSearchQueryForExpression - Always use PostgreSQL LOWER() LIKE LOWER() syntax for case-insensitive search * Remove driver checks in retention_policy_store.go Simplify retention_policy_store.go to use PostgreSQL-only code paths: - Remove isPostgres parameter from scanRetentionIdsForDeletion - Always use pq.Array for scanning retention IDs - Always use pq.Array for inserting retention IDs - Remove unused json import * Remove driver checks in property stores Simplify property_field_store.go and property_value_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL type casts (::text, ::jsonb, ::bigint, etc.) - Remove isPostgres variable and conditionals * Remove driver checks in channel_member_history_store.go Simplify PermanentDeleteBatch to use PostgreSQL-only code path: - Always use ctid-based subquery for DELETE with LIMIT * Remove remaining driver checks in user_store.go Simplify user_store.go to use PostgreSQL-only code paths: - Use LEFT JOIN for bot exclusion in AnalyticsActiveCountForPeriod - Use LEFT JOIN for bot exclusion in IsEmpty * Simplify fulltext search by consolidating buildFulltextClause functions Remove convertMySQLFullTextColumnsToPostgres and consolidate buildFulltextClause and buildFulltextClauseX into a single function that takes variadic column arguments and returns sq.Sqlizer. * Simplify SQL stores leveraging PostgreSQL-only support - Simplify UpdateMembersRole in channel_store.go and team_store.go to use UPDATE...RETURNING instead of SELECT + UPDATE - Simplify GetPostReminders in post_store.go to use DELETE...RETURNING - Simplify DeleteOrphanedRows queries by removing MySQL workarounds for subquery locking issues - Simplify UpdateUserLastSyncAt to use UPDATE...FROM...RETURNING instead of fetching user first then updating - Remove MySQL index hint workarounds in ORDER BY clauses - Update outdated comments referencing MySQL - Consolidate buildFulltextClause and remove convertMySQLFullTextColumnsToPostgres * Remove MySQL-specific test artifacts - Delete unused MySQLStopWords variable and stop_word.go file - Remove redundant testSearchEmailAddressesWithQuotes test (already covered by testSearchEmailAddresses) - Update comment that referenced MySQL query planning * Remove MySQL references from server code outside sqlstore - Update config example and DSN parsing docs to reflect PostgreSQL-only support - Remove mysql:// scheme check from IsDatabaseDSN - Simplify SanitizeDataSource to only handle PostgreSQL - Remove outdated MySQL comments from model and plugin code * Remove MySQL references from test files - Update test DSNs to use PostgreSQL format - Remove dead mysql-replica flag and replicaFlag variable - Simplify tests that had MySQL/PostgreSQL branches * Update docs and test config to use PostgreSQL - Update mmctl config set example to use postgres driver - Update test-config.json to use PostgreSQL DSN format * Remove MySQL migration scripts, test data, and docker image Delete MySQL-related files that are no longer needed: - ESR upgrade scripts (esr.*.mysql.*.sql) - MySQL schema dumps (mattermost-mysql-*.sql) - MySQL replication test scripts (replica-*.sh, mysql-migration-test.sh) - MySQL test warmup data (mysql_migration_warmup.sql) - MySQL docker image reference from mirror-docker-images.json * Remove MySQL references from webapp - Simplify minimumHashtagLength description to remove MySQL-specific configuration note - Remove unused HIDE_MYSQL_STATS_NOTIFICATION preference constant - Update en.json i18n source file * clean up e2e-tests * rm server/tests/template.load * Use teamMemberSliceColumns() in UpdateMembersRole RETURNING clause Refactor to use the existing helper function instead of hardcoding the column names, ensuring consistency if the columns are updated. * u.id -> u.Id * address code review feedback --------- Co-authored-by: Mattermost Build <build@mattermost.com>
208 lines
4.9 KiB
Go
208 lines
4.9 KiB
Go
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
package sqlstore
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"io"
|
|
"log"
|
|
"path"
|
|
"sort"
|
|
"strconv"
|
|
"sync"
|
|
|
|
"github.com/mattermost/mattermost/server/public/model"
|
|
"github.com/mattermost/mattermost/server/public/shared/mlog"
|
|
"github.com/mattermost/mattermost/server/v8/channels/db"
|
|
"github.com/mattermost/morph"
|
|
ps "github.com/mattermost/morph/drivers/postgres"
|
|
"github.com/mattermost/morph/models"
|
|
mbindata "github.com/mattermost/morph/sources/embedded"
|
|
)
|
|
|
|
type Migrator struct {
|
|
engine *morph.Morph
|
|
store *SqlStore
|
|
}
|
|
|
|
func NewMigrator(settings model.SqlSettings, logger mlog.LoggerIFace, dryRun bool) (*Migrator, error) {
|
|
ss := &SqlStore{
|
|
rrCounter: 0,
|
|
srCounter: 0,
|
|
settings: &settings,
|
|
logger: logger,
|
|
quitMonitor: make(chan struct{}),
|
|
wgMonitor: &sync.WaitGroup{},
|
|
}
|
|
|
|
err := ss.initConnection()
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error in initializing connection: %w", err)
|
|
}
|
|
|
|
ver, err := ss.GetDbVersion(true)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("error while getting DB version: %w", err)
|
|
}
|
|
|
|
ok, err := ss.ensureMinimumDBVersion(ver)
|
|
if !ok {
|
|
return nil, fmt.Errorf("error while checking DB version: %w", err)
|
|
}
|
|
|
|
engine, err := ss.initMorph(dryRun, true)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to initialize morph: %w", err)
|
|
}
|
|
|
|
return &Migrator{
|
|
engine: engine,
|
|
store: ss,
|
|
}, nil
|
|
}
|
|
|
|
func (m *Migrator) Close() error {
|
|
if err := m.engine.Close(); err != nil {
|
|
return fmt.Errorf("failed to close morph engine: %w", err)
|
|
}
|
|
|
|
m.store.Close()
|
|
|
|
return nil
|
|
}
|
|
|
|
func (m *Migrator) GetFileName(plan *models.Plan) (string, error) {
|
|
if len(plan.Migrations) == 0 {
|
|
return "", fmt.Errorf("plan is empty")
|
|
}
|
|
|
|
to := plan.Migrations[len(plan.Migrations)-1].Version
|
|
from, err := m.store.GetDBSchemaVersion()
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
|
|
return fmt.Sprintf("migration_plan_%d_%d", from, to), nil
|
|
}
|
|
|
|
func (ss *SqlStore) initMorph(dryRun, enableLogging bool) (*morph.Morph, error) {
|
|
assets := db.Assets()
|
|
|
|
assetsList, err := assets.ReadDir(path.Join("migrations", ss.DriverName()))
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
assetNamesForDriver := make([]string, len(assetsList))
|
|
for i, entry := range assetsList {
|
|
assetNamesForDriver[i] = entry.Name()
|
|
}
|
|
|
|
src, err := mbindata.WithInstance(&mbindata.AssetSource{
|
|
Names: assetNamesForDriver,
|
|
AssetFunc: func(name string) ([]byte, error) {
|
|
return assets.ReadFile(path.Join("migrations", ss.DriverName(), name))
|
|
},
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
driver, err := ps.WithInstance(ss.GetMaster().DB.DB)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
var logWriter io.Writer
|
|
if enableLogging {
|
|
logWriter = &morphWriter{}
|
|
} else {
|
|
logWriter = io.Discard
|
|
}
|
|
|
|
opts := []morph.EngineOption{
|
|
morph.WithLogger(log.New(logWriter, "", log.Lshortfile)),
|
|
morph.WithLock("mm-lock-key"),
|
|
morph.SetStatementTimeoutInSeconds(*ss.settings.MigrationsStatementTimeoutSeconds),
|
|
morph.SetDryRun(dryRun),
|
|
}
|
|
|
|
engine, err := morph.New(context.Background(), driver, src, opts...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return engine, nil
|
|
}
|
|
|
|
func (ss *SqlStore) migrate(direction migrationDirection, dryRun, enableMorphLogging bool) error {
|
|
engine, err := ss.initMorph(dryRun, enableMorphLogging)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer engine.Close()
|
|
|
|
switch direction {
|
|
case migrationsDirectionDown:
|
|
_, err = engine.ApplyDown(-1)
|
|
return err
|
|
default:
|
|
return engine.ApplyAll()
|
|
}
|
|
}
|
|
|
|
func (m *Migrator) GeneratePlan(shouldRecover bool) (*models.Plan, error) {
|
|
diff, err := m.engine.Diff(models.Up)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
plan, err := m.engine.GeneratePlan(diff, shouldRecover)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return plan, nil
|
|
}
|
|
|
|
// MigrateWithPlan migrates the database to the latest version using the provided plan.
|
|
func (m *Migrator) MigrateWithPlan(plan *models.Plan, dryRun bool) error {
|
|
return m.engine.ApplyPlan(plan)
|
|
}
|
|
|
|
func (m *Migrator) DowngradeMigrations(dryRun bool, versions ...string) error {
|
|
migrations, err := m.engine.Diff(models.Down)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
migrationsToDowngrade := make([]*models.Migration, 0, len(versions))
|
|
for _, version := range versions {
|
|
for _, migration := range migrations {
|
|
versionNumber, sErr := strconv.Atoi(version)
|
|
if sErr != nil {
|
|
return sErr
|
|
}
|
|
if migration.Version == uint32(versionNumber) {
|
|
migrationsToDowngrade = append(migrationsToDowngrade, migration)
|
|
}
|
|
}
|
|
}
|
|
|
|
sort.Slice(migrationsToDowngrade, func(i, j int) bool {
|
|
return migrationsToDowngrade[i].Version > migrationsToDowngrade[j].Version
|
|
})
|
|
|
|
if len(migrationsToDowngrade) != len(versions) {
|
|
mlog.Warn("could not match give migration versions, going to downgrade only the migrations those are available.")
|
|
}
|
|
|
|
plan, err := m.engine.GeneratePlan(migrationsToDowngrade, false)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return m.engine.ApplyPlan(plan)
|
|
}
|