mirror of
https://github.com/mattermost/mattermost.git
synced 2026-04-15 14:08:55 -04:00
* Remove legacy quoteColumnName() utility Since Mattermost only supports PostgreSQL, the quoteColumnName() helper that was designed to handle database-specific column quoting is no longer needed. The function was a no-op that simply returned the column name unchanged. Remove the function from utils.go and update status_store.go to use the "Manual" column name directly. * Remove legacy driver checks from store.go Since Mattermost only supports PostgreSQL, remove conditional checks for different database drivers: - Simplify specialSearchChars() to always return PostgreSQL-compatible chars - Remove driver check from computeBinaryParam() - Remove driver check from computeDefaultTextSearchConfig() - Simplify GetDbVersion() to use PostgreSQL syntax directly - Remove switch statement from ensureMinimumDBVersion() - Remove unused driver parameter from versionString() * Remove MySQL alternatives for batch delete operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific DELETE...LIMIT syntax and keep only the PostgreSQL array-based approach: - reaction_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - file_info_store.go: Use PostgreSQL array syntax for PermanentDeleteBatch - preference_store.go: Use PostgreSQL tuple IN subquery for DeleteInvalidVisibleDmsGms * Remove MySQL alternatives for UPDATE...FROM syntax Since Mattermost only supports PostgreSQL, remove the MySQL-specific UPDATE syntax that joins tables differently: - thread_store.go: Use PostgreSQL UPDATE...FROM syntax in MarkAllAsReadByChannels and MarkAllAsReadByTeam - post_store.go: Use PostgreSQL UPDATE...FROM syntax in deleteThreadFiles * Remove MySQL alternatives for JSON and subquery operations Since Mattermost only supports PostgreSQL, remove the MySQL-specific JSON and subquery syntax: - thread_store.go: Use PostgreSQL JSONB operators for updating participants - access_control_policy_store.go: Use PostgreSQL JSONB @> operator for querying JSON imports - session_store.go: Use PostgreSQL subquery syntax for Cleanup - job_store.go: Use PostgreSQL subquery syntax for Cleanup * Remove MySQL alternatives for CTE queries Since Mattermost only supports PostgreSQL, simplify code that uses CTEs (Common Table Expressions): - channel_store.go: Remove MySQL CASE-based fallback in UpdateLastViewedAt and use PostgreSQL CTE exclusively - draft_store.go: Remove driver checks in DeleteEmptyDraftsByCreateAtAndUserId, DeleteOrphanDraftsByCreateAtAndUserId, and determineMaxDraftSize * Remove driver checks in migrate.go and schema_dump.go Simplify migration code to use PostgreSQL driver directly since PostgreSQL is the only supported database. * Remove driver checks in sqlx_wrapper.go Always apply lowercase named parameter transformation since PostgreSQL is the only supported database. * Remove driver checks in user_store.go Simplify user store functions to use PostgreSQL-only code paths: - Remove isPostgreSQL parameter from helper functions - Use LEFT JOIN pattern instead of subqueries for bot filtering - Always use case-insensitive LIKE with lower() for search - Remove MySQL-specific role filtering alternatives * Remove driver checks in post_store.go Simplify post_store.go to use PostgreSQL-only code paths: - Inline getParentsPostsPostgreSQL into getParentsPosts - Use PostgreSQL TO_CHAR/TO_TIMESTAMP for date formatting in analytics - Use PostgreSQL array syntax for batch deletes - Simplify determineMaxPostSize to always use information_schema - Use PostgreSQL jsonb subtraction for thread participants - Always execute RefreshPostStats (PostgreSQL materialized views) - Use materialized views for AnalyticsPostCountsByDay - Simplify AnalyticsPostCountByTeam to always use countByTeam * Remove driver checks in channel_store.go Simplify channel_store.go to use PostgreSQL-only code paths: - Always use sq.Dollar.ReplacePlaceholders for UNION queries - Use PostgreSQL LEFT JOIN for retention policy exclusion - Use PostgreSQL jsonb @> operator for access control policy imports - Simplify buildLIKEClause to always use LOWER() for case-insensitive search - Simplify buildFulltextClauseX to always use PostgreSQL to_tsvector/to_tsquery - Simplify searchGroupChannelsQuery to use ARRAY_TO_STRING/ARRAY_AGG * Remove driver checks in file_info_store.go Simplify file_info_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL to_tsvector/to_tsquery for file search - Use file_stats materialized view for CountAll() - Use file_stats materialized view for GetStorageUsage() when not including deleted - Always execute RefreshFileStats() for materialized view refresh * Remove driver checks in attributes_store.go Simplify attributes_store.go to use PostgreSQL-only code paths: - Always execute RefreshAttributes() for materialized view refresh - Remove isPostgreSQL parameter from generateSearchQueryForExpression - Always use PostgreSQL LOWER() LIKE LOWER() syntax for case-insensitive search * Remove driver checks in retention_policy_store.go Simplify retention_policy_store.go to use PostgreSQL-only code paths: - Remove isPostgres parameter from scanRetentionIdsForDeletion - Always use pq.Array for scanning retention IDs - Always use pq.Array for inserting retention IDs - Remove unused json import * Remove driver checks in property stores Simplify property_field_store.go and property_value_store.go to use PostgreSQL-only code paths: - Always use PostgreSQL type casts (::text, ::jsonb, ::bigint, etc.) - Remove isPostgres variable and conditionals * Remove driver checks in channel_member_history_store.go Simplify PermanentDeleteBatch to use PostgreSQL-only code path: - Always use ctid-based subquery for DELETE with LIMIT * Remove remaining driver checks in user_store.go Simplify user_store.go to use PostgreSQL-only code paths: - Use LEFT JOIN for bot exclusion in AnalyticsActiveCountForPeriod - Use LEFT JOIN for bot exclusion in IsEmpty * Simplify fulltext search by consolidating buildFulltextClause functions Remove convertMySQLFullTextColumnsToPostgres and consolidate buildFulltextClause and buildFulltextClauseX into a single function that takes variadic column arguments and returns sq.Sqlizer. * Simplify SQL stores leveraging PostgreSQL-only support - Simplify UpdateMembersRole in channel_store.go and team_store.go to use UPDATE...RETURNING instead of SELECT + UPDATE - Simplify GetPostReminders in post_store.go to use DELETE...RETURNING - Simplify DeleteOrphanedRows queries by removing MySQL workarounds for subquery locking issues - Simplify UpdateUserLastSyncAt to use UPDATE...FROM...RETURNING instead of fetching user first then updating - Remove MySQL index hint workarounds in ORDER BY clauses - Update outdated comments referencing MySQL - Consolidate buildFulltextClause and remove convertMySQLFullTextColumnsToPostgres * Remove MySQL-specific test artifacts - Delete unused MySQLStopWords variable and stop_word.go file - Remove redundant testSearchEmailAddressesWithQuotes test (already covered by testSearchEmailAddresses) - Update comment that referenced MySQL query planning * Remove MySQL references from server code outside sqlstore - Update config example and DSN parsing docs to reflect PostgreSQL-only support - Remove mysql:// scheme check from IsDatabaseDSN - Simplify SanitizeDataSource to only handle PostgreSQL - Remove outdated MySQL comments from model and plugin code * Remove MySQL references from test files - Update test DSNs to use PostgreSQL format - Remove dead mysql-replica flag and replicaFlag variable - Simplify tests that had MySQL/PostgreSQL branches * Update docs and test config to use PostgreSQL - Update mmctl config set example to use postgres driver - Update test-config.json to use PostgreSQL DSN format * Remove MySQL migration scripts, test data, and docker image Delete MySQL-related files that are no longer needed: - ESR upgrade scripts (esr.*.mysql.*.sql) - MySQL schema dumps (mattermost-mysql-*.sql) - MySQL replication test scripts (replica-*.sh, mysql-migration-test.sh) - MySQL test warmup data (mysql_migration_warmup.sql) - MySQL docker image reference from mirror-docker-images.json * Remove MySQL references from webapp - Simplify minimumHashtagLength description to remove MySQL-specific configuration note - Remove unused HIDE_MYSQL_STATS_NOTIFICATION preference constant - Update en.json i18n source file * clean up e2e-tests * rm server/tests/template.load * Use teamMemberSliceColumns() in UpdateMembersRole RETURNING clause Refactor to use the existing helper function instead of hardcoding the column names, ensuring consistency if the columns are updated. * u.id -> u.Id * address code review feedback --------- Co-authored-by: Mattermost Build <build@mattermost.com>
139 lines
3.9 KiB
JavaScript
139 lines
3.9 KiB
JavaScript
// Copyright (c) 2015-present Mattermost, Inc. All Rights Reserved.
|
|
// See LICENSE.txt for license information.
|
|
|
|
const mapKeys = require('lodash.mapkeys');
|
|
|
|
function convertKeysToLowercase(obj) {
|
|
return mapKeys(obj, (_, k) => {
|
|
return k.toLowerCase();
|
|
});
|
|
}
|
|
|
|
function getKnexClient({client, connection}) {
|
|
return require('knex')({client, connection});
|
|
}
|
|
|
|
// Reuse DB client connection
|
|
let knexClient;
|
|
|
|
const dbGetActiveUserSessions = async ({dbConfig, params: {username, userId, limit}}) => {
|
|
if (!knexClient) {
|
|
knexClient = getKnexClient(dbConfig);
|
|
}
|
|
|
|
const maxLimit = 50;
|
|
|
|
try {
|
|
let user;
|
|
if (username) {
|
|
user = await knexClient('users').where('username', username).first();
|
|
user = convertKeysToLowercase(user);
|
|
}
|
|
|
|
const now = Date.now();
|
|
const sessions = await knexClient('sessions').
|
|
where('userid', user ? user.id : userId).
|
|
where('expiresat', '>', now).
|
|
orderBy('lastactivityat', 'desc').
|
|
limit(limit && limit <= maxLimit ? limit : maxLimit);
|
|
|
|
return {
|
|
user,
|
|
sessions: sessions.map((session) => convertKeysToLowercase(session)),
|
|
};
|
|
} catch (error) {
|
|
const errorMessage = 'Failed to get active user sessions from the database.';
|
|
return {error, errorMessage};
|
|
}
|
|
};
|
|
|
|
const dbGetUser = async ({dbConfig, params: {username}}) => {
|
|
if (!knexClient) {
|
|
knexClient = getKnexClient(dbConfig);
|
|
}
|
|
|
|
try {
|
|
const user = await knexClient('users').where('username', username).first();
|
|
|
|
return {user: convertKeysToLowercase(user)};
|
|
} catch (error) {
|
|
const errorMessage = 'Failed to get a user from the database.';
|
|
return {error, errorMessage};
|
|
}
|
|
};
|
|
|
|
const dbGetUserSession = async ({dbConfig, params: {sessionId}}) => {
|
|
if (!knexClient) {
|
|
knexClient = getKnexClient(dbConfig);
|
|
}
|
|
|
|
try {
|
|
const session = await knexClient('sessions').
|
|
where('id', '=', sessionId).
|
|
first();
|
|
|
|
return {session: convertKeysToLowercase(session)};
|
|
} catch (error) {
|
|
const errorMessage = 'Failed to get a user session from the database.';
|
|
return {error, errorMessage};
|
|
}
|
|
};
|
|
|
|
const dbUpdateUserSession = async ({dbConfig, params: {sessionId, userId, fieldsToUpdate = {}}}) => {
|
|
if (!knexClient) {
|
|
knexClient = getKnexClient(dbConfig);
|
|
}
|
|
|
|
try {
|
|
let user = await knexClient('users').where('id', userId).first();
|
|
if (!user) {
|
|
return {errorMessage: `No user found with id: ${userId}.`};
|
|
}
|
|
|
|
delete fieldsToUpdate.id;
|
|
delete fieldsToUpdate.userid;
|
|
|
|
user = convertKeysToLowercase(user);
|
|
|
|
await knexClient('sessions').
|
|
where('id', '=', sessionId).
|
|
where('userid', '=', user.id).
|
|
update(fieldsToUpdate);
|
|
|
|
const session = await knexClient('sessions').
|
|
where('id', '=', sessionId).
|
|
where('userid', '=', user.id).
|
|
first();
|
|
|
|
return {session: convertKeysToLowercase(session)};
|
|
} catch (error) {
|
|
const errorMessage = 'Failed to update a user session from the database.';
|
|
return {error, errorMessage};
|
|
}
|
|
};
|
|
|
|
const dbRefreshPostStats = async ({dbConfig}) => {
|
|
if (!knexClient) {
|
|
knexClient = getKnexClient(dbConfig);
|
|
}
|
|
|
|
try {
|
|
await knexClient.raw('REFRESH MATERIALIZED VIEW posts_by_team_day;');
|
|
await knexClient.raw('REFRESH MATERIALIZED VIEW bot_posts_by_team_day;');
|
|
|
|
return {
|
|
success: true,
|
|
};
|
|
} catch (error) {
|
|
const errorMessage = 'Failed to refresh post statistics materialized views.';
|
|
return {error, errorMessage};
|
|
}
|
|
};
|
|
|
|
module.exports = {
|
|
dbGetActiveUserSessions,
|
|
dbGetUser,
|
|
dbGetUserSession,
|
|
dbUpdateUserSession,
|
|
dbRefreshPostStats,
|
|
};
|