222 commits

Author	SHA1	Message	Date
sabril	5e1cadac42	fix: MM-T388 E2E tests (#35470)	2026-03-04 19:41:55 +08:00
Nick Misasi	11b4428fc3	[MM-67605] Add DCR redirect URI allowlist for OAuth DCR (#35291) (#35394) ... * [MM-67605] Add DCR redirect URI allowlist enforcement Introduce ServiceSettings.DCRRedirectURIAllowlist with glob-based validation and enforce it during OAuth dynamic client registration to block unapproved redirect URIs. Add System Console wiring and tests for config validation, wildcard matching semantics, API error behavior, and localhost wildcard support. * Fix pre-commit checks: TypeScript type assertion, gofmt, and regenerate CI artifacts - admin_definition_dcr_allowlist.test.tsx: Add AdminDefinitionSettingInput type assertion for 'multiple' property - oauth_dcr_test.go: Fix comment spacing (gofmt) - Regenerate mocks, go.sum, gen-serialized, mmctl-docs per CI requirements * Revert unnecessary pre-commit regenerations Revert mmctl docs, mocks, go.sum, and gen-serialized to master. Keep only the TypeScript and gofmt fixes from the previous commit. * Fix import order in admin_definition_dcr_allowlist.test.tsx * Fix i18n * Update server/public/model/oauth_dcr.go * Fix --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Eva Sarafianou <eva.sarafianou@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2026-02-20 18:28:41 +02:00
Mattermost Build	e6e3ef395b	E2E/Test: Increase parallel tests and removed smoke tests (#35271) (#35367) ... * test: increase parallel tests and removed smoke tests both in cypress and playwright * add duration and retest info * indicate overall, first-pass and re-run run and test durations (cherry picked from commit 0ec4a474d5) Co-authored-by: sabril <5334504+saturninoabril@users.noreply.github.com>	2026-02-19 03:42:07 +00:00
Mattermost Build	6a8f3e4cdc	Autotranslation Frontend integration (#34717) (#35235) ... * AutoTranslate config settings * comment out Agents provider * Add auto translate timeout config validation * i18n messages for autotranslation config validation * fix test * validate url for libreTranslate * Feedback review * Admin Console UI for Auto-Translation * fix admin console conditional section display * i18n * removed unintentional change * update admin.general.localization.autoTranslateProviderDescription newline * fix lint * Fix types * UX feedback review * fix typo in i18n * Fix AutoTranslation feature flag * feedback review * Fix test default values * feedback review * re-add isHidden property to feature discovery * Database Migrations, Indexes and Methods for Auto-Translation * i18n * fix retrylayer and storetest * Fix search query * fix lint * remove the request.CTX and modify Translation model * fix lint and external url * Add settings to playwright * Add empty as a valid value for the Provider * Update jsonb queries * Fix queries and add model methods * fix go lint * go lint fix 2 * fix db migrations * feedback review + store cache * increase migration number * cleanup autotranslation store cache * use NULL as objectType for posts * fix bad merge * fix tests * add missing i18n * Active WebSocket Connection User Tracking * copilot feedback and fix styles * remove duplicate calls * remove early return to mitigate timing attacks * Switch prop bags column to boolean * fix lint * fix tests * Remove database search * use Builder methods * review feedback * AutoTranslation interface with Core Translation Logic * update timeouts to use short/medium/long translations * external exports * add configured languages to autotranslations * added post prop for detected language * fix bugs for storing translation and call translation service * clean up interface * add translations to GetPost repsonses and in the create post response * use metadata for translation information and add new column for state of a translation * change websocket event name * change metadata to a map * single in memory queue in the cluster leader * remove unused definition * Revert "remove unused definition" This reverts commit e3e50cef30. * remove webhub changes * remove last webhub bit * tidy up interface * Frontend integration * tidy up * fix api response for translations * Add Agents provider for auto translations (#34706) * Add LLM backed autotranslation support * Remove AU changes * Remove orphaned tests for deleted GetActiveUserIDsForChannel The GetActiveUserIDsForChannel function was removed from PlatformService as part of the autotranslations refactoring, but its tests were left behind causing linter/vet errors. This removes the orphaned test code: - BenchmarkGetActiveUserIDsForChannel - TestGetActiveUserIDsForChannel - waitForActiveConnections helper 🤖 Generated with [Claude Code](https://claude.com/claude-code) * Add missing i18n translations and fix linter errors - Add 17 missing translation strings for autotranslation feature - Fix shadow variable declarations in post.go and autotranslation.go - Remove unused autoQueueMaxAge constant - Remove unused setupWithFastIteration test function - Use slices.Contains instead of manual loop - Use maps.Copy instead of manual loop - Remove empty if branch 🤖 Generated with [Claude Code](https://claude.com/claude-code) * Fix tests * Fixes for PR review * add files * Update webapp/channels/src/components/admin_console/localization/localization.scss * fixes * Fixes * Didn't save * Add a translation * Fix translations * Fix shadow err --------- * tidy up code for review * add support for editing posts * i18n-extract * i18n * Rename show translations and add util to get message * Fix get posts, migrations, websockets and configuration styles * Fix CI * i18n-extract * Fix webapp tests * Address UX feedback * i18n-extract * Fix lint * updated shimmer animation, fixed issue with the width on compact icon buttons * fix migrations * fix markdown masking for bold, italics and strikethrough * Address feedback * Add missing changes * Fix and add tests * Fix circular dependencies * lint * lint * lint and i18n * Fix lint * Fix i18n * Minor changes * Add check for whether the channel is translated or not for this user * Fix lint and add missing change * Fix lint * Fix test * Remove uneeded console log * Fix duplicated code * Fix small screen show translation modal * Remove interactions on show translation modal * Disable auto translation when the language is not supported * Fix typo * Fix copy text * Fix updating autotranslation for normal users * Fix autotranslate button showing when it shouldn't * Fix styles * Fix test * Fix frontend member related changes * Revert post improvements and remove duplicated code from bad merge * Address feedback * Fix test and i18n * Fix e2e tests * Revert lingering change from post improvements * Fix lint --------- (cherry picked from commit 1c7246da68) Co-authored-by: Daniel Espino García <larkox@gmail.com> Co-authored-by: Elias Nahum <nahumhbl@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: BenCookie95 <benkcooke@gmail.com> Co-authored-by: Nick Misasi <nick.misasi@mattermost.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Matthew Birtch <mattbirtch@gmail.com>	2026-02-11 15:49:30 +05:30
sabril	bffe406e9f	(chore): upgrade playwright and its dependencies (#35175)	2026-02-09 21:30:07 +08:00
Daniel Espino García	2bd29c0359	Add the ability to patch channel autotranslations (#35078) ... * Add the ability to patch channel autotranslations * Fix lint * Update docs * Fix CI * Fix CI * Fix mmctl test * Check whether the channel is translated for the user when checking user enabled * Fix wrong uses of patch acrros e2e and frontend * Fix test * Fix wording * Fix tests and column name * Move group constrained test so they don't mess with the basic entities * Fix patch sending too much information	2026-02-06 18:19:06 +01:00
sabril	e499decea0	(test): fix flaky and migrate to playwright (#35156)	2026-02-04 12:21:17 +08:00
Ben Cooke	36479bd721	Configurable workers and move sweeper job to job infra (#35007)	2026-02-02 15:52:42 -05:00
sabril	981ff0bc46	MM-66362 feat: run e2e full tests after successful smoke tests both in cypress and playwright (#34868) ... * feat: run e2e full tests after successful smoke tests both in cypress and playwright * fix lint check on jsdoc req in playwright test * update smoke test filter * update test filter for cypress tests * update docker services, fix branch convention and rearrange secrets * update e2e-test workflow docs * reorganized * fix lint * fix playwright template * fix results assertion * add retest, e2e-test-verified, gh comments of failed tests, path filters, run e2e-tests check first and demote unstable tests * run using master image for e2e-only changes, add ts/js actions for cypress and playwright calculations, add verified by label --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-02-02 08:37:55 +08:00
Ben Cooke	36173a4948	Use one timeout config for requests to translation providers (#34957)	2026-01-29 10:00:22 -05:00
Dylan Haussermann	8e7b3da702	Fixtures that allow install of a plugin from a target repo (#34520) ... * Fixtures that allow install of a plugin from a target repo * Fixed linting error and applied `prettier` formating. * Implemeted feedback from code review * Remove unused AdminConfig import --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-27 21:41:49 +08:00
sabril	3db7477e45	MM-67281: (test) Migrate Enzyme to RTL (#35029) ... * test: migrate enzyme to rtl * replace renderWithIntl with renderWithContext * remove jest.clearAllMocks * use userEvent * fix unrelated lint error	2026-01-27 12:22:13 +08:00
Ben Cooke	a1c85007e1	Autotranslations MVP (#34696) ... --------- Co-authored-by: Elias Nahum <nahumhbl@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Nick Misasi <nick.misasi@mattermost.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Matthew Birtch <mattbirtch@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-26 17:05:34 -05:00
Matthew Birtch	09c4a61fed	[MM-67030] Remove newsletter signup and replace with terms/privacy agreement (#34801) ... * remove newsletter signup and replace with terms/privacy agreement * removed subscribeToSecurityNewsletter, made checkbox required * update signup test to remove newsletter and ensure the terms checkbox is required * update unit test and e2e test to reflect changes * fix e2e test * Removed susbcribe-newsletter endpoint in server * Update signup.test.tsx * remove unused css * remove unused css * fixed broken tests * fixed linter issues * Remove redundant IntlProvider and comments * Remove usage of test IDs from Signup tests * Remove usage of fireEvent * Remove usage of mountWithIntl from Signup tests * update e2e tests * fix playwright test * Fix Lint in signup.ts --------- Co-authored-by: maria.nunez <maria.nunez@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> Co-authored-by: yasserfaraazkhan <attitude3cena.yf@gmail.com>	2026-01-23 18:24:27 +00:00
sabril	66e5ab4c5e	E2E/Test Playwright upgrade (#35008) ... * chore: playwright upgrade * add luxon and chalk as dependency, and relax peer dependency to @playwright/test with >=1.55.0 --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-23 12:11:27 +08:00
sabril	3ebc90bde0	fix: E2E/Tests related to create account and invite people (#34953) ... * fix: e2e tests related to create account and invite people * fix failed test	2026-01-20 11:59:47 -04:00
sabril	0a12ca2f7d	E2E/Playwright: Reorganize user and team creation (#34912) ... * pw: reorganize user and team creation * fix types and lint	2026-01-16 13:11:27 +08:00
Nick Misasi	0885f56010	Add optional Claude.md orchestration for Webapp folder (#34668) ... * Add CLAUDE.md documentation files for webapp directories - Add root webapp CLAUDE.md with overview and build commands - Add channels CLAUDE.md with architecture and testing info - Add documentation for actions, components, selectors, utils - Add documentation for sass, tests, and mattermost-redux - Add platform documentation for client and types - Update .gitignore * Add CLAUDE docs and allow tracking * Clarify CLAUDE instructions for i18n workflow * Refactor webapp/CLAUDE.md into a nested hierarchy Decomposed the monolithic webapp/CLAUDE.md into focused, context-aware files distributed across the directory structure: - webapp/CLAUDE.md (Root overview) - webapp/channels/CLAUDE.md (Channels workspace) - webapp/channels/src/components/CLAUDE.md - webapp/channels/src/actions/CLAUDE.md - webapp/channels/src/selectors/CLAUDE.md - webapp/channels/src/packages/mattermost-redux/CLAUDE.md - webapp/platform/CLAUDE.md (Platform workspace) - webapp/platform/client/CLAUDE.md * Move files to optional, then add script to move them to proper claud.md	2026-01-14 13:04:20 -05:00
Scott Bishel	cc2b47bc9b	MM-66561 Add distinct archive icon for private channels (#34736) ... * MM-66561 Add distinct archive icon for private channels Archived private channels now display an archive-lock icon instead of the standard archive icon to better indicate their original privacy level. Implemented utility functions to centralize icon selection logic across all channel list views, sidebars, headers, and suggestion providers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * MM-66561 Fix linting and TypeScript errors Fix ESLint and TypeScript issues introduced in the archive icon implementation: - Remove extra blank lines to comply with no-multiple-empty-lines rule - Remove unused container variables in test files - Fix import order to comply with import/order rule - Remove unused React import - Fix TypeScript type errors by using General.OPEN_CHANNEL/PRIVATE_CHANNEL from mattermost-redux/constants which preserves literal types 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * MM-66561 Fix test failures for archive icon changes Update test snapshots and fix test data issues related to the new distinct archive icons for public and private channels. - Update snapshots for channel list components to include new channelType prop and data-testid attributes - Fix channel_mention_provider test by preserving actual module exports in mock - Add missing purpose field to searchable_channel_list test data - Fix async state handling in new_channel_modal test using waitFor instead of act 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * MM-66561 Fix remaining Cypress E2E test failures for archive icons Fix three failing Cypress tests related to archive icon changes: 1. join_archived_channel_spec.ts (MM-T1682, MM-T1683) - Add data-testid to archive icon in channel header - Update test to use findByTestId instead of CSS class selector - Compass icon components render as SVG, not <i> with classes 2. archived_channels_spec.js (system console tests) - Add "000-" prefix to private channel name/display name - Ensures proper alphabetical sorting on first page of results 3. long_draft_spec.js (MM-T211) - Fix Cypress alias timing issues in nested then() callbacks - Use local variable to track height changes during iteration - Replace cy.get('@alias').should() with direct expect() assertions All tests now pass with the distinct archive icons for private channels. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * fix lint issue * MM-66561 Refine archive icon styling and search results display - Restore CSS classes on channel header icon for proper color and size - Fix icon alignment by removing top offset in channel header context - Replace "Archived" text with icon-only tooltip in search results - Add context-specific styling to prevent conflicts between header and search 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * tweaks to css and move withtooltip to wrap the span * lint fix * lint fix * Fix archived channel icons visual test API usage Update test to use correct Playwright API patterns: - Use adminClient.createChannel with pw.random.channel for channel creation - Use adminClient.deleteChannel instead of pw.apiClient.deleteChannel - Use pw.testBrowser.login(adminUser) instead of loginAsAdmin - Remove channelsPage.toBeVisible check for archived channels since they lack post-create element Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Apply prettier formatting to archived channel icons test Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> * Fix timing issue in MM-T633 Elasticsearch webhook attachment search test The test was intermittently failing because it searched immediately after posting the webhook, before Elasticsearch had time to index the new post. Added explicit wait for post to appear and increased indexing wait time to 3 seconds to ensure the attachment text is indexed before performing the search. Co-Authored-By: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 (1M context) <noreply@anthropic.com> Co-authored-by: Matthew Birtch <mattbirtch@gmail.com>	2026-01-14 15:35:27 +00:00
sabril	dab04576a1	MM-66972 Upgrade to node 24 and main dependencies with babel, webpack and jest (#34760) ... * chore: upgrade to node 24 and dependencies mainly with babel, webpack and jest * fix components tests, make trial modal passed on all node 20-24 * fix cache for platform packages * updated test --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-14 13:14:01 +08:00
M-ZubairAhmed	43bab4d7c7	[MM-67025] Add new E2E for testing keyboard shortcut Shift+Up (#34793) ... * add e2e test for Shift+Up keyboard shortcut in center channel * Update dependencies in package-lock.json * Update package-lock.json * Update package-lock.json --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2026-01-12 13:01:14 +08:00
sabril	0b0658bdd0	chore: upgrade playwright to 1.57 and its dependencies (#34769) ... * chore: upgrade playwright to 1.57 and its dependencies * bump webapp's npm to accept ^11.0.0 * updated per comment * fix failed tests	2026-01-09 10:48:19 +08:00
Pablo Vélez	1a21d34aab	MM-66925 - improve user email and password modals (#34739) ... * MM-66925 - improve user email and password modals * adjust error modal styling * adjust e2e tests	2025-12-19 15:52:59 +01:00
sabril	d7aebb555d	fix flaky notifications tests and migrated to playwright (#34449) ... Co-authored-by: Mattermost Build <build@mattermost.com>	2025-12-17 06:51:20 +00:00
Elias Nahum	4589005a54	feat: Add Microsoft Intune MAM authentication support (#34577) ... * Add Entra ID token authentication and Intune MAM config exposure * Add Intune MAM toggle to Mobile Security admin console * Add IntuneSettings with the AuthService to use and its own TenantID andClientID for the Entra App registration Include Admin console changes switch from /oauth/entra to /oauth/intune endpoint * openAPI documentation --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: yasser khan <attitude3cena.yf@gmail.com>	2025-12-10 08:31:53 +02:00
Harrison Healey	5341b91566	MM-66659/MM-66832 Remove caretPosition state from AdvancedTextEditor (#34643) ... * Mock react-virtualized-auto-sizer in all unit tests to ensure contents are mounted Without mocking that, anything inside of an `AutoSizer` wouldn't be rendered at all, leading to weird behaviour like the emoji picker being empty in tests. * Fix EmojiPickerCategoryRow not having a defaultMessage This caused any unit tests involving the emoji picker to error unless you also provided an intlMessages object which is hard to do due to how Jest's `moduleNameMapper` option is configured currently. * Fixed incorrect usage of useCallback in EmojiPickerItem The way this was previously written, we weren't specifying dependencies properly for those callbacks which lead to some actual performance issues because of how heavy the emoji picker is, and it also lead to issues where click handlers would have to be triggered multiple times in unit tests for some reason. * MM-66659 Stop using caretPosition in useEditorEmojiPicker This bug seems to be caused by a race condition between React and Chrome which only occurs on Windows and only now that we've upgraded to React 18. That race condition occurs with how we map the selection range in the post textbox to its `caretPosition` state. That state has always been pretty janky, so I've decided to remove it. This also has some other benefits like improving UX by using `execCommand` which preserves the undo/redo stack when using the emoji picker and simplifying the code because we no longer have to manually mess with the cursor position. Also, while I was in there, I fixed some minor weirdness around how whitespace is handled when adding those emojis. * MM-66659 Stop using caretPosition in useKeyHandler * MM-66659 Stop using caretPosition for prefill message * MM-66659 Remove remaining traces of caretPosition in AdvancedTextEditor * Fix exclusive test * Fix "Fixed incorrect usage of useCallback in EmojiPickerItem" * Fixed incorrect usage of FixedSizeList in emoji picker This is the actual fix to the issue I thought I fixed previously by changing how `useCallback` was called in EmojiPickerItem. It turns out the actual issue is that we were passing a new function as the child of FixedSizeList on every render cycle which caused it to re-render all of the rows which somehow also assigned them new DOM Nodes as well. The EmojiPicker re-renders whenever we mouse over an emoji, so it would re-render the FixedSizeList and all of its children frequently when mousing over things. Apart from causing performance issues, that also seems to cause RTL to fail to click on an emoji the first time you call `userAgent.click` because the first call would move the mouse which would trigger a re-render, and that would seemingly cause RTL to forget what to click on. To fix that, I used a new React context to pass the extra props to the EmojiPickerCategoryOrEmojiRow. I could've also done that by adding them to the FixedSizeList's `itemData` prop, but that already contains a lot of heavy data, and I didn't want to add to that. * Revert changes to postMessageOnKeyPress * Run Prettier in playwright folder * Added docs to new Playwright test * Address feedback	2025-12-09 14:10:06 +00:00
Rohan Sharma	e905a36110	migrate display_test branch (#34516)	2025-11-25 23:02:19 +08:00
Dylan Haussermann	c8c28c1b9a	Add E2E test for unreads filter functionality (#34198) ... * Add E2E test for unreads filter functionality * implemented code review suggestions as folows: * Removed redundant `waitFor` --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-20 14:40:14 -05:00
Rahim Rahman	edb05c7ea5	Magic link (passwordless) authentication for guests (#34264) ... * Add EasyLogin configuration (#34217) * add easy login config * add easy login to the invite modal * add to the query parameters * Add an API to get login method for the login id (#34223) * add an api to get login method for the login id * do not return errors if user is not found * Add support for Easy Login invitation link sending (#34224) This generates Easy Login token types when requested. The server doesn't do anything with these tokens, yet - that will come in a future change. * Add support for logging in with easy login (#34236) * Fix E2E tests (#34240) * Prevent easy login accounts to reset their password (#34262) * Add easy login support to login api and limit token to 5 min (#34259) * webapp easy login ui mods (#34237) * webapp easy login ui mods * easy login i18n * lint issues * getUserLoginType * using the real API * easylogin proper redirect * remove unneeded functions and files * duplicated localization * remove easylogin * using EnableEasyLogin setting * localization fix * fix lint issue * remove excessive setIsWaiting * changed logic to make it more readable * renaming component to make easier editable * password will disappear when username change * login test * text for easy login password * Add app links to emails * Update templates and always land in the landing screen * Update svg image, improve checks on server, fix linking page and show deactivated on login type * Update naming * Fix mocks and imports * Remove all sessions on disable and forbid user promotion * Fix layer and tests * Address feedback * Fix tests * Fix missing string * Fix texts * Fix tests * Fix constant name * Fix tests * Fix test * Address feedback * Fix lint * Fix test * Address feedback * Fix test --------- Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: David Krauser <david@krauser.org> Co-authored-by: Daniel Espino <larkox@gmail.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-20 14:06:23 +01:00
Carlos Garcia	4ba7f7e16e	MM-66202: Migrate to aws-sdk-go-v2 (#34496) ... * updated aws-sdk dependency to aws-sdk-go-v2 * simplify error handling in case of timeout errors --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-20 11:26:09 +01:00
yasser khan	b8944f372d	Feat(e2e): Add tests cases for Content Flagging (#34288) ... - E2E tests for Content Flagging - Fixes tests failing on master	2025-11-19 10:16:57 +00:00
yasser khan	59b3b5797d	Fix failing playwright tests (#34535)	2025-11-19 06:06:56 +00:00
sabril	c40f6ee749	MM-65043 Add option to run E2E tests with FIPS build (#34318) ... * add option to run fips build * modify gh comments * organize gh and commit status * sanitize inputs, handle group concurrency * indicate fix in status context and fix comparison * handle fips comparison * updated per comments * reverted missed lines * fix failed cypress test by migrating to playwright --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-13 12:20:21 +08:00
Eva Sarafianou	0d181ca215	Push Proxy Authentication (#34211) ... * Initial Implementation of Push Proxy Authentication * Include Config Listener for Leader plus delete startup function as job scheduler runs on initialization * Remove push proxy auth from local imports * Add push proxy auth to external imports * Add push proxy auth error messages * Update error codes * Fix enterprise dep definition * make i18n-extract * Mock System store Get * m * m * m * m * Update serverID header * Add install type env var to docker * Update Push Proxy config with new options Global, US, Germany and Japan. Previous configurations will keep working * use model.SafeDereference * Delete token when new push proxy URL is empty * ServerID header only if auth token is available --------- Co-authored-by: Daniel Schalla <daniel@mattermost.com> Co-authored-by: Nick Misasi <nick.misasi@mattermost.com> Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-12 20:16:44 +02:00
Jesse Hallam	f2ff5511e8	Fix inconsistent terminology for revoking user sessions (#MM-66613) (#34461) ... Changed "Remove sessions" to "Revoke sessions" in System Console menu to match the terminology used in the confirmation modal and API. Also fixed TypeScript error in dropdown_input_hybrid component.	2025-11-12 13:44:54 -04:00
Rohan Sharma	e544214f65	feat: add accessibility tests for advanced settings panel (#34272) ... * feat: add accessibility tests for advanced settings panel * fix: formatting issues --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-11-04 14:30:27 +05:30
sabril	5c43b2ceb3	fix for vscode testing (#34285)	2025-10-27 14:08:50 +00:00
Elias Nahum	595e600eea	MM-65755 Admin Console UI for Auto-Translation (#33982) ... * AutoTranslate config settings * comment out Agents provider * Add auto translate timeout config validation * i18n messages for autotranslation config validation * fix test * validate url for libreTranslate * Feedback review * Admin Console UI for Auto-Translation * fix admin console conditional section display * i18n * removed unintentional change Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update admin.general.localization.autoTranslateProviderDescription newline * fix lint * Fix types * UX feedback review * fix typo in i18n * Fix AutoTranslation feature flag * feedback review * Fix test default values * feedback review * re-add isHidden property to feature discovery * fix lint and external url * Add settings to playwright * Add empty as a valid value for the Provider * Add searchable strings * set apikey input type as password --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>	2025-10-27 11:36:25 +08:00
sabril	b3b5f9d3e3	E2E/Playwright: Upgrade to playwright@1.56 and its dependencies (#34135) ... * upgrade to playwright@1.56 and its dependencies * move audited packages to devdep	2025-10-17 11:41:54 +08:00
sabril	18d2e8da9f	MM-63700 E2E/Playwright: Add accessibility testing guidelines (#33997) ... * add accessibility testing guidelines * use accessibility locators * address comments	2025-10-15 12:00:01 +08:00
Alejandro García Montoro	d3eb6cbf1c	Revert "MM-13657: Set ExperimentalStrictCSRFEnforcement to true by default (#33444)" (#34112) ... * Revert "MM-13657: Set ExperimentalStrictCSRFEnforcement to true by default (#33444)" This reverts commit 257eec43ed. * Fix call to checkCSRFToken * Adapt test that relied on strict CSRF enforcement This test was added after https://github.com/mattermost/mattermost/pull/33444, so it assumed strict CSRF enforcement to be enabled. When reverting that PR, we need to adapt the test to account for both cases. * Fix newer tests to use older setting	2025-10-10 19:15:45 +02:00
Harrison Healey	535d93ee98	MM-45255 Update web app to React 18 (#33858) ... * Dependencies: Remove unused dependency on @mattermost/dynamic-virtualized-list * Update Components package to React 18 and new version of RTL * Upgrade React, React Redux, RTL, and associated libraries I had to upgrade React Redux for the new version of React, and that brought with it new versions of associated packges (Redux, Reselect, Redux Thunk). A few other libraries needed to be updated or have their explicit dependencies overridden for the new version of Redux as well. To note for future dependency upgrades, redux-mock-store is deprecated, and redux-batched-actions and redux-persist are inactive. For RTL: 1. `@testing-library/react-hooks` has been rolled into `@testing-library/react`, and its interface has changed. 2. I had to make some changes to get TS to use the types for the new methods added to `expect`. * Dependencies: Fix dom-accessibility-api patch from #33553 * Tests: Fix tests that use jest.spyOn with react-redux * Functional: Remove usage of defaultProps on function components * Tests: Remove usage of react-dom/test-utils * Functional: Rename conflicting context prop on Apps components * Tests: Always await on userEvent calls * Functional: Patch react-overlays to fix pressing escape in unit tests I did something similar in React Bootstrap a few weeks ago. See https://github.com/mattermost/react-bootstrap/pull/5 * Tests: Prevent tests from fetching from real URLs * Tests: Update snapshots changed by upgrading react-redux and styled-components * Functional: Stop passing deprecated pure parameter to connect * Tests: Change how we intercept console errors in tests to preserve stack traces * Tests: Fix incorrect usage of act in Enzyme tests These tests are a mix of: 1. Not calling act when performing something that will update the DOM (like clicking on a button or invoking a method) which either caused warnings or failed snapshots as changes weren't visible. 2. Calling act in weird ways (such as wrapping mount in an async act) which caused Enzyme to not function Some of these changes just silence warnings, but most of them are required to make the test even run * Tests: Fix incorrect usage of act in RTL tests * Tests: Fix a few minor issues in tests * Functional: Add note for why we're not using ReactDOM.createRoot * Functional: Fix focus trap infinite recursion in test * Types: Replace removed React.SFC * Types: Fix type of functions in FormattedMessage values prop * Functional: Fix DropdownInputHybrid placeholder * Types: Patch type definitions of react-batched-actions * Types: Fix mattermost-redux build failing due to type check in Redux Dev Tools * Dependencies: Add type definitions for react-is * Types: Update types around ReactNode and ReactElement React's gotten more strict with these, so we need to be more careful with what we return from a render method. In some of these places, we also misused some types, so hopefully I've sorted those out. * Types: Explicitly added types to all instances of useCallback * Types/Tests: Update typing of Redux actions and hooks useDispatch is sort of stricter now, but it doesn't seem to rely on the global type of `Dispatch` any more, so I ended up having to add an extra overload to make that work. * Tests: Update new tests in useChannelSystemPolicies for new version of RTL These were added on master after I updated RTL on the branch * Tests: Update action used to test initial store state * Functional: Remove remnants of code for hot reloading Redux store * Types/Tests: Update typing around React Router * Types/Functional: Update typing involving the FormattedMessage values prop There's a couple functional changes to ensure that the value passed is either a valid string or Date * Types: Misc fixes * Functional: Don't pass unused props to ChannelHeader * Functional: Ensure plugin setting text is rendered before passing to Setting component The previous version might've allowed MessageDescriptors to be passed unformatted into the Setting component (which would then be rendered in the DOM). As best as I can tell, we never actually did that, so this shouldn't change anything in practice. * Tests: Make tests for identifyElementRegion more reliable * Tests: Update recent tests for new version of RTL * E2E: Make editLastPostWithNewMessage more reliable * Downgrade React to 18.2.0 and manually dedupe React versions 18.2.0 and 18.3.0 are nearly identical to one another, except 18.3.x includes warnings when using any API that will be removed in React 19. I don't want to flood the console and test logs with warnings for things we're not addressing for the time being. Also, they didn't export act from React itself until 18.3.1 for some reason (despite the old import path printing a warning), so I needed to revert the changes to its import path. To get this all to work, for some reason, I had to manually delete all the entries for `react` and `react-dom` from the lockfile to get NPM to use a single version of React and ReactDOM everywhere. I did discover `npm dedupe` in the process, but that didn't solve this problem where I was trying to consistently downgrade everything. * Revert changes to notice file build tool to speed up CI * Add explicit version of types/scheduler The version of `@types/react` that we use says it works with any version of `@types/scheduler` which causes NPM to install a newer version of it which is missing a file of types that it needs. * Update new test to await on userEvent * Fix Playwright test that relied on autogenerated class name * Tests: Disable test for identifyElementRegion * Functional: Change DynamicVirtualizedList ListItem to use useLayoutEffect In a previous commit, I changed the RHS to use the monorepo DynamicVirtualizedList instead of the old version that lived in its own repo. That caused the RHS to no longer scroll to the bottom on initial mount or be able to render additional pages (even though the posts are loaded). This seems like it has to do with the improved size calculation that Zubair made because that's the main difference in the monorepo version of that component. For some reason I don't entirely understand, changing to useLayoutEffect seems to fix that. I think that's because the old measurement code is written as a class component, and useLayoutEffect fires at the same time as componentDidMount/componentDidUpdate. * Types: Revert some type changes to reduce test log output * Functional: Fix places where useSelector returned new results when called with the same arguments I wasn't planning on fixing this now, but I think the increased length of the warning logs in the tests are causing the GitHub action for the unit tests to abort as it reaches around 10000 lines long. * Tests: Fix place where mocked selector returned new results when called with the same arguments Same reason as before, but this one only occurred because of a test's mocked selector. I replaced it with a real one to get around that. * Tests: Fail tests when selector returns new results when called with the same arguments * Attempt to fix web app unit tests failing in CI * Change CI tests to set workerIdleMemoryLimit instead of reducing maxWorkers * Increase workerIdleMemoryLimit in CI * Revert changes to test-ci command and revert changes to how unit test logs are collected * Unrevert changes to test logging, re-add workerIdleMemoryLimit, and try disabling test coverage * Actually disable coverage * Fix flaky test * Update a couple new tests to fit PR and remove an unnecessary act * Replace bad mock in new unit test * Fix types of new code * Remove mock from new unit test	2025-10-07 11:11:12 -04:00
JG Heithcock	df1c2920de	MM-65126: Allow admins to change CPA values for users from the system console (#33984) ... * Update system_user_detail to enable editing of User Attributes - This adds a `updateUserCustomProfileAttributesValues` method to client4 to allow updating attributes for a given userID, as a match to getUserCustomProfilesAttributesValues - Fixed issue in saveCustomProfileAttributes where it used the version that did not take the passed in userId * Fixes for tests * Update saveCustomProfileAttribute mock in users.test.ts The `saveCustomProfileAttribute` test was still using the old getCustomProfileAttributeValuesRoute instead of the same route that `getCustomProfileAttributeValues` uses. * Adding e2e tests for editing User attributes (custom and system) in System Console * Fix testing issue with selector for 'Authentication Method' * workflows/server-ci-report.yml: security fixes by validating inputs (#33892) * [MM-61899] Properly restrict users who previously shared a team from DMs/GMs when they no longer share a team. (#30094) * [MM-61899] Properly restrict users who previously shared a team from DMs/GMs when they no longer share a team. * Fix checks * Fix test * Fix i18n * Added E2E tests * Merge'd * Add restricted DM check to more places * Merge'd * Restrict patching the channel (updating the channel) * Update verbiage in the admin console * Fix lint * More tests --------- Co-authored-by: Mattermost Build <build@mattermost.com> * Mirror Postgres 14 docker image (#34009) * ugprade to go 1.24.6 (#34004) * Bump Postgres minimum supported version to 14 (#34010) * Downgrade French language (#33826) * Downgrade French language * Update i18n.jsx * Updates buildFieldAttrs to preseve existing attrs when editing a field (#33991) * Updates buildFieldAttrs to preseve existing attrs when editing a field * Fix preserve option issue for select/multiselect type fields * Fix linter --------- Co-authored-by: Miguel de la Cruz <miguel@ctrlz.es> * MM-64423 - Removing the clear func on switch (#31214) * MM-64423 - Removing the clear func on switch * Select all teams by default * Updating test * Updating test * Removing showFilterHaveBeenReset * Removing search string * Do not clear the search term * Updating tests --------- Co-authored-by: Mattermost Build <build@mattermost.com> * Mm 65123 remove channel abac ff (#33953) * MM-65123 - remove channel abac feature flag * enable the channel scope access control to true * fix linters * adjust expected error in tests * remove no longer needed comment * Remove write_restrictable from core ABAC settings and fix channel access control logic --------- Co-authored-by: Mattermost Build <build@mattermost.com> * [MM-65837], [MM-65824] - Update Dependencies (#33972) * Update github.com/mholt/archives * Update github.com/spf13/viper * make batch migration worker tests less flaky --------- Co-authored-by: Jesse Hallam <jesse@mattermost.com> * (a11y-test): team menu (#33998) * MM-66071: Do not error on empty slice in /groups/names (#34021) * Do not error on empty slice in /groups/names If group_names is an empty slice, this should not be an invalid parameter. We return what we were asked for: an empty array. * Avoid requests to /groups/names if list is empty If the list of group names is empty, we do not need to ask the server for the corresponding groups: we already know it'll be an empty list. * Fix ABAC not available for entry (#34027) Automatic Merge * Explicitly name Postgres container volume (#33954) * Explicitly name Postgres container volume * Remove unused server/docker-compose.yaml This file doesn't seem to actually be used. When we run docker compose locally, it uses docker-compose.makefile.yml merged with the output of build/docker-compose-generator/main.go. * Revert "Remove unused server/docker-compose.yaml" This reverts commit 5a45965217. * Update volume name * Flag post API (#33765) * Added enable/disable setting and feature flag * added rest of notifgication settings * Added backend for content flagging setting and populated notification values from server side defaults * WIP user selector * Added common reviewers UI * Added additonal reviewers section * WIP * WIP * Team table base * Added search in teams * Added search in teams * Added additional settings section * WIP * Inbtegrated reviewers settings * WIP * WIP * Added server side validation * cleanup * cleanup * [skip ci] * Some refactoring * type fixes * lint fix * test: add content flagging settings test file * test: add comprehensive unit tests for content flagging settings * enhanced tests * test: add test file for content flagging additional settings * test: add comprehensive unit tests for ContentFlaggingAdditionalSettingsSection * Added additoonal settings test * test: add empty test file for team reviewers section * test: add comprehensive unit tests for TeamReviewersSection component * test: update tests to handle async data fetching in team reviewers section * test: add empty test file for content reviewers component * feat: add comprehensive unit tests for ContentFlaggingContentReviewers component * Added ContentFlaggingContentReviewersContentFlaggingContentReviewers test * test: add notification settings test file for content flagging * test: add comprehensive unit tests for content flagging notification settings * Added ContentFlaggingNotificationSettingsSection tests * test: add user profile pill test file * test: add comprehensive unit tests for UserProfilePill component * refactor: Replace enzyme shallow with renderWithContext in user_profile_pill tests * Added UserProfilePill tests * test: add empty test file for content reviewers team option * test: add comprehensive unit tests for TeamOptionComponent * Added TeamOptionComponent tests * test: add empty test file for reason_option component * test: add comprehensive unit tests for ReasonOption component * Added ReasonOption tests * cleanup * Fixed i18n error * fixed e2e test lijnt issues * Updated test cases * Added snaoshot * Updated snaoshot * lint fix * WIP * lint fix * Added post flagging properties setup * review fixes * updated snapshot * CI * Added base APIs * Fetched team status data on load and team switch * WIP * Review fixes * wip * WIP * Removed an test, updated comment * CI * Added tests * Added tests * Lint fix * Added API specs * Fixed types * CI fixes * API tests * lint fixes * Set env variable so API routes are regiustered * Test update * term renaming and disabling API tests on MySQL * typo * Updated store type definition * Minor tweaks * Added tests * Removed error in app startup when content flaghging setup fails * Updated sync condition: * Flag message modal basE * added post preview * displaying options * Adde comment input * Updated tests and docs * finction rename * WIP * Updated tests * refactor * lint fix * MOved to data migration * lint fix * CI * added new migration mocks * Used setup for tests * some comment * Removed unnecesseery nil check * Form validation * WIP tests * WIP tests * WIP tests * fix: mock content flagging config selector with correct reasons format Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <aider@aider.chat> * fix: add mock for getContentFlaggingConfig in flag post modal test Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <aider@aider.chat> * Updated error code order in API docs * removed empty files * Added tests * lint fixes * minor tweak * lint fix * type fix * fixed test * nit * test enhancements * API WIP * API WIP * creating values * creating content flagging channel and properties * Able to save properties * Added another property field * WIP * WIP * Added validations * Added data validations and hidden post if confifgured to * lint fixes * Added API spec * Added some tests * Added tests for getContentReviewBot * test: add comprehensive tests for getContentReviewChannels function * Added more app layer tests * Added TestCanFlagPost * test: Add comprehensive tests for FlagPost function * Added all app layer tests * Removed a file that was reamoved downstream * test: add content flagging test file * test: add comprehensive tests for FlagContentRequest.IsValid method * Added model tests * test: add comprehensive tests for SqlPropertyValueStore.CreateMany * test: add comprehensive tests for flagPost() API function * Added API tests * linter fix * WIP * sent post flagging confirmation message * fixed i18n nissues * fixed i18n nissues * CI * Updated test * fix: reset contentFlaggingGroupId for test isolation in content flagging tests * removed cached group ID * removed debug log * review fixes * Used correct ot name * CI * Updated mobile text * Handled JSON error * fixerdf i18n * CI * Integrate flag post api (#33798) * WIP * WIP * Added API call * test: add test for Client4.flagPost API call in FlagPostModal * fix: remove userEvent.setup() from flag post modal test * test: wrap submit button click in act for proper state updates * Updated tests * lint fix * CI * Updated to allow special characters in comments * Handled empty comment * Used finally * CI * Fixed test * Spillage card integration (#33832) * Created getContentFlaggingFields API * created getPostPropertyValues API * WIP * Created useContentFlaggingFields hook * WIP * WIP * Added option to retain data for reviewers * Displayed deleted post's preview * DIsplayed all properties * Adding field name i18n * WIP - managing i18n able texts * Finished displaying all fields * Manual cleanup * lint fixes * team role filter logic fix * Fixed tests * created new API to fetch flagged posts * lint fix * Added new client methods * test: add comprehensive tests for content flagging APIs * Added new API tests * fixed openapi spec * Fixed DataSpillageReport tests * Fixed PostMarkdown test * Fixed PostPreviewPropertyRenderer test * Added metadata to card renderer * test fixes * Added no comment placeholder * Fixed test * refactor: improve test mocking for data spillage report component * test mock updates * Updated reducer * not resetting mocks * WIP * review fixes * CI * Fixed * fixes * Content flagging actions implementation (#33852) * Added view detail button * Created RemoveFlaggedMessageConfirmationModal modal * Added key and remove flag request modal * IMplemented delete flagged post * Handled edge cases of deleting flagged post * keep message * UI integration * Added WS event for post report update and handled deleted files of flagged post * Added error handling in keep/remove forms * i18n fixes * Updated OpenAPI specs * fixed types * fixed types * refactoring * Fixed tests * review fixes * Added new property translations * Improved test * fixed test * CI * fixes * CI * fixed a test * CI --------- Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <aider@aider.chat> * GH-34031: Add accessibility tests for Sidebar settings panel (#34041) * Add accessibility tests for Sidebar settings panel * Add aria snapshots and fix accessibility test expectations for sidebar settings * Update system_user_detail to enable editing of User Attributes - This adds a `updateUserCustomProfileAttributesValues` method to client4 to allow updating attributes for a given userID, as a match to getUserCustomProfilesAttributesValues - Fixed issue in saveCustomProfileAttributes where it used the version that did not take the passed in userId * Fixes for tests * Update saveCustomProfileAttribute mock in users.test.ts The `saveCustomProfileAttribute` test was still using the old getCustomProfileAttributeValuesRoute instead of the same route that `getCustomProfileAttributeValues` uses. * Adding e2e tests for editing User attributes (custom and system) in System Console * Fix testing issue with selector for 'Authentication Method' * Fixes from PR suggestions * Fix lint/export issues * Fix playwright lint issue halting e2e smoke test * Results from npm run prettier:fix (in e2e-tests/playwright folder) --------- Co-authored-by: Mattermost Build <build@mattermost.com> Co-authored-by: Ibrahim Serdar Acikgoz <serdaracikgoz86@gmail.com> Co-authored-by: Devin Binnie <52460000+devinbinnie@users.noreply.github.com> Co-authored-by: Alejandro García Montoro <alejandro.garciamontoro@gmail.com> Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Amy Blais <29708087+amyblais@users.noreply.github.com> Co-authored-by: Miguel de la Cruz <miguel@mcrx.me> Co-authored-by: Miguel de la Cruz <miguel@ctrlz.es> Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com> Co-authored-by: Pablo Vélez <pablovv2012@gmail.com> Co-authored-by: Eva Sarafianou <eva.sarafianou@gmail.com> Co-authored-by: Jesse Hallam <jesse@mattermost.com> Co-authored-by: sabril <5334504+saturninoabril@users.noreply.github.com> Co-authored-by: Maria A Nunez <maria.nunez@mattermost.com> Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com> Co-authored-by: Harshil Sharma <18575143+harshilsharma63@users.noreply.github.com> Co-authored-by: aider (anthropic/claude-sonnet-4-20250514) <aider@aider.chat> Co-authored-by: Mudit Sharma <ms1725@srmist.edu.in>	2025-10-06 15:41:29 -07:00
Mudit Sharma	2032f6f22a	GH-34031: Add accessibility tests for Sidebar settings panel (#34041) ... * Add accessibility tests for Sidebar settings panel * Add aria snapshots and fix accessibility test expectations for sidebar settings	2025-10-03 10:45:09 -04:00
sabril	5d6846374c	(a11y-test): team menu (#33998)	2025-10-02 13:41:50 +08:00
Pablo Vélez	b311da87a4	Mm 65123 remove channel abac ff (#33953) ... * MM-65123 - remove channel abac feature flag * enable the channel scope access control to true * fix linters * adjust expected error in tests * remove no longer needed comment * Remove write_restrictable from core ABAC settings and fix channel access control logic --------- Co-authored-by: Mattermost Build <build@mattermost.com>	2025-10-01 16:12:36 +02:00
sabril	b93245b679	MM-63699 E2E/Playwright (accessibility): Notifications settings (#33969)	2025-09-26 21:23:04 +08:00
sabril	84a2d2eda7	fix: update e2e visual snapshots (#33944)	2025-09-24 13:01:57 +08:00
sabril	b579b4e63a	MM-63699: E2E/Accessibility: Settings modal (#33869) ... * a11y tests on notificatins settings * refactor settings and channel settings modal, add focus check on settings modal * more a11y and visual tests	2025-09-19 22:51:03 +08:00
Maria A Nunez	4169cb7b65	Entry Sku Product Label (#33847) ... * Initial commit * Linting * Update FREE EDITION to TEAM EDITION * Added permalink for entry limit info	2025-09-10 21:37:24 -04:00