upstream/mattermost
1
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-05-28 04:35:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

MM-65660 Fix broken calls to save telemetry state (#33930)

Browse source 
Automatic Merge
This commit is contained in:
Harrison Healey 2025-09-19 04:19:10 -04:00 committed by GitHub
parent 1fcee1996a
commit fa7eeb1c0e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
webapp/channels/src/components/onboarding_tasks/complete_your_profile_tour_tip.tsx
View file

@ -49,7 +49,7 @@ export const CompleteYourProfileTour = () => {
const onDismiss = (e: React.MouseEvent) => {
e.stopPropagation();
e.preventDefault();
handleTask(taskName, steps.START, true);
handleTask(taskName, steps.START);
};
return (

17
webapp/channels/src/components/onboarding_tasks/onboarding_tasks_manager.tsx
View file

@ -170,7 +170,7 @@ export const useHandleOnBoardingTaskData = () => {
const dispatch = useDispatch();
const currentUserId = useSelector(getCurrentUserId);
const storeSavePreferences = useCallback(
(taskCategory: string, taskName, step: number) => {
(taskCategory: string, taskName: string, step: number) => {
const preferences = [
{
user_id: currentUserId,
@ -187,9 +187,8 @@ export const useHandleOnBoardingTaskData = () => {
return useCallback((
taskName: string,
step: number,
taskCategory = OnboardingTaskCategory,
) => {
storeSavePreferences(taskCategory, taskName, step);
storeSavePreferences(OnboardingTaskCategory, taskName, step);
}, [storeSavePreferences]);
};
@ -206,7 +205,7 @@ export const useHandleOnBoardingTaskTrigger = () => {
return (taskName: string) => {
switch (taskName) {
case OnboardingTasksName.CHANNELS_TOUR: {
handleSaveData(taskName, TaskNameMapToSteps[taskName].STARTED, true);
handleSaveData(taskName, TaskNameMapToSteps[taskName].STARTED);
const tourCategory = TutorialTourName.ONBOARDING_TUTORIAL_STEP;
const preferences = [
{
@ -233,7 +232,7 @@ export const useHandleOnBoardingTaskTrigger = () => {
case OnboardingTasksName.COMPLETE_YOUR_PROFILE: {
openMenu(ELEMENT_ID_FOR_USER_ACCOUNT_MENU_BUTTON);
dispatch(setShowOnboardingCompleteProfileTour(true));
handleSaveData(taskName, TaskNameMapToSteps[taskName].STARTED, true);
handleSaveData(taskName, TaskNameMapToSteps[taskName].STARTED);
if (inAdminConsole) {
dispatch(switchToChannels());
}
@ -242,7 +241,7 @@ export const useHandleOnBoardingTaskTrigger = () => {
case OnboardingTasksName.VISIT_SYSTEM_CONSOLE: {
dispatch(setProductMenuSwitcherOpen(true));
dispatch(setShowOnboardingVisitConsoleTour(true));
handleSaveData(taskName, TaskNameMapToSteps[taskName].STARTED, true);
handleSaveData(taskName, TaskNameMapToSteps[taskName].STARTED);
break;
}
case OnboardingTasksName.INVITE_PEOPLE: {
@ -253,11 +252,11 @@ export const useHandleOnBoardingTaskTrigger = () => {
} else {
dispatch(openInvitationsModal());
}
handleSaveData(taskName, TaskNameMapToSteps[taskName].FINISHED, true);
handleSaveData(taskName, TaskNameMapToSteps[taskName].FINISHED);
break;
}
case OnboardingTasksName.DOWNLOAD_APP: {
handleSaveData(taskName, TaskNameMapToSteps[taskName].FINISHED, true);
handleSaveData(taskName, TaskNameMapToSteps[taskName].FINISHED);
const preferences = [{
user_id: currentUserId,
category: OnboardingTaskCategory,
@ -274,7 +273,7 @@ export const useHandleOnBoardingTaskTrigger = () => {
dialogType: LearnMoreTrialModal,
}));
handleSaveData(taskName, TaskNameMapToSteps[taskName].FINISHED, true);
handleSaveData(taskName, TaskNameMapToSteps[taskName].FINISHED);
break;
}
default:

2
webapp/channels/src/components/onboarding_tasks/start_trial_tour_tip.tsx
View file

@ -34,7 +34,7 @@ export const StartTrialTour = () => {
const overlayPunchOut = useMeasurePunchouts([], []);
const onDismiss = useCallback(() => {
handleTask(taskName, steps.START, true);
handleTask(taskName, steps.START);
}, [handleTask]);
return (

2
webapp/channels/src/components/onboarding_tasks/visit_system_console_tour_tip.tsx
View file

@ -48,7 +48,7 @@ export const VisitSystemConsoleTour = () => {
const onDismiss = (e: React.MouseEvent) => {
e.stopPropagation();
e.preventDefault();
handleTask(taskName, steps.START, true);
handleTask(taskName, steps.START);
};
return (