From d9981beb9dfd6df89ab6197d06f9a6b10f7f92a2 Mon Sep 17 00:00:00 2001 From: AulakhHarsh <115346020+AulakhHarsh@users.noreply.github.com> Date: Wed, 27 Nov 2024 16:37:31 +0530 Subject: [PATCH] Fix errcheck issues in server/channels/jobs/resend_invitation_email/worker.go (#29353) Co-authored-by: Ben Schumacher --- server/.golangci.yml | 1 - server/channels/jobs/resend_invitation_email/worker.go | 5 ++++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index c7cfd8712dc..40ed0dd6a10 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -131,7 +131,6 @@ issues: channels/jobs/helper_test.go|\ channels/jobs/hosted_purchase_screening/worker.go|\ channels/jobs/jobs.go|\ - channels/jobs/resend_invitation_email/worker.go|\ channels/manualtesting/manual_testing.go|\ channels/store/localcachelayer/channel_layer.go|\ channels/store/localcachelayer/channel_layer_test.go|\ diff --git a/server/channels/jobs/resend_invitation_email/worker.go b/server/channels/jobs/resend_invitation_email/worker.go index b989a499fb9..2fa939a06b4 100644 --- a/server/channels/jobs/resend_invitation_email/worker.go +++ b/server/channels/jobs/resend_invitation_email/worker.go @@ -171,7 +171,10 @@ func (rseworker *ResendInvitationEmailWorker) GetDurations(job *model.Job) (int6 } func (rseworker *ResendInvitationEmailWorker) TearDown(logger mlog.LoggerIFace, job *model.Job) { - rseworker.store.System().PermanentDeleteByName(job.Id) + if _, err := rseworker.store.System().PermanentDeleteByName(job.Id); err != nil { + logger.Error("Worker: Failed to tear down data", mlog.Err(err)) + } + rseworker.setJobSuccess(logger, job) }