From bbf78c4ff642ce0f4abfde278030ec4009649df8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pablo=20Andr=C3=A9s=20V=C3=A9lez=20Vidal?= Date: Wed, 29 Mar 2023 18:42:09 +0200 Subject: [PATCH] make autolinked board ff false as default (#22714) --- e2e-tests/playwright/support/server/default_config.ts | 2 +- .../tests/visual/channels/intro_channel.spec.ts | 10 +++++----- model/feature_flags.go | 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/e2e-tests/playwright/support/server/default_config.ts b/e2e-tests/playwright/support/server/default_config.ts index 63be6783093..5d6e56f7d50 100644 --- a/e2e-tests/playwright/support/server/default_config.ts +++ b/e2e-tests/playwright/support/server/default_config.ts @@ -693,7 +693,7 @@ const defaultServerConfig: AdminConfig = { WysiwygEditor: false, PeopleProduct: false, ReduceOnBoardingTaskList: false, - OnboardingAutoShowLinkedBoard: true, + OnboardingAutoShowLinkedBoard: false, ThreadsEverywhere: false, GlobalDrafts: true, OnboardingTourTips: true, diff --git a/e2e-tests/playwright/tests/visual/channels/intro_channel.spec.ts b/e2e-tests/playwright/tests/visual/channels/intro_channel.spec.ts index 8db64db9a77..53c1b74e115 100644 --- a/e2e-tests/playwright/tests/visual/channels/intro_channel.spec.ts +++ b/e2e-tests/playwright/tests/visual/channels/intro_channel.spec.ts @@ -2,7 +2,7 @@ // See LICENSE.txt for license information. import {expect, test} from '@e2e-support/test_fixture'; -import {duration, isSmallScreen, wait} from '@e2e-support/util'; +import {isSmallScreen} from '@e2e-support/util'; test('Intro to channel as regular user', async ({pw, pages, browserName, viewport}, testInfo) => { // Create and sign in a new user @@ -17,10 +17,10 @@ test('Intro to channel as regular user', async ({pw, pages, browserName, viewpor await channelsPage.toBeVisible(); // Wait for Boards' bot image to be loaded - await pw.shouldHaveFeatureFlag('OnboardingAutoShowLinkedBoard', true); - const boardsWelcomePost = await channelsPage.getFirstPost(); - await expect(await boardsWelcomePost.getProfileImage('boards')).toBeVisible(); - await wait(duration.one_sec); + // await pw.shouldHaveFeatureFlag('OnboardingAutoShowLinkedBoard', true); + // const boardsWelcomePost = await channelsPage.getFirstPost(); + // await expect(await boardsWelcomePost.getProfileImage('boards')).toBeVisible(); + // await wait(duration.one_sec); // Wait for Playbooks icon to be loaded in App bar, except in iphone if (!isSmallScreen(viewport)) { diff --git a/model/feature_flags.go b/model/feature_flags.go index ebe357d3d98..d4f0929c71d 100644 --- a/model/feature_flags.go +++ b/model/feature_flags.go @@ -104,7 +104,7 @@ func (f *FeatureFlags) SetDefaults() { f.ThreadsEverywhere = false f.GlobalDrafts = true f.WysiwygEditor = false - f.OnboardingAutoShowLinkedBoard = true + f.OnboardingAutoShowLinkedBoard = false f.OnboardingTourTips = true }