upstream/mattermost
1
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-05-28 04:35:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

avoid SELECT * in cluster discovery store (#30830)

Browse source
This commit is contained in:
Jesse Hallam 2025-04-22 18:08:43 -03:00 committed by GitHub
parent b095ba22b8
commit 94bc32b50c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 21 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
server/channels/store/sqlstore/cluster_discovery_store.go
View file

@ -13,10 +13,29 @@ import (
type sqlClusterDiscoveryStore struct {
*SqlStore
clusterDiscoveryQuery sq.SelectBuilder
}
func newSqlClusterDiscoveryStore(sqlStore *SqlStore) store.ClusterDiscoveryStore {
return &sqlClusterDiscoveryStore{sqlStore}
s := &sqlClusterDiscoveryStore{
SqlStore: sqlStore,
}
s.clusterDiscoveryQuery = s.getQueryBuilder().
Select(
"Id",
"Type",
"ClusterName",
"Hostname",
"GossipPort",
"Port",
"CreateAt",
"LastPingAt",
).
From("ClusterDiscovery")
return s
}
func (s sqlClusterDiscoveryStore) Save(ClusterDiscovery *model.ClusterDiscovery) error {
@ -84,9 +103,7 @@ func (s sqlClusterDiscoveryStore) Exists(ClusterDiscovery *model.ClusterDiscover
}
func (s sqlClusterDiscoveryStore) GetAll(ClusterDiscoveryType, clusterName string) ([]*model.ClusterDiscovery, error) {
query := s.getQueryBuilder().
Select("*").
From("ClusterDiscovery").
query := s.clusterDiscoveryQuery.
Where(sq.Eq{"Type": ClusterDiscoveryType}).
Where(sq.Eq{"ClusterName": clusterName}).
Where(sq.Gt{"LastPingAt": model.GetMillis() - model.CDSOfflineAfterMillis})