From 8b8d0a0a0938907ffd9cef1d76f1b0faedabb6c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pablo=20V=C3=A9lez?= Date: Fri, 13 Dec 2024 15:07:58 -0500 Subject: [PATCH] MM-61897 - fix duplicated role dialog in boostrap modals (#29507) * MM-61897 - fix duplicated role dialog in modals * fix linter --- .../get_link_modal.test.tsx.snap | 8 +- .../post_deleted_modal.test.tsx.snap | 2 +- .../about_build_modal/about_build_modal.tsx | 2 +- .../about_build_modal_cloud.tsx | 2 +- .../access_history_modal.test.tsx.snap | 4 +- .../access_history_modal.tsx | 2 +- .../activity_log_modal.test.tsx.snap | 4 +- .../activity_log_modal/activity_log_modal.tsx | 2 +- .../add_user_to_channel_modal.test.tsx.snap | 2 +- .../add_user_to_channel_modal.tsx | 2 +- .../add_users_to_group_modal.test.tsx.snap | 2 +- .../add_users_to_group_modal.tsx | 2 +- .../full_log_event_modal.tsx | 2 +- .../manage_roles_modal/manage_roles_modal.tsx | 2 +- .../manage_teams_modal.test.tsx.snap | 2 +- .../manage_teams_modal/manage_teams_modal.tsx | 2 +- .../manage_tokens_modal.test.tsx.snap | 6 +- .../manage_tokens_modal.tsx | 2 +- .../edit_post_time_limit_modal.tsx | 2 +- .../reset_email_modal.test.tsx.snap | 4 +- .../reset_email_modal/reset_email_modal.tsx | 2 +- .../reset_password_modal.test.tsx.snap | 2 +- .../reset_password_modal.tsx | 2 +- .../group_members_modal.test.tsx.snap | 2 +- .../group/group_members_modal.tsx | 2 +- .../users_to_be_removed_modal.tsx | 2 +- .../apps_form_component.test.tsx.snap | 2 +- .../apps_form/apps_form_component.tsx | 2 +- .../channel_invite_modal.test.tsx.snap | 6 +- .../channel_invite_modal.tsx | 2 +- .../channel_members_modal.test.tsx.snap | 4 +- .../channel_members_modal.tsx | 2 +- .../channel_notifications_modal.test.tsx.snap | 12 +- .../channel_notifications_modal.tsx | 2 +- .../channel_selector_modal.test.tsx.snap | 4 +- .../channel_selector_modal.tsx | 2 +- .../__snapshots__/success.test.tsx.snap | 2 +- .../channels/src/components/confirm_modal.tsx | 2 +- .../convert_channel_modal.tsx | 2 +- .../create_user_groups_modal.test.tsx.snap | 4 +- .../create_user_groups_modal.tsx | 2 +- .../delete_channel_modal.test.tsx.snap | 2 +- .../delete_channel_modal.tsx | 2 +- .../delete_post_modal.test.tsx.snap | 6 +- .../delete_post_modal/delete_post_modal.tsx | 2 +- .../edit_channel_header_modal.test.tsx.snap | 10 +- .../edit_channel_header_modal.tsx | 2 +- .../edit_channel_purpose_modal.test.tsx.snap | 14 +- .../edit_channel_purpose_modal.tsx | 2 +- .../file_preview_modal.test.tsx.snap | 24 +- .../file_preview_modal/file_preview_modal.tsx | 2 +- .../src/components/get_link_modal.tsx | 2 +- ...ct_outgoing_oauth_connection.test.tsx.snap | 4 +- ...dd_outgoing_oauth_connection.test.tsx.snap | 2 +- ...it_outgoing_oauth_connection.test.tsx.snap | 12 +- .../interactive_dialog/interactive_dialog.tsx | 2 +- .../invitation_modal/invitation_modal.tsx | 2 +- .../keyboard_shortcuts_modal.test.tsx.snap | 4 +- .../keyboard_shortcuts_modal.tsx | 2 +- .../leave_team_modal.test.tsx.snap | 2 +- .../leave_team_modal/leave_team_modal.tsx | 2 +- .../more_direct_channels.test.tsx.snap | 4 +- .../more_direct_channels.tsx | 2 +- .../onboarding_video_modal.tsx | 2 +- .../marketplace_modal.test.tsx.snap | 14 +- .../src/components/post_deleted_modal.tsx | 2 +- .../src/components/pricing_modal/index.tsx | 2 +- .../quick_switch_modal.test.tsx.snap | 2 +- .../quick_switch_modal/quick_switch_modal.tsx | 2 +- .../removed_from_channel_modal.test.tsx.snap | 2 +- .../removed_from_channel_modal.tsx | 2 +- .../rename_channel_modal.test.tsx.snap | 2 +- .../rename_channel_modal.tsx | 2 +- .../start_trial_form_modal.test.tsx.snap | 2 +- .../air_gapped_modal.tsx | 2 +- .../start_trial_form_modal/index.tsx | 2 +- .../team_members_modal.test.tsx.snap | 2 +- .../team_members_modal/team_members_modal.tsx | 2 +- .../team_selector_modal.tsx | 2 +- .../team_settings_modal.tsx | 2 +- .../unarchive_channel_modal.test.tsx.snap | 2 +- .../unarchive_channel_modal.tsx | 2 +- .../update_user_group_modal.test.tsx.snap | 2 +- .../update_user_group_modal.tsx | 2 +- .../user_groups_modal.test.tsx.snap | 4 +- .../user_groups_modal/user_groups_modal.tsx | 2 +- .../view_user_group_modal.test.tsx.snap | 2 +- .../view_user_group_modal.tsx | 2 +- .../__snapshots__/submenu_modal.test.tsx.snap | 2 +- .../submenu_modal/submenu_modal.tsx | 2 +- .../widgets/modals/full_screen_modal.test.tsx | 234 +++++++++--------- .../widgets/modals/full_screen_modal.tsx | 2 +- .../src/generic_modal/generic_modal.tsx | 2 +- 93 files changed, 265 insertions(+), 265 deletions(-) diff --git a/webapp/channels/src/components/__snapshots__/get_link_modal.test.tsx.snap b/webapp/channels/src/components/__snapshots__/get_link_modal.test.tsx.snap index 6372fda945c..1605e402999 100644 --- a/webapp/channels/src/components/__snapshots__/get_link_modal.test.tsx.snap +++ b/webapp/channels/src/components/__snapshots__/get_link_modal.test.tsx.snap @@ -27,7 +27,7 @@ exports[`components/GetLinkModal should have called onHide 1`] = ` onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > { show={this.state.show} onHide={this.doHide} onExited={this.props.onExited} - role='dialog' + role='none' aria-labelledby='aboutModalLabel' > diff --git a/webapp/channels/src/components/about_build_modal/about_build_modal_cloud/about_build_modal_cloud.tsx b/webapp/channels/src/components/about_build_modal/about_build_modal_cloud/about_build_modal_cloud.tsx index 7742065a5a4..388d0f5ff30 100644 --- a/webapp/channels/src/components/about_build_modal/about_build_modal_cloud/about_build_modal_cloud.tsx +++ b/webapp/channels/src/components/about_build_modal/about_build_modal_cloud/about_build_modal_cloud.tsx @@ -63,7 +63,7 @@ export default function AboutBuildModalCloud(props: Props) { show={props.show} onHide={props.doHide} onExited={props.onExited} - role='dialog' + role='none' aria-labelledby='aboutModalLabel' > diff --git a/webapp/channels/src/components/access_history_modal/__snapshots__/access_history_modal.test.tsx.snap b/webapp/channels/src/components/access_history_modal/__snapshots__/access_history_modal.test.tsx.snap index 945a069e72b..254dcabb148 100644 --- a/webapp/channels/src/components/access_history_modal/__snapshots__/access_history_modal.test.tsx.snap +++ b/webapp/channels/src/components/access_history_modal/__snapshots__/access_history_modal.test.tsx.snap @@ -28,7 +28,7 @@ exports[`components/AccessHistoryModal should match snapshot when audits exist 1 onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > diff --git a/webapp/channels/src/components/activity_log_modal/__snapshots__/activity_log_modal.test.tsx.snap b/webapp/channels/src/components/activity_log_modal/__snapshots__/activity_log_modal.test.tsx.snap index ffaa24aab9b..9295ca93872 100644 --- a/webapp/channels/src/components/activity_log_modal/__snapshots__/activity_log_modal.test.tsx.snap +++ b/webapp/channels/src/components/activity_log_modal/__snapshots__/activity_log_modal.test.tsx.snap @@ -28,7 +28,7 @@ exports[`components/ActivityLogModal should match snapshot 1`] = ` onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > onHide={this.onHide} onExited={this.props.onHide} bsSize='large' - role='dialog' + role='none' aria-labelledby='activityLogModalLabel' > diff --git a/webapp/channels/src/components/add_user_to_channel_modal/__snapshots__/add_user_to_channel_modal.test.tsx.snap b/webapp/channels/src/components/add_user_to_channel_modal/__snapshots__/add_user_to_channel_modal.test.tsx.snap index 255c76bb9cd..43b5ad4745d 100644 --- a/webapp/channels/src/components/add_user_to_channel_modal/__snapshots__/add_user_to_channel_modal.test.tsx.snap +++ b/webapp/channels/src/components/add_user_to_channel_modal/__snapshots__/add_user_to_channel_modal.test.tsx.snap @@ -27,7 +27,7 @@ exports[`components/AddUserToChannelModal should match snapshot 1`] = ` onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > diff --git a/webapp/channels/src/components/add_users_to_group_modal/__snapshots__/add_users_to_group_modal.test.tsx.snap b/webapp/channels/src/components/add_users_to_group_modal/__snapshots__/add_users_to_group_modal.test.tsx.snap index 99adbebb930..4a505886b10 100644 --- a/webapp/channels/src/components/add_users_to_group_modal/__snapshots__/add_users_to_group_modal.test.tsx.snap +++ b/webapp/channels/src/components/add_users_to_group_modal/__snapshots__/add_users_to_group_modal.test.tsx.snap @@ -28,7 +28,7 @@ exports[`component/add_users_to_group_modal should match snapshot 1`] = ` onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > { show={show} onHide={doHide} onExited={props.onExited} - role='dialog' + role='none' aria-labelledby='createUserGroupsModalLabel' id='addUsersToGroupsModal' > diff --git a/webapp/channels/src/components/admin_console/full_log_event_modal/full_log_event_modal.tsx b/webapp/channels/src/components/admin_console/full_log_event_modal/full_log_event_modal.tsx index 9f22e0f3e41..46ba846d161 100644 --- a/webapp/channels/src/components/admin_console/full_log_event_modal/full_log_event_modal.tsx +++ b/webapp/channels/src/components/admin_console/full_log_event_modal/full_log_event_modal.tsx @@ -65,7 +65,7 @@ export default class FullLogEventModal extends React.PureComponent show={this.props.show} onHide={this.props.onModalDismissed} dialogClassName='a11y__modal full-log-event' - role='dialog' + role='none' aria-labelledby='fullLogEventModalLabel' > diff --git a/webapp/channels/src/components/admin_console/manage_roles_modal/manage_roles_modal.tsx b/webapp/channels/src/components/admin_console/manage_roles_modal/manage_roles_modal.tsx index d1012b8e116..a34b4d77476 100644 --- a/webapp/channels/src/components/admin_console/manage_roles_modal/manage_roles_modal.tsx +++ b/webapp/channels/src/components/admin_console/manage_roles_modal/manage_roles_modal.tsx @@ -356,7 +356,7 @@ export default class ManageRolesModal extends React.PureComponent onHide={this.onHide} onExited={this.props.onExited} dialogClassName='a11y__modal manage-teams' - role='dialog' + role='none' aria-labelledby='manageRolesModalLabel' > diff --git a/webapp/channels/src/components/admin_console/manage_teams_modal/__snapshots__/manage_teams_modal.test.tsx.snap b/webapp/channels/src/components/admin_console/manage_teams_modal/__snapshots__/manage_teams_modal.test.tsx.snap index ae9f5517bd4..c22f6417558 100644 --- a/webapp/channels/src/components/admin_console/manage_teams_modal/__snapshots__/manage_teams_modal.test.tsx.snap +++ b/webapp/channels/src/components/admin_console/manage_teams_modal/__snapshots__/manage_teams_modal.test.tsx.snap @@ -27,7 +27,7 @@ exports[`ManageTeamsModal should match snapshot init 1`] = ` onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > { onHide={onModalDismissed} onExited={onExited} dialogClassName='a11y__modal manage-teams modal--overflow-visible' - role='dialog' + role='none' aria-labelledby='manageTeamsModalLabel' > diff --git a/webapp/channels/src/components/admin_console/manage_tokens_modal/__snapshots__/manage_tokens_modal.test.tsx.snap b/webapp/channels/src/components/admin_console/manage_tokens_modal/__snapshots__/manage_tokens_modal.test.tsx.snap index 6e3d8e48dc7..2477484a277 100644 --- a/webapp/channels/src/components/admin_console/manage_tokens_modal/__snapshots__/manage_tokens_modal.test.tsx.snap +++ b/webapp/channels/src/components/admin_console/manage_tokens_modal/__snapshots__/manage_tokens_modal.test.tsx.snap @@ -27,7 +27,7 @@ exports[`components/admin_console/manage_tokens_modal/manage_tokens_modal.tsx in onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > onHide={this.onModalDismissed} onExited={this.props.onExited} dialogClassName='a11y__modal manage-teams' - role='dialog' + role='none' aria-labelledby='manageTokensModalLabel' > diff --git a/webapp/channels/src/components/admin_console/permission_schemes_settings/edit_post_time_limit_modal/edit_post_time_limit_modal.tsx b/webapp/channels/src/components/admin_console/permission_schemes_settings/edit_post_time_limit_modal/edit_post_time_limit_modal.tsx index db362a4fcc5..9ac5b87dc1f 100644 --- a/webapp/channels/src/components/admin_console/permission_schemes_settings/edit_post_time_limit_modal/edit_post_time_limit_modal.tsx +++ b/webapp/channels/src/components/admin_console/permission_schemes_settings/edit_post_time_limit_modal/edit_post_time_limit_modal.tsx @@ -69,7 +69,7 @@ export default function EditPostTimeLimitModal(props: Props) { diff --git a/webapp/channels/src/components/admin_console/reset_email_modal/__snapshots__/reset_email_modal.test.tsx.snap b/webapp/channels/src/components/admin_console/reset_email_modal/__snapshots__/reset_email_modal.test.tsx.snap index 659561673b0..55977537246 100644 --- a/webapp/channels/src/components/admin_console/reset_email_modal/__snapshots__/reset_email_modal.test.tsx.snap +++ b/webapp/channels/src/components/admin_console/reset_email_modal/__snapshots__/reset_email_modal.test.tsx.snap @@ -28,7 +28,7 @@ exports[`components/admin_console/reset_email_modal/reset_email_modal.tsx should onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > { show={this.state.show} onHide={this.doCancel} onExited={this.props.onExited} - role='dialog' + role='none' aria-labelledby='resetEmailModalLabel' data-testid='resetEmailModal' > diff --git a/webapp/channels/src/components/admin_console/reset_password_modal/__snapshots__/reset_password_modal.test.tsx.snap b/webapp/channels/src/components/admin_console/reset_password_modal/__snapshots__/reset_password_modal.test.tsx.snap index f56bf0b6221..1fbb00e11d2 100644 --- a/webapp/channels/src/components/admin_console/reset_password_modal/__snapshots__/reset_password_modal.test.tsx.snap +++ b/webapp/channels/src/components/admin_console/reset_password_modal/__snapshots__/reset_password_modal.test.tsx.snap @@ -27,7 +27,7 @@ exports[`components/admin_console/reset_password_modal/reset_password_modal.tsx onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > diff --git a/webapp/channels/src/components/admin_console/team_channel_settings/group/__snapshots__/group_members_modal.test.tsx.snap b/webapp/channels/src/components/admin_console/team_channel_settings/group/__snapshots__/group_members_modal.test.tsx.snap index f8265097345..d5494c35840 100644 --- a/webapp/channels/src/components/admin_console/team_channel_settings/group/__snapshots__/group_members_modal.test.tsx.snap +++ b/webapp/channels/src/components/admin_console/team_channel_settings/group/__snapshots__/group_members_modal.test.tsx.snap @@ -28,7 +28,7 @@ exports[`admin_console/team_channel_settings/group/GroupList should match snapsh onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} > = ({ show={show} onHide={handleHide} onExited={handleExit} - role='dialog' + role='none' aria-labelledby='groupMemberModalLabel' id='groupMembersModal' > diff --git a/webapp/channels/src/components/admin_console/team_channel_settings/users_to_be_removed_modal.tsx b/webapp/channels/src/components/admin_console/team_channel_settings/users_to_be_removed_modal.tsx index 6adc8e9dcc7..f9716cb70d3 100644 --- a/webapp/channels/src/components/admin_console/team_channel_settings/users_to_be_removed_modal.tsx +++ b/webapp/channels/src/components/admin_console/team_channel_settings/users_to_be_removed_modal.tsx @@ -82,7 +82,7 @@ const UsersToBeRemovedModal = ({total, scope, scopeId, users, onExited}: Props) onHide={handleHide} onExited={onExited} id='confirmModal' - role='dialog' + role='none' aria-labelledby='confirmModalLabel' > diff --git a/webapp/channels/src/components/apps_form/__snapshots__/apps_form_component.test.tsx.snap b/webapp/channels/src/components/apps_form/__snapshots__/apps_form_component.test.tsx.snap index aa20143c293..3786ed8cf38 100644 --- a/webapp/channels/src/components/apps_form/__snapshots__/apps_form_component.test.tsx.snap +++ b/webapp/channels/src/components/apps_form/__snapshots__/apps_form_component.test.tsx.snap @@ -28,7 +28,7 @@ exports[`AppsFormComponent should set match snapshot 1`] = ` onHide={[Function]} renderBackdrop={[Function]} restoreFocus={true} - role="dialog" + role="none" show={true} >
{ onHide={this.onHide} onExited={this.props.onExited} backdrop='static' - role='dialog' + role='none' aria-labelledby='appsModalLabel' > { show={this.state.show} onHide={this.onHide} onExited={this.props.onExited} - role='dialog' + role='none' aria-labelledby='channelInviteModalLabel' > diff --git a/webapp/channels/src/components/channel_notifications_modal/__snapshots__/channel_notifications_modal.test.tsx.snap b/webapp/channels/src/components/channel_notifications_modal/__snapshots__/channel_notifications_modal.test.tsx.snap index 6a7dfc6a0b2..e1499eec419 100644 --- a/webapp/channels/src/components/channel_notifications_modal/__snapshots__/channel_notifications_modal.test.tsx.snap +++ b/webapp/channels/src/components/channel_notifications_modal/__snapshots__/channel_notifications_modal.test.tsx.snap @@ -11,7 +11,7 @@ Object { aria-hidden="true" />