upstream/mattermost
1
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-05-28 04:35:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fix: emoji errcheck issues (#28437)

Browse source 
Co-authored-by: Mattermost Build <build@mattermost.com>
This commit is contained in:
Rohan Sharma 2024-10-08 00:32:16 +05:30 committed by GitHub
parent 9e0d629ab1
commit 7af408679e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
server/.golangci.yml
View file

@ -74,7 +74,6 @@ issues:
channels/api4/config_local.go|\
channels/api4/config_test.go|\
channels/api4/data_retention.go|\
channels/api4/emoji.go|\
channels/api4/emoji_test.go|\
channels/api4/export.go|\
channels/api4/export_test.go|\

10
server/channels/api4/emoji.go
View file

@ -33,7 +33,11 @@ func (api *API) InitEmoji() {
}
func createEmoji(c *Context, w http.ResponseWriter, r *http.Request) {
defer io.Copy(io.Discard, r.Body)
defer func() {
if _, err := io.Copy(io.Discard, r.Body); err != nil {
c.Logger.Warn("Error while discarding request body", mlog.Err(err))
}
}()
if !*c.App.Config().ServiceSettings.EnableCustomEmoji {
c.Err = model.NewAppError("createEmoji", "api.emoji.disabled.app_error", nil, "", http.StatusNotImplemented)
@ -291,7 +295,9 @@ func getEmojiImage(c *Context, w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "image/"+imageType)
w.Header().Set("Cache-Control", "max-age=2592000, private")
w.Write(image)
if _, err := w.Write(image); err != nil {
c.Logger.Warn("Error while writing image response", mlog.Err(err))
}
}
func searchEmojis(c *Context, w http.ResponseWriter, r *http.Request) {