From 68404f2f335d0ccd38db8ba0e7156a2840e98dab Mon Sep 17 00:00:00 2001 From: Rohan Sharma <117426013+RS-labhub@users.noreply.github.com> Date: Wed, 9 Oct 2024 15:28:16 +0530 Subject: [PATCH] fix: scheme errcheck issues (#28543) --- server/.golangci.yml | 1 - server/channels/api4/scheme.go | 8 ++++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 02574125972..f4e7eb3a200 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -89,7 +89,6 @@ issues: channels/api4/reaction_test.go|\ channels/api4/remote_cluster.go|\ channels/api4/role_test.go|\ - channels/api4/scheme.go|\ channels/api4/scheme_test.go|\ channels/api4/shared_channel.go|\ channels/api4/status.go|\ diff --git a/server/channels/api4/scheme.go b/server/channels/api4/scheme.go index 47fa2a0fd47..820893fd706 100644 --- a/server/channels/api4/scheme.go +++ b/server/channels/api4/scheme.go @@ -105,7 +105,9 @@ func getSchemes(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getTeamsForScheme(c *Context, w http.ResponseWriter, r *http.Request) { @@ -142,7 +144,9 @@ func getTeamsForScheme(c *Context, w http.ResponseWriter, r *http.Request) { return } - w.Write(js) + if _, err := w.Write(js); err != nil { + c.Logger.Warn("Error while writing response", mlog.Err(err)) + } } func getChannelsForScheme(c *Context, w http.ResponseWriter, r *http.Request) {