upstream/mattermost
1
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-05-28 04:35:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

MM-66830: Fix RHS panel snapping to minimum width on resize (#35236)

Browse source 
Race condition caused mousemove events to fire after reset() but before
cleanup, resulting in negative width calculations that CSS clamped to
min-width.
This commit is contained in:
Scott Bishel 2026-02-18 18:02:13 -07:00 committed by GitHub
parent 316ab57b0b
commit 5318fc3ff3
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 22 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
webapp/channels/src/components/resizable_sidebar/resizable_divider.tsx
View file

@ -129,7 +129,10 @@ function ResizableDivider({
return;
}
previousClientX.current = e.clientX;
startWidth.current = containerRef.current.getBoundingClientRect().width;
const currentWidth = containerRef.current.getBoundingClientRect().width;
startWidth.current = currentWidth;
lastWidth.current = currentWidth;
setIsActive(true);
@ -160,7 +163,24 @@ function ResizableDivider({
e.preventDefault();
const previousWidth = lastWidth.current ?? 0;
// Prevent race condition - if lastWidth is null, recover from container
// This can occur when a mousemove event fires after reset() but before cleanup
let previousWidth = lastWidth.current;
if (previousWidth === null || previousWidth === 0) {
const currentWidth = containerRef.current?.getBoundingClientRect().width ?? 0;
if (currentWidth > 0) {
previousWidth = currentWidth;
lastWidth.current = currentWidth;
previousClientX.current = e.clientX;
// Skip this mousemove, start fresh on next one
return;
}
// If we can't determine width, return early to prevent negative width
return;
}
let widthDiff = 0;
switch (dir) {