From 4d0109feeb0121eb0ce77f43688e028e0bed76df Mon Sep 17 00:00:00 2001 From: Ben Schumacher Date: Mon, 14 Apr 2025 09:28:28 +0200 Subject: [PATCH] [MM-61082] Fix errcheck issues in license_test.go (#30617) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * [MM-28754] Fix errcheck issues in license_test.go - Properly handle error returned from os.WriteFile - Remove license_test.go from errcheck exceptions list in .golangci.yml Fixes https://github.com/mattermost/mattermost/issues/28754 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude * Remove empty line --------- Co-authored-by: Claude --- server/.golangci.yml | 1 - server/channels/utils/license_test.go | 3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/.golangci.yml b/server/.golangci.yml index 140fc8ab923..0c2d5e49992 100644 --- a/server/.golangci.yml +++ b/server/.golangci.yml @@ -160,7 +160,6 @@ issues: channels/store/storetest/team_store.go|\ channels/store/storetest/thread_store.go|\ channels/store/storetest/user_store.go|\ - channels/utils/license_test.go|\ channels/web/oauth_test.go|\ channels/web/saml.go|\ channels/web/web_test.go|\ diff --git a/server/channels/utils/license_test.go b/server/channels/utils/license_test.go index 4a88a869375..0d3a78b55c5 100644 --- a/server/channels/utils/license_test.go +++ b/server/channels/utils/license_test.go @@ -112,7 +112,8 @@ func TestGetLicenseFileFromDisk(t *testing.T) { f, err := os.CreateTemp("", "TestGetLicenseFileFromDisk") require.NoError(t, err) defer os.Remove(f.Name()) - os.WriteFile(f.Name(), []byte("not a license"), 0777) + err = os.WriteFile(f.Name(), []byte("not a license"), 0777) + require.NoError(t, err) fileBytes := GetLicenseFileFromDisk(f.Name()) require.NotEmpty(t, fileBytes, "should have read the file")