From 2e1dc79a0341e9687455c80dd7028e0fde4227bb Mon Sep 17 00:00:00 2001 From: Agniva De Sarker Date: Mon, 11 May 2020 13:19:00 +0530 Subject: [PATCH] Remove concurrent write to websocket connection (#14527) This test writes directly to a connection which causes panics and more frustration in an already fragile CI. Since this anyways checks an edge condition, and will anyways be removed in v6, let's remove this for now and let CI be happy. --- api4/websocket_test.go | 7 ------- 1 file changed, 7 deletions(-) diff --git a/api4/websocket_test.go b/api4/websocket_test.go index 47160641034..bc6d627b4be 100644 --- a/api4/websocket_test.go +++ b/api4/websocket_test.go @@ -47,13 +47,6 @@ func TestWebSocket(t *testing.T) { resp = <-WebSocketClient.ResponseChannel require.Equal(t, resp.Error.Id, "api.web_socket_router.bad_action.app_error", "should have been bad action response") - req := &model.WebSocketRequest{} - req.Seq = 0 - req.Action = "ping" - WebSocketClient.Conn.WriteJSON(req) - resp = <-WebSocketClient.ResponseChannel - require.Equal(t, resp.Error.Id, "api.web_socket_router.bad_seq.app_error", "should have been bad action response") - WebSocketClient.UserTyping("", "") resp = <-WebSocketClient.ResponseChannel require.Equal(t, resp.Error.Id, "api.websocket_handler.invalid_param.app_error", "should have been invalid param response")