upstream/mattermost
1
0
Fork 0
mirror of https://github.com/mattermost/mattermost.git synced 2026-05-28 04:35:04 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[MM-61263] fix: errcheck issues in server/channels/app/job_test.go (#29070)

Browse source 
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
This commit is contained in:
Kyrillos Isaac 2024-12-12 14:17:40 +03:00 committed by GitHub
parent b8efccae69
commit 267c4133b7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
server/.golangci.yml
View file

@ -92,7 +92,6 @@ issues:
channels/app/helper_test.go|\
channels/app/import_functions.go|\
channels/app/integration_action.go|\
channels/app/job_test.go|\
channels/app/migrations.go|\
channels/app/permissions.go|\
channels/app/permissions_test.go|\

16
server/channels/app/job_test.go
View file

@ -25,8 +25,10 @@ func TestGetJob(t *testing.T) {
_, err := th.App.Srv().Store().Job().Save(status)
require.NoError(t, err)
defer th.App.Srv().Store().Job().Delete(status.Id)
defer func() {
_, err = th.App.Srv().Store().Job().Delete(status.Id)
require.NoError(t, err)
}()
received, appErr := th.App.GetJob(th.Context, status.Id)
require.Nil(t, appErr)
@ -241,7 +243,10 @@ func TestGetJobByType(t *testing.T) {
for _, status := range statuses {
_, err := th.App.Srv().Store().Job().Save(status)
require.NoError(t, err)
defer th.App.Srv().Store().Job().Delete(status.Id)
defer func() {
_, err = th.App.Srv().Store().Job().Delete(status.Id)
require.NoError(t, err)
}()
}
received, err := th.App.GetJobsByType(th.Context, jobType, 0, 2)
@ -285,7 +290,10 @@ func TestGetJobsByTypes(t *testing.T) {
for _, status := range statuses {
_, err := th.App.Srv().Store().Job().Save(status)
require.NoError(t, err)
defer th.App.Srv().Store().Job().Delete(status.Id)
defer func() {
_, err = th.App.Srv().Store().Job().Delete(status.Id)
require.NoError(t, err)
}()
}
jobTypes := []string{jobType, jobType1, jobType2}