From 106cd66d69f6f2d89eaf8a5fd81e4c8a6ab4f7eb Mon Sep 17 00:00:00 2001 From: Sarthak0714 <91636065+sarthak0714@users.noreply.github.com> Date: Thu, 23 Jan 2025 19:40:17 +0530 Subject: [PATCH] migrate select * in thread_store.go (#29755) * migrate select * in thread_store.go * fix trailing whitespace * reverted to single query * maintained err handling pattern --------- Co-authored-by: Mattermost Build --- server/channels/store/sqlstore/thread_store.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/server/channels/store/sqlstore/thread_store.go b/server/channels/store/sqlstore/thread_store.go index 0153fd33971..97d293c92ce 100644 --- a/server/channels/store/sqlstore/thread_store.go +++ b/server/channels/store/sqlstore/thread_store.go @@ -1031,7 +1031,7 @@ func (s *SqlThreadStore) DeleteOrphanedRows(limit int) (deleted int64, err error // not if the root post has been deleted const threadMembershipsQuery = ` DELETE FROM ThreadMemberships WHERE PostId IN ( - SELECT * FROM ( + SELECT A.PostID FROM ( SELECT ThreadMemberships.PostId FROM ThreadMemberships LEFT JOIN Threads ON ThreadMemberships.PostId = Threads.PostId WHERE Threads.PostId IS NULL @@ -1043,10 +1043,12 @@ func (s *SqlThreadStore) DeleteOrphanedRows(limit int) (deleted int64, err error if err != nil { return } + deleted, err = result.RowsAffected() if err != nil { return } + return }