mattermost/webapp/Makefile

114 lines
2.9 KiB
Makefile
Raw Permalink Normal View History

-include config.override.mk
include config.mk
# The CI environment variable is set automatically in CircleCI and GitLab CI
CI ?= false
# Detect Linux/ARM64 and set a flag to fix the issue with optipng-bin on it:
# please see optipng-bin Linux arm64 support issue (https://github.com/imagemin/optipng-bin/issues/118) for details:
ifeq ($(shell uname)/$(shell uname -m),Linux/aarch64)
LINUX_ARM64 = true
CPPFLAGS += -DPNG_ARM_NEON_OPT=0
endif
# Exact same issue but for Linux/PPC64
ifeq ($(findstring Linux/ppc64,$(shell uname)/$(shell uname -m)),Linux/ppc64)
LINUX_PPC64 = true
CPPFLAGS += -DPNG_POWERPC_VSX_OPT=0
endif
.PHONY: run
run: node_modules ## Runs app
@echo Running Mattermost Web App for development
npm run run
.PHONY: stop
stop: ## Stops webpack
@echo Stopping changes watching
ifeq ($(OS),Windows_NT)
wmic process where "Caption='node.exe' and CommandLine like '%webpack%'" call terminate
else
-@pkill -f webpack || true
endif
.PHONY: restart
restart: | stop run ## Restarts the app
.PHONY: dev
dev: node_modules ## Runs app with webpack-dev-server
npm run dev-server
.PHONY: test
test: node_modules ## Runs tests
@echo Running jest unit/component testing
npm run test
.PHONY: check-style
check-style: node_modules ## Checks JS file for ESLint confirmity
@echo Checking for style guide compliance
npm run check
.PHONY: fix-style
fix-style: node_modules ## Fix JS file ESLint issues
@echo Fixing lint issues to follow style guide
npm run fix
.PHONY: check-types
check-types: node_modules ## Checks TS file for TypeScript confirmity
@echo Checking for TypeScript compliance
npm run check-types
MM-66653: migrate i18n extraction from mmjstool to @formatjs/cli (#34498) * feat(webapp): migrate i18n extraction from mmjstool to @formatjs/cli Replace custom mmjstool with industry-standard @formatjs/cli for i18n message extraction. Adds support for localizeMessage as a recognized extraction function and enables comprehensive ESLint rules for i18n. Changes by area: Dependencies (package.json): - Add @formatjs/cli v6.7.4 - Remove @mattermost/mmjstool dependency - Replace i18n-extract script with formatjs command - Remove mmjstool-specific scripts (clean-empty, check-empty-src) - Add i18n-extract:check for diff validation Code (utils.tsx): - Refactor localizeMessage to accept MessageDescriptor format - Support {id, defaultMessage, description} parameters - Maintain Redux store access (non-React context compatible) - Add comprehensive JSDoc documentation Linting (.eslintrc.json): - Configure formatjs settings with additionalFunctionNames - Enable 9 formatjs ESLint rules including enforce-id (error) - Ensure all messages require explicit manual IDs CI/CD (webapp-ci.yml): - Simplify i18n check to formatjs extraction + diff - Remove mmjstool and mobile-dir references Context: Second attempt at PR #25830. Uses manual IDs only with [id] placeholder pattern to enforce explicit ID requirements. ESLint will catch missing IDs during development. * chore(webapp): add temporary i18n reconciliation tooling Add helper script to analyze conflicts between en.json and defaultMessage values in code. This tooling will be reverted after initial migration cleanup is complete. Tooling added: - scripts/i18n-reconcile-conflicts.js: Analyzes conflicts - Detects spelling corrections - Identifies placeholder mismatches - Flags significant content changes - Provides recommendations on which version to keep - npm script: i18n-reconcile Usage: npm run i18n-reconcile This will be reverted after reconciling the ~50 duplicate message warnings and determining correct versions for conflicting messages. * chore(webapp): upgrade eslint-plugin-formatjs and centralize formatjs deps Move @formatjs/cli to root webapp package.json alongside other formatjs dependencies for better monorepo organization. Upgrade eslint-plugin-formatjs from 4.12.2 to 5.4.2 for latest features and bug fixes. Changes: - Upgrade eslint-plugin-formatjs: 4.12.2 → 5.4.2 - Move @formatjs/cli to webapp/package.json (from channels) - Centralize formatjs tooling at monorepo root level This provides: - Better dependency management in monorepo - Latest formatjs ESLint rules and features - Consistent tooling across workspaces * feat(webapp): make localizeMessage fully compatible with formatMessage API Extend localizeMessage to accept a values parameter for placeholder interpolation, making it fully compatible with react-intl's formatMessage API. Remove the now-redundant localizeAndFormatMessage function. Changes to localizeMessage: - Add values parameter for {placeholder} interpolation - Use getIntl() for proper ICU message formatting - Support full formatMessage feature parity outside React contexts - Update JSDoc with interpolation examples - Mark as deprecated (prefer useIntl in React components) Code cleanup: - Remove localizeAndFormatMessage function (redundant) - Migrate all localizeAndFormatMessage usages to localizeMessage - Remove unused imports: getCurrentLocale, getTranslations - Add getIntl import Files migrated: - notification_actions.tsx: notification.crt message - app_command_parser_dependencies.ts: intlShim formatMessage This consolidates i18n logic and provides a single, feature-complete localization function for non-React contexts. Example usage: // Before (old function) localizeAndFormatMessage( {id: 'welcome', defaultMessage: 'Hello {name}'}, {name: 'John'} ) // After (consolidated) localizeMessage( {id: 'welcome', defaultMessage: 'Hello {name}'}, {name: 'John'} ) * refactor(i18n): remove intlShim abstraction, use IntlShape directly Remove intlShim wrapper and use react-intl's IntlShape type throughout. Key Changes: - Remove intlShim constant from app_command_parser_dependencies.ts - Update errorMessage() signature to accept IntlShape parameter - Use IntlShape for intl properties in AppCommandParser and ParsedCommand - Call getIntl() at function start in actions (command.ts, marketplace.ts) - Pass IntlShape to AppCommandParser and doAppSubmit consistently Files Modified: - app_command_parser_dependencies.ts: Remove intlShim, update errorMessage - app_command_parser.ts: Use IntlShape type - command.ts, marketplace.ts: Call getIntl() early, pass to parser - app_provider.tsx, command_provider.tsx: Use getIntl() in constructor - apps.ts: Update doAppSubmit signature Benefits: Better type safety, standard react-intl patterns, eliminates unnecessary abstraction. Context: Part of migration to @formatjs/cli tooling. * refactor(webapp): remove deprecated t() function and refactor login validation Remove the deprecated t() function that was used as a marker for the old mmjstool extraction. With @formatjs/cli, this is no longer needed as extraction happens directly from formatMessage calls. Changes: - Remove t() function definition from utils/i18n.tsx - Remove t() import and marker calls from login.tsx - Refactor login validation logic from multiple if statements to a clean switch(true) pattern that evaluates boolean combinations directly - Add helpful comments documenting the structure of login method combinations - Add default case as safety fallback The switch(true) pattern eliminates the need to build a key string and makes the login method combination logic clearer and more maintainable. Prompt: Remove deprecated t() translation marker function used by old mmjstool. Refactor login validation from if blocks to switch(true) with boolean cases. * refactor(i18n): share IntlProvider's intl instance with getIntl() Make getIntl() return the same IntlShape instance that IntlProvider creates, ensuring consistency between React components (using useIntl()) and non-React contexts (using getIntl()). Changes: - Add intlInstance storage in utils/i18n.tsx - Export setIntl() function to store the intl instance - Modify getIntl() to return stored instance if available, with fallback to createIntl() for tests and early initialization - Add IntlCapture component in IntlProvider that uses useIntl() hook to capture and store the intl instance via setIntl() Benefits: - Single source of truth: Both React and non-React code use the same IntlShape - Consistent translations: No duplicate translation loading or potential desync - Leverages IntlProvider's translation loading lifecycle automatically - Maintains fallback for edge cases where IntlProvider hasn't mounted yet Prompt: Refactor getIntl() to reuse IntlProvider's intl instance instead of creating a separate instance, ensuring both React and non-React contexts use the same translations and intl configuration. * 1 * exclude test files * reset en.json * refactor(i18n): inline message ID constants for formatjs extraction Replace dynamic ID references with literal strings to enable proper formatjs extraction. Formatjs can only extract from static message IDs, not from variables or computed IDs. Changes: - configuration_bar.tsx: Inline AnnouncementBarMessages constants to literal string IDs ('announcement_bar.error.past_grace', 'announcement_bar.error.preview_mode') - system_analytics.test.tsx: Replace variable IDs (totalPlaybooksID, totalPlaybookRunsID) with literal strings ('total_playbooks', 'total_playbook_runs') - password.tsx: Use full message descriptor from passwordErrors object instead of dynamic ID with hardcoded defaultMessage. The errorId is still built dynamically using template strings, but the actual message is looked up from the passwordErrors defineMessages block where formatjs can extract it. This eliminates all "[id]" placeholder entries from extraction output and ensures all messages have proper extractable definitions. Prompt: Fix dynamic message ID references that formatjs extraction can't parse. Inline constants and use message descriptor lookups to enable clean extraction without [id] placeholders. * fix(i18n): add missing defaultMessage to drafts.tooltipText The drafts.tooltipText FormattedMessage had an empty defaultMessage, causing formatjs extraction to output an empty string for this message. Added the proper defaultMessage with plural formatting for draft and scheduled post counts. Prompt: Fix empty defaultMessage in drafts tooltip causing extraction issues. * feat(i18n): add --preserve-whitespace flag to formatjs extraction Add the --preserve-whitespace flag to ensure formatjs extraction maintains exact whitespace from defaultMessage values. This is important for messages with intentional formatting like tabs, multiple spaces, or line breaks. Prompt: Add --preserve-whitespace to i18n extraction to maintain exact formatting. * feat(i18n): add custom formatjs formatter matching mmjstool ordering Create custom formatter that replicates mmjstool's sorting behavior: - Case-insensitive alphabetical sorting - Underscore (_) sorts before dot (.) to match existing en.json ordering - Simple key-value format (extracts defaultMessage) The underscore-before-dot collation matches mmjstool's actual behavior and reduces diff size by 50% compared to standard alphabetical sorting. Changes: - scripts/formatter.js: Custom compareMessages, format, and compile functions - package.json: Use --format scripts/formatter.js instead of --format simple Prompt: Create custom formatjs formatter matching mmjstool's exact sorting behavior including underscore-before-dot collation to minimize migration diff. * feat(i18n): enhance reconciliation script with git history metadata Add git log lookups to show when each message was last modified in both en.json and code files. This enables data-driven decisions about which version to keep when resolving conflicts. Enhancements: - getEnJsonLastModified(): Find when an en.json entry last changed - findCodeFile(): Locate source file for a message ID (handles id= and id:) - getCodeLastModified(): Get last modification date for source files - Caching for performance (minimizes git operations) Output includes: 📅 en.json: [date] | [hash] | [commit message] 📅 code: [date] | [hash] | [commit message] 📂 file: [source file path] Analysis shows en.json entries from 2023 while code actively updated 2024-2025, indicating code is more authoritative. Prompt: Add git history to reconciliation report showing modification dates for data-driven conflict resolution decisions. * feat(i18n): add optional duplicate message ID check script Add i18n-extract:check-duplicates script that fails if the same message ID has different defaultMessages in multiple locations. This is kept as an optional standalone script rather than auto-chained with i18n-extract to allow the migration to proceed while duplicates are addressed separately. Usage: npm run i18n-extract:check-duplicates The script runs formatjs extract to /dev/null and checks stderr for "Duplicate message id" warnings, failing if any are found. Prompt: Add optional duplicate ID check as standalone npm script for gradual migration without blocking on existing duplicate message IDs. * about.enterpriseEditionLearn * admin.accesscontrol.title * eslint-plugin-formatjs version to eslint 8 compat * admin.channel_settings.channel_detail.access_control_policy_title * admin.connectionSecurityTls - now: admin.connectionSecurityTls.title * admin.customProfileAttribDesc now: - admin.customProfileAttribDesc.ldap - admin.customProfileAttribDesc.saml * admin.gitlab.clientSecretExample * package-lock * admin.google.EnableMarkdownDesc - fix err `]` in admin.google.EnableMarkdownDesc.openid - now: - admin.google.EnableMarkdownDesc.oauth - admin.google.EnableMarkdownDesc.openid * admin.image.amazonS3BucketExample - now: - admin.image.amazonS3BucketExample - admin.image.amazonS3BucketExampleExport * admin.license.trialCard.contactSales * admin.log.AdvancedLoggingJSONDescription - now: - admin.log.AdvancedLoggingJSONDescription - admin.log.AdvancedAuditLoggingJSONDescription * admin.rate.noteDescription - now - admin.rate.noteDescription - admin.info_banner.restart_required.desc (3) * admin.system_properties.user_properties.title - now: - admin.system_properties.user_properties.title - admin.accesscontrol.user_properties.link.label * admin.system_users.filters.team.allTeams, admin.system_users.filters.team.noTeams * admin.user_item.email_title * announcement_bar.error.preview_mode * channel_settings.error_purpose_length * deactivate_member_modal.desc - now: - deactivate_member_modal.desc - deactivate_member_modal.desc_with_confirmation * deleteChannelModal.canViewArchivedChannelsWarning * edit_channel_header_modal.error * filtered_channels_list.search - now: - filtered_channels_list.search - filtered_channels_list.search.label * flag_post.flag * generic_icons.collapse * installed_outgoing_oauth_connections.header * intro_messages.group_message * intro_messages.notificationPreferences - now: - intro_messages.notificationPreferences - intro_messages.notificationPreferences.label * katex.error * multiselect.placeholder - now: - multiselect.placeholder - multiselect.placeholder.addMembers * post_info.pin, post_info.unpin, rhs_root.mobile.flag take en.json * texteditor.rewrite.rewriting * user_groups_modal.addPeople split to user_groups_modal.addPeople.field_title * user.settings.general.validImage take en.json * userSettings.adminMode.modal_header take en.json * webapp.mattermost.feature.start_call split to user_profile.call.start * admin.general.localization.enableExperimentalLocalesDescription take en.json * login.contact_admin.title, login.contact_admin.detail take en.json * fix: correct spelling of "complementary" in accessibility sections * Revert "about.enterpriseEditionLearn" This reverts commit 23ababe1ce0aca746ad0e81d2cd5f4f19541d3d7. * about.enterpriseEditionLearn, about.planNameLearn * fix: improve clarity and consistency in activity log and command descriptions * fix: update emoji upload limits and improve help text for emoji creation * fix easy round 1 * fix: improve messaging for free trial notifications and sales contact take en.json * admin.billing.subscription.planDetails.features.limitedFileStorage take en.json * admin.billing.subscription.updatePaymentInfo take en.json * fix easy round 2 * admin.complianceExport.exportFormat.globalrelay take en.json * fix round 3 * fix round 4 * fix round 5 * fix round 6 * fix closing tag, newlines, and popout title * fix linting, + * update snapshots * test(webapp): update tests to match formatjs migration message changes Update test assertions to reflect message text changes from the mmjstool → @formatjs/cli migration. All changes align with the corresponding i18n message updates in the codebase. Changes: - limits.test.tsx: Update capitalization (Message History → Message history, File Storage → File storage) - emoji_picker.test.tsx: Update label (Recent → Recently Used) - command.test.js: Add period to error message - channel_activity_warning_modal.test.tsx: Update warning text assertion - channel_settings_archive_tab.test.tsx: Update archive warning text - feature_discovery.test.tsx: Update agreement name (Software and Services License Agreement → Software Evaluation Agreement) - flag_post_modal.test.tsx: Update placeholder text (Select a reason for flagging → Select a reason) - channel_intro_message.test.tsx: Remove trailing space from assertion - elasticsearch_settings.tsx: Fix searchableStrings placeholder names (documentationLink → link) to match updated message format All 983 test suites passing (12 tests fixed, 9088 tests total). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore(i18n): improve cross-platform compatibility and cleanup temporary tooling Simplify i18n check scripts to reuse npm run i18n-extract, improving cross-platform compatibility and reducing duplication. Changes: - Refactor i18n-extract:check to reuse base extraction command - Uses project-local temp file instead of /tmp (Windows compatible) - Simplified from duplicated formatjs command to npm run reuse - Add --throws flag to fail fast on extraction errors - Add helpful error message: "To update: npm run i18n-extract" - Add i18n-extract:check to main check script - Now runs alongside ESLint and Stylelint checks - Ensures en.json stays in sync with code changes - Remove i18n-extract:check-duplicates script - Redundant - duplicates are caught by i18n-extract automatically - Avoided grep dependency (not cross-platform) - Remove temporary reconciliation tooling - Deleted scripts/i18n-reconcile-conflicts.js (served its purpose) - Removed i18n-reconcile npm script - Add .i18n-check.tmp.json to .gitignore i18n-extract:check now works on Windows, macOS, and Linux. Requires only diff command (available via Git on Windows). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * ci(webapp): simplify i18n check using npm script Replace custom i18n check in CI with npm run i18n-extract:check for consistency with local development workflow. Changes: - Update check-i18n job to use npm run i18n-extract:check - Remove manual cp/extract/diff steps (3 lines → 1 line) - Consistent behavior between CI and local development - Cross-platform compatible (no /tmp dependency) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat(i18n): add i18n extraction targets to Makefile and workspace scripts Add Make targets and npm workspace scripts for i18n message extraction to provide consistent tooling access across the project. Changes: - Add make i18n-extract target to webapp/Makefile - Extracts i18n messages from code to en.json - Add make i18n-extract-check target to webapp/Makefile - Checks if en.json is in sync with code - Add i18n-extract workspace script to webapp/package.json - Runs extraction across all workspaces - Add i18n-extract:check workspace script to webapp/package.json - Runs sync check across all workspaces Usage: make i18n-extract # Extract messages make i18n-extract-check # Check if en.json needs update npm run i18n-extract # From webapp root npm run i18n-extract:check 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat(i18n): add cross-platform cleanup utility for temp files Add Node.js cleanup script to handle temporary file removal in a cross-platform manner, replacing platform-specific rm commands. Changes: - Add webapp/scripts/cleanup.js - Cross-platform file deletion utility - Silently handles missing files - Works on Windows/Mac/Linux - Update i18n-extract:check to use cleanup script - Removes .i18n-check.tmp.json after diff - Cleans up on both success and failure paths Usage: node scripts/cleanup.js <file1> [file2] [...] 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore(i18n): remove 'defineMessage' from additionalFunctionNames in ESLint config * chore(i18n): update i18n-extract check script and remove unused cleanup utility context: WSL is already required on windows * chore(i18n): remove ESLint rule disabling for formatjs placeholders in admin definition * chore(i18n): admin_definition - re-add defineMessage to eslint additionalfunctionnames - mark additional individual placeholder lines in admin_definition * fix(i18n): correct typo in enterprise edition link message * chore(i18n): fix escape sequences * revert emoji.ts changes * fix snapshots * fix admin.google.EnableMarkdownDesc - keep en.json but fix linkAPI and <strong>Create</strong> * restore newlines, and final corrections check * update snapshots * fix: i18n * chore(e2e): admin.complianceExport.exportJobStartTime.title * chore(e2e): emoji_picker.travel-places * chore(e2e): user.settings.general.incorrectPassword * chore(e2e): signup_user_completed.create * chore(e2e): fix Invite People * chore(fix): admin console email heading * chore(e2e): fix edit_channel_header_modal.placeholder * chore(e2e): fix Create account * chore(e2e): fix Create account * chore(e2e): correct success message text in password update alert * fix: admin guide label * chore(e2e): update role name in invite people combobox * chore(e2e): more "Create account" * chore(e2e): fix authentication_spec * lint --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Mattermost Build <build@mattermost.com>
2026-01-12 18:22:04 -05:00
.PHONY: i18n-extract
i18n-extract: node_modules ## Extracts i18n messages from code to en.json
@echo Extracting i18n messages
npm run i18n-extract
.PHONY: i18n-extract-check
i18n-extract-check: node_modules ## Checks if en.json is in sync with code
@echo Checking i18n message sync
npm run i18n-extract:check
.PHONY: dist
dist: node_modules ## Builds all web app packages
@echo Packaging Mattermost Web App
npm run build
node_modules: package.json $(wildcard package-lock.json)
@echo Getting dependencies using npm
ifeq ($(CI),false)
CPPFLAGS="$(CPPFLAGS)" npm install
else
# This runs in CI with NODE_ENV=production which skips devDependencies without this flag
npm ci --include=dev
endif
touch $@
.PHONY: clean
clean: ## Clears cached; deletes node_modules and dist directories
@echo Cleaning Web App
MM-66867/MM-67318 Add initial version of shared package (#35065) * Change moduleResolution to bundler This makes TS follow the module resolution of newer versions of Node.js which makes it use the `imports` and `exports` fields of the package.json while not requiring file extensions in some cases which it does when set to node16 or nodenext. I'm changing this to make it so that VS Code can correctly import things from our types package without adding `/src/` to the import path erroneously. Hopefully it doesn't introduce any other issues. * Change make clean to use package.json script * Remove missing fields from SystemEmoji type These were removed from emoji.json in https://github.com/mattermost/mattermost-webapp/pull/9597, but we forgot to remove the fields from the type definition. They weren't used anyway. * MM-66867 Add initial version of shared package This initial version includes the shared context, React Intl support (although that's currently untested), linting, and testing support. It builds with Parcel. * Move isSystemEmoji into Types package * MM-67318 Add Emoji component to shared package To limit the number of changes to the web app, it still uses RenderEmoji which wraps the new component for the time being. I'll likely replace RenderEmoji with using it directly in a future PR, but I may leave it as-is if the changes are too big because the API is different. * Add postinstall script to build shared package * Revert changes to moduleResolution and add typesVersions to shared package I plan to still change moduleResolution to bundler since it's the new default for TS projects, and since it lets TS use the exports field in package.json, but it requires other changes to fix some minor issues in this repo which I don't want to muddy this PR with. Adding typesVersions lets TS resolve the components in the shared package like it does with the types package while using the old value for moduleResolution. Plugins still use the old value for moduleResolution, so this will let them use the shared package with fewer updates changes as well. * Fix Webpack not always watching other packages for changes * Add shared package dependencies and build output to CI cache * Update @parcel/watcher to fix segfaults This package seems to be older than the rest of the newly added Parcel dependencies because it's used by sass. * Fix build script not doing that * Go back to manually specifying postinstall order I just learned that postinstall scripts run in parallel because I was running into an issue where the client and types packages were building at the same time, causing one of them to fail. They still run in parallel, so that may still occasionally happen, but by specifying the order manually, we hopefully avoid that happening like we seemed to do before. * Further revert changes to postinstall script The subpackages were also being built when installed by a plugin * Increment cache keys * Fix typo * Change the cache busting to look at shared/package.json * Attempt to debug tests and caching * Debugging... * Add shared package to platform code coverage * Remove caching of package builds and manually run postinstall during web app CI setup * Debugging... * Remove CI debugging logic * Update package-lock.json * Change Emoji component back to taking an emojiName prop * Add .parcel-cache to .gitignore
2026-02-13 14:53:10 -05:00
npm run clean
.PHONY: package
package: node_modules dist ## Generates ./mattermost-webapp.tar.gz for use by someone customizing the web app
mkdir tmp
mv channels/dist tmp/client
tar -C tmp -czf mattermost-webapp.tar.gz client
mv tmp/client channels/dist
rmdir tmp
## Help documentation à la https://marmelab.com/blog/2016/02/29/auto-documented-makefile.html
.PHONY: help
help:
@grep -E '^[0-9a-zA-Z_-]+:.*?## .*$$' ./Makefile | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'