kubernetes/pkg/controller/volume/attachdetach
Patrick Ohly 9eaa2dc554 avoid klog Info calls without verbosity
In the following code pattern, the log message will get logged with v=0 in JSON
output although conceptually it has a higher verbosity:

   if klog.V(5).Enabled() {
       klog.Info("hello world")
   }

Having the actual verbosity in the JSON output is relevant, for example for
filtering out only the important info messages. The solution is to use
klog.V(5).Info or something similar.

Whether the outer if is necessary at all depends on how complex the parameters
are. The return value of klog.V can be captured in a variable and be used
multiple times to avoid the overhead for that function call and to avoid
repeating the verbosity level.
2022-01-12 07:48:36 +01:00
..
cache Fix issue in node status updating VolumeAttached list 2021-10-05 09:44:35 -07:00
config generated: Run hack/update-gofmt.sh 2021-08-24 15:47:49 -04:00
metrics fixing unit test failures induced by turning on CSIMigrationGCE 2021-11-16 19:26:30 +00:00
populator fixing unit test failures induced by turning on CSIMigrationGCE 2021-11-16 19:26:30 +00:00
reconciler avoid klog Info calls without verbosity 2022-01-12 07:48:36 +01:00
statusupdater move pkg/util/node to component-helpers/node/util (#105347) 2021-11-12 07:52:27 -08:00
testing Pass FsGroup to MountDevice 2021-07-03 16:29:42 -07:00
util generic ephemeral volume: graduation to GA 2021-10-11 20:54:20 +02:00
attach_detach_controller.go use node informer to check volumes attachment status before backoff 2021-12-20 11:57:05 -05:00
attach_detach_controller_test.go fixing unit test failures induced by turning on CSIMigrationGCE 2021-11-16 19:26:30 +00:00
OWNERS Check in OWNERS modified by update-yamlfmt.sh 2021-12-09 21:31:26 -05:00